From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ceph: Fix an Oops in error handling
Date: Tue, 2 Feb 2021 17:19:57 +0300 [thread overview]
Message-ID: <20210202141957.GC20820@kadam> (raw)
In-Reply-To: <f0477211cafbdc24883e978ab976610333f5fb67.camel@kernel.org>
On Tue, Feb 02, 2021 at 07:37:57AM -0500, Jeff Layton wrote:
> On Tue, 2021-02-02 at 08:47 +0300, Dan Carpenter wrote:
> > The "req" pointer is an error pointer and not NULL so this check needs
> > to be fixed.
> >
> > Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > fs/ceph/addr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> > index 5eec6f66fe52..fb0238a4d34f 100644
> > --- a/fs/ceph/addr.c
> > +++ b/fs/ceph/addr.c
> > @@ -273,7 +273,7 @@ static void ceph_netfs_issue_op(struct netfs_read_subrequest *subreq)
> > if (err)
> > iput(inode);
> > out:
> > - if (req)
> > + if (!IS_ERR_OR_NULL(req))
> > ceph_osdc_put_request(req);
> > if (err)
> > netfs_subreq_terminated(subreq, err);
>
> Good catch.
>
> David, could you take this into your fscache-next branch?
>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
Jeff sent a different fix for this. Let's just apply his instead.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ceph: Fix an Oops in error handling
Date: Tue, 02 Feb 2021 14:19:57 +0000 [thread overview]
Message-ID: <20210202141957.GC20820@kadam> (raw)
In-Reply-To: <f0477211cafbdc24883e978ab976610333f5fb67.camel@kernel.org>
On Tue, Feb 02, 2021 at 07:37:57AM -0500, Jeff Layton wrote:
> On Tue, 2021-02-02 at 08:47 +0300, Dan Carpenter wrote:
> > The "req" pointer is an error pointer and not NULL so this check needs
> > to be fixed.
> >
> > Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > fs/ceph/addr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> > index 5eec6f66fe52..fb0238a4d34f 100644
> > --- a/fs/ceph/addr.c
> > +++ b/fs/ceph/addr.c
> > @@ -273,7 +273,7 @@ static void ceph_netfs_issue_op(struct netfs_read_subrequest *subreq)
> > if (err)
> > iput(inode);
> > out:
> > - if (req)
> > + if (!IS_ERR_OR_NULL(req))
> > ceph_osdc_put_request(req);
> > if (err)
> > netfs_subreq_terminated(subreq, err);
>
> Good catch.
>
> David, could you take this into your fscache-next branch?
>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
Jeff sent a different fix for this. Let's just apply his instead.
regards,
dan carpenter
next prev parent reply other threads:[~2021-02-02 14:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 5:47 [PATCH] ceph: Fix an Oops in error handling Dan Carpenter
2021-02-02 5:47 ` Dan Carpenter
2021-02-02 12:35 ` Ilya Dryomov
2021-02-02 12:35 ` Ilya Dryomov
2021-02-02 12:37 ` Jeff Layton
2021-02-02 12:37 ` Jeff Layton
2021-02-02 14:19 ` Dan Carpenter [this message]
2021-02-02 14:19 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-02-02 13:10 [PATCH] ceph: fix an oops in error handling in ceph_netfs_issue_op Jeff Layton
2021-02-02 13:10 ` Jeff Layton
2021-02-02 14:20 ` Dan Carpenter
2021-02-02 14:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202141957.GC20820@kadam \
--to=dan.carpenter@oracle.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.