From: Jens Wiklander <jens.wiklander@linaro.org>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH] tee: optee: remove need_resched() before cond_resched()
Date: Wed, 03 Feb 2021 08:10:36 +0100 [thread overview]
Message-ID: <20210203071036.GA3603358@jade> (raw)
In-Reply-To: < <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>>
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
On Fri, Jan 29, 2021 at 02:29:33PM +0100, Jens Wiklander wrote:
> Hi Rouven and Sumit,
>
> On Mon, Jan 25, 2021 at 10:58 AM Jens Wiklander via OP-TEE
> <op-tee@lists.trustedfirmware.org> wrote:
> >
> > Hi Rouven and Sumit,
> >
> > On Mon, Jan 25, 2021 at 10:55 AM Jens Wiklander
> > <jens.wiklander@linaro.org> wrote:
> > >
> > > Testing need_resched() before cond_resched() is not needed as an
> > > equivalent test is done internally in cond_resched(). So drop the
> > > need_resched() test.
> > >
> > > Fixes: dcb3b06d9c34 ("tee: optee: replace might_sleep with cond_resched")
> > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> > > ---
> > > drivers/tee/optee/call.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Can you please test to see that this works in your setups too?
>
> Does this work for you? I'd like to get this patch ready for v5.12.
Thanks for the help with this patch. I'll submit this up for v5.12.
Cheers,
Jens
WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>,
Sumit Garg <sumit.garg@linaro.org>
Cc: Arnd Bergmann <arnd@kernel.org>,
op-tee@lists.trustedfirmware.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tee: optee: remove need_resched() before cond_resched()
Date: Wed, 3 Feb 2021 08:10:36 +0100 [thread overview]
Message-ID: <20210203071036.GA3603358@jade> (raw)
In-Reply-To: <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>
On Fri, Jan 29, 2021 at 02:29:33PM +0100, Jens Wiklander wrote:
> Hi Rouven and Sumit,
>
> On Mon, Jan 25, 2021 at 10:58 AM Jens Wiklander via OP-TEE
> <op-tee@lists.trustedfirmware.org> wrote:
> >
> > Hi Rouven and Sumit,
> >
> > On Mon, Jan 25, 2021 at 10:55 AM Jens Wiklander
> > <jens.wiklander@linaro.org> wrote:
> > >
> > > Testing need_resched() before cond_resched() is not needed as an
> > > equivalent test is done internally in cond_resched(). So drop the
> > > need_resched() test.
> > >
> > > Fixes: dcb3b06d9c34 ("tee: optee: replace might_sleep with cond_resched")
> > > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> > > ---
> > > drivers/tee/optee/call.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Can you please test to see that this works in your setups too?
>
> Does this work for you? I'd like to get this patch ready for v5.12.
Thanks for the help with this patch. I'll submit this up for v5.12.
Cheers,
Jens
next prev parent reply other threads:[~2021-02-03 7:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] < <CAHUa44GsbxO=wJ_o-AZsxNvKOhn=y=dexkrN17zCy=7+0=1ZQg@mail.gmail.com>
2021-01-29 13:42 ` [PATCH] tee: optee: remove need_resched() before cond_resched() Rouven Czerwinski
2021-01-31 8:13 ` Rouven Czerwinski
2021-01-31 8:13 ` Rouven Czerwinski
2021-02-01 5:02 ` Sumit Garg
2021-02-01 5:02 ` Sumit Garg
2021-02-03 7:10 ` Jens Wiklander [this message]
2021-02-03 7:10 ` Jens Wiklander
[not found] <=?utf-8?q?=3C0100017738faac80-87e5cf40-6a5a-4727-9c36-382fb909c?= =?utf-8?q?8ff-000000=40email=2Eamazonses=2Ecom=3E?=>
2021-01-29 13:29 ` Jens Wiklander
2021-01-25 9:54 Jens Wiklander
2021-01-25 9:54 ` Jens Wiklander
2021-01-25 9:57 ` Jens Wiklander
2021-01-25 9:57 ` Jens Wiklander
2021-01-29 13:58 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203071036.GA3603358@jade \
--to=jens.wiklander@linaro.org \
--cc=op-tee@lists.trustedfirmware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.