From: Christoph Hellwig <hch@lst.de>
To: Filippo Sironi <sironi@amazon.de>
Cc: sagi@grimberg.me, serebrin@amazon.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
axboe@fb.com, kbusch@kernel.org, Christoph Hellwig <hch@lst.de>,
dwmw@amazon.co.uk
Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk
Date: Wed, 3 Feb 2021 12:26:45 +0100 [thread overview]
Message-ID: <20210203112645.GA11942@lst.de> (raw)
In-Reply-To: <396b45d5-3dd5-8159-34c2-5668510d1d68@amazon.de>
On Wed, Feb 03, 2021 at 12:22:31PM +0100, Filippo Sironi wrote:
> To avoid issues, it is easier to apply the quirk to all Amazon NVMe
> controllers for now till the new lines of controllers with the fix comes
> out. At that point, we'll be able to restrict the application to the known
> bad controllers.
No, that is simply not acceptable. For one we've had enough cases where
knowlege about old devices was lost after a decade or so. And secondly
shipping more of these broken devices should be as painful as possible
for you so that it preferably does not happen at all.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Filippo Sironi <sironi@amazon.de>
Cc: Christoph Hellwig <hch@lst.de>,
serebrin@amazon.com, dwmw@amazon.co.uk, kbusch@kernel.org,
axboe@fb.com, sagi@grimberg.me, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk
Date: Wed, 3 Feb 2021 12:26:45 +0100 [thread overview]
Message-ID: <20210203112645.GA11942@lst.de> (raw)
In-Reply-To: <396b45d5-3dd5-8159-34c2-5668510d1d68@amazon.de>
On Wed, Feb 03, 2021 at 12:22:31PM +0100, Filippo Sironi wrote:
> To avoid issues, it is easier to apply the quirk to all Amazon NVMe
> controllers for now till the new lines of controllers with the fix comes
> out. At that point, we'll be able to restrict the application to the known
> bad controllers.
No, that is simply not acceptable. For one we've had enough cases where
knowlege about old devices was lost after a decade or so. And secondly
shipping more of these broken devices should be as painful as possible
for you so that it preferably does not happen at all.
next prev parent reply other threads:[~2021-02-03 11:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 9:43 [PATCH] nvme: Add 48-bit DMA address quirk Filippo Sironi
2021-02-03 9:43 ` Filippo Sironi
2021-02-03 9:51 ` Christoph Hellwig
2021-02-03 9:51 ` Christoph Hellwig
2021-02-03 11:12 ` Filippo Sironi
2021-02-03 11:12 ` Filippo Sironi
2021-02-03 11:15 ` Christoph Hellwig
2021-02-03 11:15 ` Christoph Hellwig
2021-02-03 11:22 ` Filippo Sironi
2021-02-03 11:22 ` Filippo Sironi
2021-02-03 11:26 ` Christoph Hellwig [this message]
2021-02-03 11:26 ` Christoph Hellwig
2021-02-03 16:57 ` Keith Busch
2021-02-03 16:57 ` Keith Busch
2021-02-10 0:39 ` [PATCH v2] nvme: Add 48-bit DMA address quirk for Amazon NVMe controllers Filippo Sironi
2021-02-10 0:39 ` Filippo Sironi
2021-02-10 7:37 ` Christoph Hellwig
2021-02-10 7:37 ` Christoph Hellwig
2021-02-10 9:13 ` Filippo Sironi
2021-02-10 9:13 ` Filippo Sironi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203112645.GA11942@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=dwmw@amazon.co.uk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=serebrin@amazon.com \
--cc=sironi@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.