From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] usb: cdnsp: Fix spelling mistake "delagete" -> "delegate"
Date: Wed, 03 Feb 2021 13:06:50 +0000 [thread overview]
Message-ID: <20210203130440.GV2696@kadam> (raw)
In-Reply-To: <20210203111239.18313-1-colin.king@canonical.com>
On Wed, Feb 03, 2021 at 11:12:39AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a literal string. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/cdns3/cdnsp-ep0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/cdnsp-ep0.c b/drivers/usb/cdns3/cdnsp-ep0.c
> index e2b1bcb3f80e..e30931ebc870 100644
> --- a/drivers/usb/cdns3/cdnsp-ep0.c
> +++ b/drivers/usb/cdns3/cdnsp-ep0.c
> @@ -45,7 +45,7 @@ static int cdnsp_ep0_delegate_req(struct cdnsp_device *pdev,
> {
> int ret;
>
> - trace_cdnsp_ep0_request("delagete");
> + trace_cdnsp_ep0_request("delegate");
>
This printk is useless and should just be deleted. Use ftrace instead.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] usb: cdnsp: Fix spelling mistake "delagete" -> "delegate"
Date: Wed, 3 Feb 2021 16:06:50 +0300 [thread overview]
Message-ID: <20210203130440.GV2696@kadam> (raw)
In-Reply-To: <20210203111239.18313-1-colin.king@canonical.com>
On Wed, Feb 03, 2021 at 11:12:39AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a spelling mistake in a literal string. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/usb/cdns3/cdnsp-ep0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/cdnsp-ep0.c b/drivers/usb/cdns3/cdnsp-ep0.c
> index e2b1bcb3f80e..e30931ebc870 100644
> --- a/drivers/usb/cdns3/cdnsp-ep0.c
> +++ b/drivers/usb/cdns3/cdnsp-ep0.c
> @@ -45,7 +45,7 @@ static int cdnsp_ep0_delegate_req(struct cdnsp_device *pdev,
> {
> int ret;
>
> - trace_cdnsp_ep0_request("delagete");
> + trace_cdnsp_ep0_request("delegate");
>
This printk is useless and should just be deleted. Use ftrace instead.
regards,
dan carpenter
next prev parent reply other threads:[~2021-02-03 13:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 22:28 [PATCH][next] usb: cdnsp: fix spelling mistake "delagete" -> "delegate" Colin King
2021-02-03 11:12 ` [PATCH][next] usb: cdnsp: Fix " Colin King
2021-02-03 11:12 ` Colin King
2021-02-03 13:06 ` Dan Carpenter [this message]
2021-02-03 13:06 ` Dan Carpenter
2021-02-04 5:07 ` Pawel Laszczak
2021-02-04 5:07 ` Pawel Laszczak
2021-02-04 6:30 ` Greg Kroah-Hartman
2021-02-04 6:30 ` Greg Kroah-Hartman
2021-02-04 9:25 ` Pawel Laszczak
2021-02-04 9:25 ` Pawel Laszczak
2021-02-04 9:25 ` Colin Ian King
2021-02-04 9:25 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203130440.GV2696@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.