From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Huazhong Tan <tanhuazhong@huawei.com>,
Guangbin Huang <huangguangbin2@huawei.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] net: hns3: remove redundant null check of an array
Date: Wed, 03 Feb 2021 23:24:25 +0000 [thread overview]
Message-ID: <20210203152425.00007a51@intel.com> (raw)
In-Reply-To: <20210203131040.21656-1-colin.king@canonical.com>
Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The null check of filp->f_path.dentry->d_iname is redundant because
> it is an array of DNAME_INLINE_LEN chars and cannot be a null. Fix
> this by removing the null check.
>
> Addresses-Coverity: ("Array compared against 0")
> Fixes: 04987ca1b9b6 ("net: hns3: add debugfs support for tm nodes, priority and qset info")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Colin King <colin.king@canonical.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S . Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
Huazhong Tan <tanhuazhong@huawei.com>,
"Guangbin Huang" <huangguangbin2@huawei.com>,
<netdev@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] net: hns3: remove redundant null check of an array
Date: Wed, 3 Feb 2021 15:24:25 -0800 [thread overview]
Message-ID: <20210203152425.00007a51@intel.com> (raw)
In-Reply-To: <20210203131040.21656-1-colin.king@canonical.com>
Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The null check of filp->f_path.dentry->d_iname is redundant because
> it is an array of DNAME_INLINE_LEN chars and cannot be a null. Fix
> this by removing the null check.
>
> Addresses-Coverity: ("Array compared against 0")
> Fixes: 04987ca1b9b6 ("net: hns3: add debugfs support for tm nodes, priority and qset info")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2021-02-03 23:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 7:29 [PATCH][next] net: hns3: remove redundant assignment to pointer reg_info Colin King
2019-08-31 7:29 ` Colin King
2019-09-01 19:12 ` David Miller
2019-09-01 19:12 ` David Miller
2021-02-03 13:10 ` [PATCH][next] net: hns3: remove redundant null check of an array Colin King
2021-02-03 13:10 ` Colin King
2021-02-03 23:24 ` Jesse Brandeburg [this message]
2021-02-03 23:24 ` Jesse Brandeburg
2021-02-05 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203152425.00007a51@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=huangguangbin2@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.