From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH RESEND v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions
Date: Thu, 4 Feb 2021 11:52:20 -0800 [thread overview]
Message-ID: <20210204115220.0000018d@intel.com> (raw)
In-Reply-To: <20210202133030.5760-5-alobakin@pm.me>
Alexander Lobakin wrote:
> Now we can remove a bunch of identical functions from the drivers and
> make them use common dev_page_is_reusable(). All {,un}likely() checks
> are omitted since it's already present in this helper.
> Also update some comments near the call sites.
>
> Suggested-by: David Rientjes <rientjes@google.com>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
I don't know why it was missed in the series update, but:
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Alexander Lobakin <alobakin@pm.me>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
John Hubbard <jhubbard@nvidia.com>,
David Rientjes <rientjes@google.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Willem de Bruijn <willemb@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Dexuan Cui <decui@microsoft.com>,
Jakub Sitnicki <jakub@cloudflare.com>,
Marco Elver <elver@google.com>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH RESEND v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions
Date: Thu, 4 Feb 2021 11:52:20 -0800 [thread overview]
Message-ID: <20210204115220.0000018d@intel.com> (raw)
In-Reply-To: <20210202133030.5760-5-alobakin@pm.me>
Alexander Lobakin wrote:
> Now we can remove a bunch of identical functions from the drivers and
> make them use common dev_page_is_reusable(). All {,un}likely() checks
> are omitted since it's already present in this helper.
> Also update some comments near the call sites.
>
> Suggested-by: David Rientjes <rientjes@google.com>
> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> Cc: John Hubbard <jhubbard@nvidia.com>
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
I don't know why it was missed in the series update, but:
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2021-02-04 19:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 13:30 [Intel-wired-lan] [PATCH RESEND v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage Alexander Lobakin
2021-02-02 13:30 ` Alexander Lobakin
2021-02-02 13:30 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 1/5] mm: constify page_is_pfmemalloc() argument Alexander Lobakin
2021-02-02 13:30 ` Alexander Lobakin
2021-02-02 13:31 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 2/5] skbuff: constify skb_propagate_pfmemalloc() "page" argument Alexander Lobakin
2021-02-02 13:31 ` Alexander Lobakin
2021-02-02 13:31 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 3/5] net: introduce common dev_page_is_reusable() Alexander Lobakin
2021-02-02 13:31 ` Alexander Lobakin
2021-02-02 13:31 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions Alexander Lobakin
2021-02-02 13:31 ` Alexander Lobakin
2021-02-04 19:52 ` Jesse Brandeburg [this message]
2021-02-04 19:52 ` Jesse Brandeburg
2021-02-02 13:31 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 5/5] net: page_pool: simplify page recycling condition tests Alexander Lobakin
2021-02-02 13:31 ` Alexander Lobakin
2021-02-05 2:40 ` [Intel-wired-lan] [PATCH RESEND v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage patchwork-bot+netdevbpf
2021-02-05 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204115220.0000018d@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.