All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	devicetree@vger.kernel.org,
	Gregory Clement <gregory.clement@bootlin.com>,
	linux-kernel@vger.kernel.org,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver
Date: Fri, 5 Feb 2021 16:35:26 -0600	[thread overview]
Message-ID: <20210205223526.GA3869001@robh.at.kernel.org> (raw)
In-Reply-To: <20210120081921.3315847-4-steen.hegelund@microchip.com>

On Wed, Jan 20, 2021 at 09:19:21AM +0100, Steen Hegelund wrote:
> This provides reset driver support for the Microchip Sparx5 PCB134 and
> PCB135 reference boards.

This isn't a compatible change. You need an explanation why that's okay 
if that's intended.

> 
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> ---
>  arch/arm64/boot/dts/microchip/sparx5.dtsi | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi
> index 380281f312d8..4edbb9fcdce0 100644
> --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi
> +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi
> @@ -132,9 +132,17 @@ mux: mux-controller {
>  			};
>  		};
>  
> -		reset@611010008 {
> -			compatible = "microchip,sparx5-chip-reset";
> -			reg = <0x6 0x11010008 0x4>;
> +		gcb_ctrl: syscon@611010000 {
> +			compatible = "microchip,sparx5-gcb-syscon", "syscon";
> +			reg = <0x6 0x11010000 0x10000>;
> +		};
> +
> +		reset: reset-controller@0 {
> +			compatible = "microchip,sparx5-switch-reset";
> +			reg = <0x6 0x0 0x0>;

Your register length is 0?

> +			#reset-cells = <1>;
> +			cpu-syscon = <&cpu_ctrl>;

Can't you accomplish the same thing adding these to 
"microchip,sparx5-chip-reset"? Or possibly as a child node.

Define nodes based on h/w blocks, not as containers of things you happen 
to want for some driver.

> +			gcb-syscon = <&gcb_ctrl>;
>  		};
>  
>  		uart0: serial@600100000 {
> -- 
> 2.29.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	Andrew Lunn <andrew@lunn.ch>,
	Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver
Date: Fri, 5 Feb 2021 16:35:26 -0600	[thread overview]
Message-ID: <20210205223526.GA3869001@robh.at.kernel.org> (raw)
In-Reply-To: <20210120081921.3315847-4-steen.hegelund@microchip.com>

On Wed, Jan 20, 2021 at 09:19:21AM +0100, Steen Hegelund wrote:
> This provides reset driver support for the Microchip Sparx5 PCB134 and
> PCB135 reference boards.

This isn't a compatible change. You need an explanation why that's okay 
if that's intended.

> 
> Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> ---
>  arch/arm64/boot/dts/microchip/sparx5.dtsi | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/microchip/sparx5.dtsi b/arch/arm64/boot/dts/microchip/sparx5.dtsi
> index 380281f312d8..4edbb9fcdce0 100644
> --- a/arch/arm64/boot/dts/microchip/sparx5.dtsi
> +++ b/arch/arm64/boot/dts/microchip/sparx5.dtsi
> @@ -132,9 +132,17 @@ mux: mux-controller {
>  			};
>  		};
>  
> -		reset@611010008 {
> -			compatible = "microchip,sparx5-chip-reset";
> -			reg = <0x6 0x11010008 0x4>;
> +		gcb_ctrl: syscon@611010000 {
> +			compatible = "microchip,sparx5-gcb-syscon", "syscon";
> +			reg = <0x6 0x11010000 0x10000>;
> +		};
> +
> +		reset: reset-controller@0 {
> +			compatible = "microchip,sparx5-switch-reset";
> +			reg = <0x6 0x0 0x0>;

Your register length is 0?

> +			#reset-cells = <1>;
> +			cpu-syscon = <&cpu_ctrl>;

Can't you accomplish the same thing adding these to 
"microchip,sparx5-chip-reset"? Or possibly as a child node.

Define nodes based on h/w blocks, not as containers of things you happen 
to want for some driver.

> +			gcb-syscon = <&gcb_ctrl>;
>  		};
>  
>  		uart0: serial@600100000 {
> -- 
> 2.29.2
> 

  reply	other threads:[~2021-02-05 22:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  8:19 [PATCH v4 0/3] Adding the Sparx5 Switch Reset Driver Steen Hegelund
2021-01-20  8:19 ` Steen Hegelund
2021-01-20  8:19 ` [PATCH v4 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings Steen Hegelund
2021-01-20  8:19   ` Steen Hegelund
2021-01-20  8:19 ` [PATCH v4 2/3] reset: mchp: sparx5: add switch reset driver Steen Hegelund
2021-01-20  8:19   ` Steen Hegelund
2021-01-20  8:19 ` [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 " Steen Hegelund
2021-01-20  8:19   ` Steen Hegelund
2021-02-05 22:35   ` Rob Herring [this message]
2021-02-05 22:35     ` Rob Herring
2021-02-08  7:58     ` Steen Hegelund
2021-02-08  7:58       ` Steen Hegelund
2021-02-08 13:20     ` Steen Hegelund
2021-02-08 13:20       ` Steen Hegelund
2021-02-08 17:00       ` Rob Herring
2021-02-08 17:00         ` Rob Herring
2021-02-03  8:02 ` [PATCH v4 0/3] Adding the Sparx5 Switch Reset Driver Steen Hegelund
2021-02-03  8:02   ` Steen Hegelund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205223526.GA3869001@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=steen.hegelund@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.