All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] jfs: turn diLog(), dataLog() and txLog() into void functions
Date: Sun, 07 Feb 2021 15:44:12 +0800	[thread overview]
Message-ID: <202102071518.tkDgzNeX-lkp@intel.com> (raw)
In-Reply-To: <1612679820-35163-1-git-send-email-yang.lee@linux.alibaba.com>

[-- Attachment #1: Type: text/plain, Size: 5837 bytes --]

Hi Yang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on shaggy/jfs-next]
[also build test WARNING on v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yang-Li/jfs-turn-diLog-dataLog-and-txLog-into-void-functions/20210207-143938
base:   https://github.com/kleikamp/linux-shaggy jfs-next
config: i386-randconfig-m021-20210207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/8b7ab4ba41269109e7cb95106023e96d640842e9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yang-Li/jfs-turn-diLog-dataLog-and-txLog-into-void-functions/20210207-143938
        git checkout 8b7ab4ba41269109e7cb95106023e96d640842e9
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/jfs/jfs_txnmgr.c:1368:13: error: conflicting types for 'txLog'
    1368 | static void txLog(struct jfs_log *log, struct tblock *tblk, struct commit *cd)
         |             ^~~~~
   fs/jfs/jfs_txnmgr.c:162:12: note: previous declaration of 'txLog' was here
     162 | static int txLog(struct jfs_log * log, struct tblock * tblk,
         |            ^~~~~
   fs/jfs/jfs_txnmgr.c:1424:13: error: conflicting types for 'diLog'
    1424 | static void diLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~
   fs/jfs/jfs_txnmgr.c:151:12: note: previous declaration of 'diLog' was here
     151 | static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~
   fs/jfs/jfs_txnmgr.c:1536:13: error: conflicting types for 'dataLog'
    1536 | static void dataLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~~~
   fs/jfs/jfs_txnmgr.c:153:12: note: previous declaration of 'dataLog' was here
     153 | static int dataLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~~~
>> fs/jfs/jfs_txnmgr.c:151:12: warning: 'diLog' used but never defined
     151 | static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~
>> fs/jfs/jfs_txnmgr.c:153:12: warning: 'dataLog' used but never defined
     153 | static int dataLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~~~
>> fs/jfs/jfs_txnmgr.c:162:12: warning: 'txLog' used but never defined
     162 | static int txLog(struct jfs_log * log, struct tblock * tblk,
         |            ^~~~~
   fs/jfs/jfs_txnmgr.c:1536:13: warning: 'dataLog' defined but not used [-Wunused-function]
    1536 | static void dataLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~~~
   fs/jfs/jfs_txnmgr.c:1424:13: warning: 'diLog' defined but not used [-Wunused-function]
    1424 | static void diLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~
   fs/jfs/jfs_txnmgr.c:1368:13: warning: 'txLog' defined but not used [-Wunused-function]
    1368 | static void txLog(struct jfs_log *log, struct tblock *tblk, struct commit *cd)
         |             ^~~~~


vim +/diLog +151 fs/jfs/jfs_txnmgr.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  147  
^1da177e4c3f41 Linus Torvalds 2005-04-16  148  /*
^1da177e4c3f41 Linus Torvalds 2005-04-16  149   * forward references
^1da177e4c3f41 Linus Torvalds 2005-04-16  150   */
^1da177e4c3f41 Linus Torvalds 2005-04-16 @151  static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  152  		struct tlock * tlck, struct commit * cd);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @153  static int dataLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  154  		struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  155  static void dtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  156  		struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  157  static void mapLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  158  		struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  159  static void txAllocPMap(struct inode *ip, struct maplock * maplock,
^1da177e4c3f41 Linus Torvalds 2005-04-16  160  		struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16  161  static void txForce(struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @162  static int txLog(struct jfs_log * log, struct tblock * tblk,
^1da177e4c3f41 Linus Torvalds 2005-04-16  163  		struct commit * cd);
^1da177e4c3f41 Linus Torvalds 2005-04-16  164  static void txUpdateMap(struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16  165  static void txRelease(struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16  166  static void xtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  167  	   struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  168  static void LogSyncRelease(struct metapage * mp);
^1da177e4c3f41 Linus Torvalds 2005-04-16  169  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38339 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>, shaggy@kernel.org
Cc: kbuild-all@lists.01.org, jfs-discussion@lists.sourceforge.net,
	linux-kernel@vger.kernel.org,
	Yang Li <yang.lee@linux.alibaba.com>
Subject: Re: [PATCH] jfs: turn diLog(), dataLog() and txLog() into void functions
Date: Sun, 7 Feb 2021 15:44:12 +0800	[thread overview]
Message-ID: <202102071518.tkDgzNeX-lkp@intel.com> (raw)
In-Reply-To: <1612679820-35163-1-git-send-email-yang.lee@linux.alibaba.com>

[-- Attachment #1: Type: text/plain, Size: 5741 bytes --]

Hi Yang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on shaggy/jfs-next]
[also build test WARNING on v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yang-Li/jfs-turn-diLog-dataLog-and-txLog-into-void-functions/20210207-143938
base:   https://github.com/kleikamp/linux-shaggy jfs-next
config: i386-randconfig-m021-20210207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/8b7ab4ba41269109e7cb95106023e96d640842e9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yang-Li/jfs-turn-diLog-dataLog-and-txLog-into-void-functions/20210207-143938
        git checkout 8b7ab4ba41269109e7cb95106023e96d640842e9
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/jfs/jfs_txnmgr.c:1368:13: error: conflicting types for 'txLog'
    1368 | static void txLog(struct jfs_log *log, struct tblock *tblk, struct commit *cd)
         |             ^~~~~
   fs/jfs/jfs_txnmgr.c:162:12: note: previous declaration of 'txLog' was here
     162 | static int txLog(struct jfs_log * log, struct tblock * tblk,
         |            ^~~~~
   fs/jfs/jfs_txnmgr.c:1424:13: error: conflicting types for 'diLog'
    1424 | static void diLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~
   fs/jfs/jfs_txnmgr.c:151:12: note: previous declaration of 'diLog' was here
     151 | static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~
   fs/jfs/jfs_txnmgr.c:1536:13: error: conflicting types for 'dataLog'
    1536 | static void dataLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~~~
   fs/jfs/jfs_txnmgr.c:153:12: note: previous declaration of 'dataLog' was here
     153 | static int dataLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~~~
>> fs/jfs/jfs_txnmgr.c:151:12: warning: 'diLog' used but never defined
     151 | static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~
>> fs/jfs/jfs_txnmgr.c:153:12: warning: 'dataLog' used but never defined
     153 | static int dataLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
         |            ^~~~~~~
>> fs/jfs/jfs_txnmgr.c:162:12: warning: 'txLog' used but never defined
     162 | static int txLog(struct jfs_log * log, struct tblock * tblk,
         |            ^~~~~
   fs/jfs/jfs_txnmgr.c:1536:13: warning: 'dataLog' defined but not used [-Wunused-function]
    1536 | static void dataLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~~~
   fs/jfs/jfs_txnmgr.c:1424:13: warning: 'diLog' defined but not used [-Wunused-function]
    1424 | static void diLog(struct jfs_log *log, struct tblock *tblk, struct lrd *lrd,
         |             ^~~~~
   fs/jfs/jfs_txnmgr.c:1368:13: warning: 'txLog' defined but not used [-Wunused-function]
    1368 | static void txLog(struct jfs_log *log, struct tblock *tblk, struct commit *cd)
         |             ^~~~~


vim +/diLog +151 fs/jfs/jfs_txnmgr.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  147  
^1da177e4c3f41 Linus Torvalds 2005-04-16  148  /*
^1da177e4c3f41 Linus Torvalds 2005-04-16  149   * forward references
^1da177e4c3f41 Linus Torvalds 2005-04-16  150   */
^1da177e4c3f41 Linus Torvalds 2005-04-16 @151  static int diLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  152  		struct tlock * tlck, struct commit * cd);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @153  static int dataLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  154  		struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  155  static void dtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  156  		struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  157  static void mapLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  158  		struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  159  static void txAllocPMap(struct inode *ip, struct maplock * maplock,
^1da177e4c3f41 Linus Torvalds 2005-04-16  160  		struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16  161  static void txForce(struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16 @162  static int txLog(struct jfs_log * log, struct tblock * tblk,
^1da177e4c3f41 Linus Torvalds 2005-04-16  163  		struct commit * cd);
^1da177e4c3f41 Linus Torvalds 2005-04-16  164  static void txUpdateMap(struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16  165  static void txRelease(struct tblock * tblk);
^1da177e4c3f41 Linus Torvalds 2005-04-16  166  static void xtLog(struct jfs_log * log, struct tblock * tblk, struct lrd * lrd,
^1da177e4c3f41 Linus Torvalds 2005-04-16  167  	   struct tlock * tlck);
^1da177e4c3f41 Linus Torvalds 2005-04-16  168  static void LogSyncRelease(struct metapage * mp);
^1da177e4c3f41 Linus Torvalds 2005-04-16  169  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38339 bytes --]

  reply	other threads:[~2021-02-07  7:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-07  6:37 [PATCH] jfs: turn diLog(), dataLog() and txLog() into void functions Yang Li
2021-02-07  7:44 ` kernel test robot [this message]
2021-02-07  7:44   ` kernel test robot
2021-02-07  8:20 ` kernel test robot
2021-02-07  8:20   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202102071518.tkDgzNeX-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.