From: Jens Freimann <jfreimann@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com,
Laurent Vivier <laurent@vivier.eu>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH 1/2] pci: cleanup failover sanity check
Date: Mon, 8 Feb 2021 09:42:56 +0100 [thread overview]
Message-ID: <20210208084256.GD4035@linux.fritz.box> (raw)
In-Reply-To: <20210206123955.2196514-2-lvivier@redhat.com>
On Sat, Feb 06, 2021 at 01:39:54PM +0100, Laurent Vivier wrote:
>Commit a1190ab628 has added a "allow_unplug_during_migration = true" at
>the end of the main "if" block, so it is not needed to set it anymore
>in the previous checking.
>
>Remove it, to have only sub-ifs that check for needed conditions and exit
>if one fails.
>
>Fixes: 4f5b6a05a4e7 ("pci: add option for net failover")
>Fixes: a1190ab628c0 ("migration: allow unplug during migration for failover devices")
>Cc: jfreimann@redhat.com
>Signed-off-by: Laurent Vivier <lvivier@virtlab415.virt.lab.eng.bos.redhat.com>
>---
> hw/pci/pci.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
Thank you Laurent!
regards,
Jens
WARNING: multiple messages have this Message-ID (diff)
From: Jens Freimann <jfreimann@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-trivial@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [PATCH 1/2] pci: cleanup failover sanity check
Date: Mon, 8 Feb 2021 09:42:56 +0100 [thread overview]
Message-ID: <20210208084256.GD4035@linux.fritz.box> (raw)
In-Reply-To: <20210206123955.2196514-2-lvivier@redhat.com>
On Sat, Feb 06, 2021 at 01:39:54PM +0100, Laurent Vivier wrote:
>Commit a1190ab628 has added a "allow_unplug_during_migration = true" at
>the end of the main "if" block, so it is not needed to set it anymore
>in the previous checking.
>
>Remove it, to have only sub-ifs that check for needed conditions and exit
>if one fails.
>
>Fixes: 4f5b6a05a4e7 ("pci: add option for net failover")
>Fixes: a1190ab628c0 ("migration: allow unplug during migration for failover devices")
>Cc: jfreimann@redhat.com
>Signed-off-by: Laurent Vivier <lvivier@virtlab415.virt.lab.eng.bos.redhat.com>
>---
> hw/pci/pci.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
Thank you Laurent!
regards,
Jens
next prev parent reply other threads:[~2021-02-08 14:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 12:39 [PATCH 0/2] failover: trivial cleanup and fix Laurent Vivier
2021-02-06 12:39 ` Laurent Vivier
2021-02-06 12:39 ` [PATCH 1/2] pci: cleanup failover sanity check Laurent Vivier
2021-02-06 12:39 ` Laurent Vivier
2021-02-06 14:32 ` Laurent Vivier
2021-02-08 8:42 ` Jens Freimann [this message]
2021-02-08 8:42 ` Jens Freimann
2021-02-09 16:49 ` Laurent Vivier
2021-02-09 16:49 ` Laurent Vivier
2021-02-06 12:39 ` [PATCH 2/2] virtio-net: add missing object_unref() Laurent Vivier
2021-02-06 12:39 ` Laurent Vivier
2021-02-08 8:45 ` Jens Freimann
2021-02-08 8:45 ` Jens Freimann
2021-02-09 16:50 ` Laurent Vivier
2021-02-09 16:50 ` Laurent Vivier
2021-02-10 13:40 ` [PATCH 0/2] failover: trivial cleanup and fix Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208084256.GD4035@linux.fritz.box \
--to=jfreimann@redhat.com \
--cc=laurent@vivier.eu \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.