* [PATCH] unit: test-sae: zero out frame buffers
@ 2021-02-08 22:23 James Prestwood
2021-02-08 22:25 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: James Prestwood @ 2021-02-08 22:23 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
Not all the authenticate frame elements are set and were assumed
to be zero. Since alloca does not memset data it needs to be
done explicitly.
---
unit/test-sae.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/unit/test-sae.c b/unit/test-sae.c
index 2d984160..10367cf9 100644
--- a/unit/test-sae.c
+++ b/unit/test-sae.c
@@ -202,6 +202,7 @@ static size_t setup_auth_frame(struct authenticate_frame *frame,
uint16_t trans, uint16_t status,
const uint8_t *data, size_t len)
{
+ memset(frame, 0, sizeof(struct authenticate_frame));
memcpy(frame->hdr.address_2, addr, 6);
frame->hdr.fc.type = MPDU_TYPE_MANAGEMENT;
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] unit: test-sae: zero out frame buffers
2021-02-08 22:23 [PATCH] unit: test-sae: zero out frame buffers James Prestwood
@ 2021-02-08 22:25 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2021-02-08 22:25 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
Hi James,
On 2/8/21 4:23 PM, James Prestwood wrote:
> Not all the authenticate frame elements are set and were assumed
> to be zero. Since alloca does not memset data it needs to be
> done explicitly.
> ---
> unit/test-sae.c | 1 +
> 1 file changed, 1 insertion(+)
>
Applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-08 22:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-08 22:23 [PATCH] unit: test-sae: zero out frame buffers James Prestwood
2021-02-08 22:25 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.