From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: shahafs@mellanox.com, lulu@redhat.com, rdunlap@infradead.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH V3 16/19] virtio-pci: introduce modern device module
Date: Tue, 9 Feb 2021 04:23:21 -0500 [thread overview]
Message-ID: <20210209042000-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <fe639f0f-d639-3c3c-e297-042127788aca@redhat.com>
On Tue, Feb 09, 2021 at 11:29:46AM +0800, Jason Wang wrote:
>
> On 2021/2/8 下午8:04, Michael S. Tsirkin wrote:
> > On Mon, Feb 08, 2021 at 01:42:27PM +0800, Jason Wang wrote:
> > > On 2021/2/5 下午11:34, Michael S. Tsirkin wrote:
> > > > On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote:
> > > > > Signed-off-by: Jason Wang<jasowang@redhat.com>
> > > > I don't exactly get why we need to split the modern driver out,
> > > > and it can confuse people who are used to be seeing virtio-pci.
> > >
> > > The virtio-pci module still there. No user visible changes. Just some codes
> > > that could be shared with other driver were split out.
> > >
> > What I am saying is this: we can have virtio-vdpa depend on
> > virtio-pci without splitting the common code out to an
> > extra module.
>
>
> Ok.
>
>
> >
> > > > The vdpa thing so far looks like a development tool, why do
> > > > we care that it depends on a bit of extra code?
> > >
> > > If I'm not misunderstanding, trying to share codes is proposed by you here:
> > >
> > > https://lkml.org/lkml/2020/6/10/232
> > >
> > > We also had the plan to convert IFCVF to use this library.
> > >
> > > Thanks
> > If that happens then an extra module might become useful.
>
>
> So does it make sense that I post a new version and let's merge it first.
> Then Intel or I can convert IFCVF to use the library?
>
> Thanks
Generally it's best if we actually have a couple of users before we bother
with refactoring - it's hard to predict the future,
so we don't really know what kind of refactoring will work for IFCVF ...
>
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, shahafs@mellanox.com,
lulu@redhat.com, sgarzare@redhat.com, rdunlap@infradead.org
Subject: Re: [PATCH V3 16/19] virtio-pci: introduce modern device module
Date: Tue, 9 Feb 2021 04:23:21 -0500 [thread overview]
Message-ID: <20210209042000-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <fe639f0f-d639-3c3c-e297-042127788aca@redhat.com>
On Tue, Feb 09, 2021 at 11:29:46AM +0800, Jason Wang wrote:
>
> On 2021/2/8 下午8:04, Michael S. Tsirkin wrote:
> > On Mon, Feb 08, 2021 at 01:42:27PM +0800, Jason Wang wrote:
> > > On 2021/2/5 下午11:34, Michael S. Tsirkin wrote:
> > > > On Mon, Jan 04, 2021 at 02:55:00PM +0800, Jason Wang wrote:
> > > > > Signed-off-by: Jason Wang<jasowang@redhat.com>
> > > > I don't exactly get why we need to split the modern driver out,
> > > > and it can confuse people who are used to be seeing virtio-pci.
> > >
> > > The virtio-pci module still there. No user visible changes. Just some codes
> > > that could be shared with other driver were split out.
> > >
> > What I am saying is this: we can have virtio-vdpa depend on
> > virtio-pci without splitting the common code out to an
> > extra module.
>
>
> Ok.
>
>
> >
> > > > The vdpa thing so far looks like a development tool, why do
> > > > we care that it depends on a bit of extra code?
> > >
> > > If I'm not misunderstanding, trying to share codes is proposed by you here:
> > >
> > > https://lkml.org/lkml/2020/6/10/232
> > >
> > > We also had the plan to convert IFCVF to use this library.
> > >
> > > Thanks
> > If that happens then an extra module might become useful.
>
>
> So does it make sense that I post a new version and let's merge it first.
> Then Intel or I can convert IFCVF to use the library?
>
> Thanks
Generally it's best if we actually have a couple of users before we bother
with refactoring - it's hard to predict the future,
so we don't really know what kind of refactoring will work for IFCVF ...
>
> >
next prev parent reply other threads:[~2021-02-09 9:28 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 6:54 [PATCH V3 00/19] vDPA driver for virtio-pci device Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 01/19] virtio-pci: do not access iomem via struct virtio_pci_device directly Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 02/19] virtio-pci: split out modern device Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 03/19] virtio-pci-modern: factor out modern device initialization logic Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 04/19] virtio-pci-modern: introduce vp_modern_remove() Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 05/19] virtio-pci-modern: introduce helper to set config vector Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 06/19] virtio-pci-modern: introduce helpers for setting and getting status Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 07/19] virtio-pci-modern: introduce helpers for setting and getting features Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 08/19] virtio-pci-modern: introduce vp_modern_generation() Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 09/19] virtio-pci-modern: introduce vp_modern_set_queue_vector() Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 10/19] virtio-pci-modern: introduce vp_modern_queue_address() Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 11/19] virtio-pci-modern: introduce helper to set/get queue_enable Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 12/19] virtio-pci-modern: introduce helper for setting/geting queue size Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 13/19] virtio-pci-modern: introduce helper for getting queue nums Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 14/19] virtio-pci-modern: introduce helper to get notification offset Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:54 ` [PATCH V3 15/19] virito-pci-modern: rename map_capability() to vp_modern_map_capability() Jason Wang
2021-01-04 6:54 ` Jason Wang
2021-01-04 6:55 ` [PATCH V3 16/19] virtio-pci: introduce modern device module Jason Wang
2021-01-04 6:55 ` Jason Wang
2021-02-05 15:34 ` Michael S. Tsirkin
2021-02-05 15:34 ` Michael S. Tsirkin
2021-02-08 5:42 ` Jason Wang
2021-02-08 5:42 ` Jason Wang
2021-02-08 12:04 ` Michael S. Tsirkin
2021-02-08 12:04 ` Michael S. Tsirkin
2021-02-09 3:29 ` Jason Wang
2021-02-09 9:23 ` Michael S. Tsirkin [this message]
2021-02-09 9:23 ` Michael S. Tsirkin
2021-02-09 10:15 ` Naresh Kamboju
2021-02-09 10:15 ` Naresh Kamboju
2021-02-10 4:38 ` Jason Wang
2021-02-10 4:38 ` Jason Wang
2021-02-10 4:38 ` Jason Wang
2021-02-09 14:20 ` Michael S. Tsirkin
2021-02-10 4:44 ` Jason Wang
2021-02-10 4:44 ` Jason Wang
2021-02-10 12:35 ` Michael S. Tsirkin
2021-02-10 12:35 ` Michael S. Tsirkin
2021-02-18 5:49 ` Jason Wang
2021-02-18 5:49 ` Jason Wang
2021-02-12 20:14 ` Guenter Roeck
2021-02-12 20:14 ` Guenter Roeck
2021-02-19 8:31 ` Jason Wang
2021-02-19 8:31 ` Jason Wang
2021-01-04 6:55 ` [PATCH V3 17/19] vdpa: set the virtqueue num during register Jason Wang
2021-01-04 6:55 ` Jason Wang
2021-02-05 15:27 ` Michael S. Tsirkin
2021-02-05 15:27 ` Michael S. Tsirkin
2021-02-08 4:16 ` Jason Wang
2021-02-08 4:16 ` Jason Wang
2021-01-04 6:55 ` [PATCH V3 18/19] virtio_vdpa: don't warn when fail to disable vq Jason Wang
2021-01-04 6:55 ` Jason Wang
2021-02-05 15:24 ` Michael S. Tsirkin
2021-02-05 15:24 ` Michael S. Tsirkin
2021-02-08 4:15 ` Jason Wang
2021-02-08 4:15 ` Jason Wang
2021-01-04 6:55 ` [PATCH V3 19/19] vdpa: introduce virtio pci driver Jason Wang
2021-01-04 6:55 ` Jason Wang
2021-02-02 3:53 ` [PATCH V3 00/19] vDPA driver for virtio-pci device Jason Wang
2021-02-02 3:53 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209042000-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=rdunlap@infradead.org \
--cc=shahafs@mellanox.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.