From: Christoph Hellwig <hch@lst.de>
To: Ruan Shiyang <ruansy.fnst@cn.fujitsu.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com, dan.j.williams@intel.com,
willy@infradead.org, jack@suse.cz, viro@zeniv.linux.org.uk,
linux-btrfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
david@fromorbit.com, rgoldwyn@suse.de,
Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 5/7] fsdax: Dedup file range to use a compare function
Date: Tue, 9 Feb 2021 10:34:38 +0100 [thread overview]
Message-ID: <20210209093438.GA630@lst.de> (raw)
In-Reply-To: <9193e305-22a1-3928-0675-af1cecd28942@cn.fujitsu.com>
On Tue, Feb 09, 2021 at 05:15:13PM +0800, Ruan Shiyang wrote:
> The dax dedupe comparison need the iomap_ops pointer as argument, so my
> understanding is that we don't modify the argument list of
> generic_remap_file_range_prep(), but move its code into
> __generic_remap_file_range_prep() whose argument list can be modified to
> accepts the iomap_ops pointer. Then it looks like this:
I'd say just add the iomap_ops pointer to
generic_remap_file_range_prep and do away with the extra wrappers. We
only have three callers anyway.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ruan Shiyang <ruansy.fnst@cn.fujitsu.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
darrick.wong@oracle.com, willy@infradead.org, jack@suse.cz,
viro@zeniv.linux.org.uk, linux-btrfs@vger.kernel.org,
ocfs2-devel@oss.oracle.com, david@fromorbit.com,
rgoldwyn@suse.de, Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 5/7] fsdax: Dedup file range to use a compare function
Date: Tue, 9 Feb 2021 10:34:38 +0100 [thread overview]
Message-ID: <20210209093438.GA630@lst.de> (raw)
In-Reply-To: <9193e305-22a1-3928-0675-af1cecd28942@cn.fujitsu.com>
On Tue, Feb 09, 2021 at 05:15:13PM +0800, Ruan Shiyang wrote:
> The dax dedupe comparison need the iomap_ops pointer as argument, so my
> understanding is that we don't modify the argument list of
> generic_remap_file_range_prep(), but move its code into
> __generic_remap_file_range_prep() whose argument list can be modified to
> accepts the iomap_ops pointer. Then it looks like this:
I'd say just add the iomap_ops pointer to
generic_remap_file_range_prep and do away with the extra wrappers. We
only have three callers anyway.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ruan Shiyang <ruansy.fnst@cn.fujitsu.com>
Cc: jack@suse.cz, linux-nvdimm@lists.01.org, darrick.wong@oracle.com,
david@fromorbit.com, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
viro@zeniv.linux.org.uk, Goldwyn Rodrigues <rgoldwyn@suse.com>,
linux-fsdevel@vger.kernel.org, dan.j.williams@intel.com,
linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 5/7] fsdax: Dedup file range to use a compare function
Date: Tue, 9 Feb 2021 10:34:38 +0100 [thread overview]
Message-ID: <20210209093438.GA630@lst.de> (raw)
In-Reply-To: <9193e305-22a1-3928-0675-af1cecd28942@cn.fujitsu.com>
On Tue, Feb 09, 2021 at 05:15:13PM +0800, Ruan Shiyang wrote:
> The dax dedupe comparison need the iomap_ops pointer as argument, so my
> understanding is that we don't modify the argument list of
> generic_remap_file_range_prep(), but move its code into
> __generic_remap_file_range_prep() whose argument list can be modified to
> accepts the iomap_ops pointer. Then it looks like this:
I'd say just add the iomap_ops pointer to
generic_remap_file_range_prep and do away with the extra wrappers. We
only have three callers anyway.
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2021-02-09 9:38 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 17:09 [PATCH 0/7] fsdax,xfs: Add reflink&dedupe support for fsdax Shiyang Ruan
2021-02-07 17:09 ` [Ocfs2-devel] [PATCH 0/7] fsdax, xfs: " Shiyang Ruan
2021-02-07 17:09 ` [PATCH 0/7] fsdax,xfs: " Shiyang Ruan
2021-02-07 17:09 ` [PATCH 1/7] fsdax: Output address in dax_iomap_pfn() and rename it Shiyang Ruan
2021-02-07 17:09 ` [Ocfs2-devel] " Shiyang Ruan
2021-02-07 17:09 ` Shiyang Ruan
2021-02-08 15:11 ` Christoph Hellwig
2021-02-08 15:11 ` [Ocfs2-devel] " Christoph Hellwig
2021-02-08 15:11 ` Christoph Hellwig
2021-02-22 7:44 ` Xiaoguang Wang
2021-02-22 7:44 ` [Ocfs2-devel] " Xiaoguang Wang
2021-02-22 7:44 ` Xiaoguang Wang
2021-02-23 1:32 ` 回复: " ruansy.fnst
2021-02-23 1:32 ` [Ocfs2-devel] " ruansy.fnst
2021-02-23 1:32 ` ruansy.fnst
2021-02-07 17:09 ` [PATCH 2/7] fsdax: Introduce dax_copy_edges() for CoW Shiyang Ruan
2021-02-07 17:09 ` [Ocfs2-devel] " Shiyang Ruan
2021-02-07 17:09 ` Shiyang Ruan
2021-02-08 15:11 ` Christoph Hellwig
2021-02-08 15:11 ` [Ocfs2-devel] " Christoph Hellwig
2021-02-08 15:11 ` Christoph Hellwig
2021-02-07 17:09 ` [PATCH 3/7] fsdax: Copy data before write Shiyang Ruan
2021-02-07 17:09 ` [Ocfs2-devel] " Shiyang Ruan
2021-02-07 17:09 ` Shiyang Ruan
2021-02-08 15:14 ` Christoph Hellwig
2021-02-08 15:14 ` [Ocfs2-devel] " Christoph Hellwig
2021-02-08 15:14 ` Christoph Hellwig
2021-02-09 1:53 ` Ruan Shiyang
2021-02-09 1:53 ` [Ocfs2-devel] " Ruan Shiyang
2021-02-09 1:53 ` Ruan Shiyang
2021-02-07 17:09 ` [PATCH 4/7] fsdax: Replace mmap entry in case of CoW Shiyang Ruan
2021-02-07 17:09 ` [Ocfs2-devel] " Shiyang Ruan
2021-02-07 17:09 ` Shiyang Ruan
2021-02-08 15:16 ` Christoph Hellwig
2021-02-08 15:16 ` [Ocfs2-devel] " Christoph Hellwig
2021-02-08 15:16 ` Christoph Hellwig
2021-02-16 13:11 ` David Sterba
2021-02-16 13:11 ` [Ocfs2-devel] " David Sterba
2021-02-16 13:11 ` David Sterba
2021-02-17 3:06 ` Ruan Shiyang
2021-02-17 3:06 ` [Ocfs2-devel] " Ruan Shiyang
2021-02-17 3:06 ` Ruan Shiyang
2021-02-07 17:09 ` [PATCH 5/7] fsdax: Dedup file range to use a compare function Shiyang Ruan
2021-02-07 17:09 ` [Ocfs2-devel] " Shiyang Ruan
2021-02-07 17:09 ` Shiyang Ruan
2021-02-08 15:19 ` Christoph Hellwig
2021-02-08 15:19 ` [Ocfs2-devel] " Christoph Hellwig
2021-02-08 15:19 ` Christoph Hellwig
2021-02-09 9:15 ` Ruan Shiyang
2021-02-09 9:15 ` [Ocfs2-devel] " Ruan Shiyang
2021-02-09 9:15 ` Ruan Shiyang
2021-02-09 9:34 ` Christoph Hellwig [this message]
2021-02-09 9:34 ` [Ocfs2-devel] " Christoph Hellwig
2021-02-09 9:34 ` Christoph Hellwig
2021-02-09 9:46 ` Ruan Shiyang
2021-02-09 9:46 ` [Ocfs2-devel] " Ruan Shiyang
2021-02-09 9:46 ` Ruan Shiyang
2021-02-10 13:19 ` Christoph Hellwig
2021-02-10 13:19 ` [Ocfs2-devel] " Christoph Hellwig
2021-02-10 13:19 ` Christoph Hellwig
2021-02-17 3:24 ` Ruan Shiyang
2021-02-17 3:24 ` [Ocfs2-devel] " Ruan Shiyang
2021-02-17 3:24 ` Ruan Shiyang
2021-02-18 16:20 ` Darrick J. Wong
2021-02-18 16:20 ` [Ocfs2-devel] " Darrick J. Wong
2021-02-18 16:20 ` Darrick J. Wong
2021-02-25 7:35 ` Christoph Hellwig
2021-02-25 7:35 ` [Ocfs2-devel] " Christoph Hellwig
2021-02-25 7:35 ` Christoph Hellwig
2021-02-07 17:09 ` [PATCH 6/7] fs/xfs: Handle CoW for fsdax write() path Shiyang Ruan
2021-02-07 17:09 ` [Ocfs2-devel] " Shiyang Ruan
2021-02-07 17:09 ` Shiyang Ruan
2021-02-08 15:24 ` Christoph Hellwig
2021-02-08 15:24 ` [Ocfs2-devel] " Christoph Hellwig
2021-02-08 15:24 ` Christoph Hellwig
2021-02-07 17:09 ` [PATCH 7/7] fs/xfs: Add dedupe support for fsdax Shiyang Ruan
2021-02-07 17:09 ` [Ocfs2-devel] " Shiyang Ruan
2021-02-07 17:09 ` Shiyang Ruan
2021-02-08 15:39 ` [PATCH 0/7] fsdax,xfs: Add reflink&dedupe " Jan Kara
2021-02-08 15:39 ` [Ocfs2-devel] [PATCH 0/7] fsdax, xfs: " Jan Kara
2021-02-08 15:39 ` [PATCH 0/7] fsdax,xfs: " Jan Kara
2021-02-09 1:50 ` Ruan Shiyang
2021-02-09 1:50 ` [Ocfs2-devel] [PATCH 0/7] fsdax, xfs: " Ruan Shiyang
2021-02-09 1:50 ` [PATCH 0/7] fsdax,xfs: " Ruan Shiyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209093438.GA630@lst.de \
--to=hch@lst.de \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ocfs2-devel@oss.oracle.com \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
--cc=ruansy.fnst@cn.fujitsu.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.