From: Wolfram Sang <wsa@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] i2c: mv64xxx: Fix check for missing clock
Date: Tue, 9 Feb 2021 11:42:45 +0100 [thread overview]
Message-ID: <20210209104245.GC9698@ninjato> (raw)
In-Reply-To: <20210208061922.10073-1-samuel@sholland.org>
[-- Attachment #1: Type: text/plain, Size: 671 bytes --]
On Mon, Feb 08, 2021 at 12:19:22AM -0600, Samuel Holland wrote:
> In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
> pointers to optional clocks were replaced by NULL to simplify the resume
> callback implementation. However, that commit missed that the IS_ERR
> check in mv64xxx_of_config should be replaced with a NULL check. As a
> result, the check always passes, even for an invalid device tree.
>
> Fixes: e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Added "RPM" to $subject and applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-02-09 10:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 6:19 [PATCH] i2c: mv64xxx: Fix check for missing clock Samuel Holland
2021-02-09 10:42 ` Wolfram Sang [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-08 6:28 [PATCH net-next RESEND 0/5] dwmac-sun8i cleanup and shutdown hook Samuel Holland
2021-02-08 6:28 ` [PATCH] i2c: mv64xxx: Fix check for missing clock Samuel Holland
2021-02-08 6:28 ` Samuel Holland
2021-02-08 6:31 ` Samuel Holland
2021-02-08 6:31 ` Samuel Holland
2021-02-08 13:20 ` Andrew Lunn
2021-02-08 13:20 ` Andrew Lunn
2021-02-09 3:05 ` Samuel Holland
2021-02-09 3:05 ` Samuel Holland
2021-02-08 21:11 ` Jakub Kicinski
2021-02-08 21:11 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209104245.GC9698@ninjato \
--to=wsa@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=gregory.clement@bootlin.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sholland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.