From: Andrew Lunn <andrew@lunn.ch>
To: Samuel Holland <samuel@sholland.org>
Cc: Ondrej Jirman <megous@megous.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Alexandre Torgue <alexandre.torgue@st.com>,
netdev@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Jose Abreu <joabreu@synopsys.com>,
Corentin Labbe <clabbe@baylibre.com>,
Jakub Kicinski <kuba@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: mv64xxx: Fix check for missing clock
Date: Mon, 8 Feb 2021 14:20:43 +0100 [thread overview]
Message-ID: <YCE6qwwJngcZMjmn@lunn.ch> (raw)
In-Reply-To: <4f696b13-2475-49f2-5d75-f2120e159142@sholland.org>
On Mon, Feb 08, 2021 at 12:31:34AM -0600, Samuel Holland wrote:
> On 2/8/21 12:28 AM, Samuel Holland wrote:
> > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
> > pointers to optional clocks were replaced by NULL to simplify the resume
> > callback implementation. However, that commit missed that the IS_ERR
> > check in mv64xxx_of_config should be replaced with a NULL check. As a
> > result, the check always passes, even for an invalid device tree.
>
> Sorry, please ignore this unrelated patch. I accidentally copied it to
> the wrong directory before sending this series.
Hi Samuel
This patch looks correct. But i don't see it in i2c/for-next, where as
e5c02cf54154 is. I just want to make sure it does not get lost...
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Samuel Holland <samuel@sholland.org>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Corentin Labbe <clabbe@baylibre.com>,
Ondrej Jirman <megous@megous.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] i2c: mv64xxx: Fix check for missing clock
Date: Mon, 8 Feb 2021 14:20:43 +0100 [thread overview]
Message-ID: <YCE6qwwJngcZMjmn@lunn.ch> (raw)
In-Reply-To: <4f696b13-2475-49f2-5d75-f2120e159142@sholland.org>
On Mon, Feb 08, 2021 at 12:31:34AM -0600, Samuel Holland wrote:
> On 2/8/21 12:28 AM, Samuel Holland wrote:
> > In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
> > pointers to optional clocks were replaced by NULL to simplify the resume
> > callback implementation. However, that commit missed that the IS_ERR
> > check in mv64xxx_of_config should be replaced with a NULL check. As a
> > result, the check always passes, even for an invalid device tree.
>
> Sorry, please ignore this unrelated patch. I accidentally copied it to
> the wrong directory before sending this series.
Hi Samuel
This patch looks correct. But i don't see it in i2c/for-next, where as
e5c02cf54154 is. I just want to make sure it does not get lost...
Andrew
next prev parent reply other threads:[~2021-02-08 13:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 6:28 [PATCH net-next RESEND 0/5] dwmac-sun8i cleanup and shutdown hook Samuel Holland
2021-02-08 6:28 ` Samuel Holland
2021-02-08 6:28 ` [PATCH] i2c: mv64xxx: Fix check for missing clock Samuel Holland
2021-02-08 6:28 ` Samuel Holland
2021-02-08 6:31 ` Samuel Holland
2021-02-08 6:31 ` Samuel Holland
2021-02-08 13:20 ` Andrew Lunn [this message]
2021-02-08 13:20 ` Andrew Lunn
2021-02-09 3:05 ` Samuel Holland
2021-02-09 3:05 ` Samuel Holland
2021-02-08 21:11 ` Jakub Kicinski
2021-02-08 21:11 ` Jakub Kicinski
2021-02-08 6:28 ` [PATCH net-next RESEND 1/5] net: stmmac: dwmac-sun8i: Return void from PHY unpower Samuel Holland
2021-02-08 6:28 ` Samuel Holland
2021-02-08 6:28 ` [PATCH net-next RESEND 2/5] net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check Samuel Holland
2021-02-08 6:28 ` Samuel Holland
2021-02-08 6:28 ` [PATCH net-next RESEND 3/5] net: stmmac: dwmac-sun8i: Use reset_control_reset Samuel Holland
2021-02-08 6:28 ` Samuel Holland
2021-02-08 16:29 ` Alexander Duyck
2021-02-08 16:29 ` Alexander Duyck
2021-02-09 3:24 ` Samuel Holland
2021-02-09 3:24 ` Samuel Holland
2021-02-08 6:28 ` [PATCH net-next RESEND 4/5] net: stmmac: dwmac-sun8i: Minor probe function cleanup Samuel Holland
2021-02-08 6:28 ` Samuel Holland
2021-02-08 6:28 ` [PATCH net-next RESEND 5/5] net: stmmac: dwmac-sun8i: Add a shutdown callback Samuel Holland
2021-02-08 6:28 ` Samuel Holland
-- strict thread matches above, loose matches on Subject: below --
2021-02-08 6:19 [PATCH] i2c: mv64xxx: Fix check for missing clock Samuel Holland
2021-02-09 10:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCE6qwwJngcZMjmn@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=clabbe@baylibre.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=jernej.skrabec@siol.net \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.