Re: [PATCH 23/49] perf/x86/msr: Add Alder Lake CPU support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4336 bytes --]

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/perf/core]
[cannot apply to tip/master linus/master tip/x86/core v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/kan-liang-linux-intel-com/Add-Alder-Lake-support-for-perf/20210209-070642
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 32451614da2a9cf4296f90d3606ac77814fb519d
config: x86_64-randconfig-s021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://github.com/0day-ci/linux/commit/ef3d3e5028f5f70a78fa37d642e8e7e65c60dee7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review kan-liang-linux-intel-com/Add-Alder-Lake-support-for-perf/20210209-070642
        git checkout ef3d3e5028f5f70a78fa37d642e8e7e65c60dee7
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/x86/events/msr.c: In function 'test_intel':
>> arch/x86/events/msr.c:104:7: error: 'INTEL_FAM6_ALDERLAKE_L' undeclared (first use in this function); did you mean 'INTEL_FAM6_ALDERLAKE'?
     104 |  case INTEL_FAM6_ALDERLAKE_L:
         |       ^~~~~~~~~~~~~~~~~~~~~~
         |       INTEL_FAM6_ALDERLAKE
   arch/x86/events/msr.c:104:7: note: each undeclared identifier is reported only once for each function it appears in


vim +104 arch/x86/events/msr.c

    39	
    40	static bool test_intel(int idx, void *data)
    41	{
    42		if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL ||
    43		    boot_cpu_data.x86 != 6)
    44			return false;
    45	
    46		switch (boot_cpu_data.x86_model) {
    47		case INTEL_FAM6_NEHALEM:
    48		case INTEL_FAM6_NEHALEM_G:
    49		case INTEL_FAM6_NEHALEM_EP:
    50		case INTEL_FAM6_NEHALEM_EX:
    51	
    52		case INTEL_FAM6_WESTMERE:
    53		case INTEL_FAM6_WESTMERE_EP:
    54		case INTEL_FAM6_WESTMERE_EX:
    55	
    56		case INTEL_FAM6_SANDYBRIDGE:
    57		case INTEL_FAM6_SANDYBRIDGE_X:
    58	
    59		case INTEL_FAM6_IVYBRIDGE:
    60		case INTEL_FAM6_IVYBRIDGE_X:
    61	
    62		case INTEL_FAM6_HASWELL:
    63		case INTEL_FAM6_HASWELL_X:
    64		case INTEL_FAM6_HASWELL_L:
    65		case INTEL_FAM6_HASWELL_G:
    66	
    67		case INTEL_FAM6_BROADWELL:
    68		case INTEL_FAM6_BROADWELL_D:
    69		case INTEL_FAM6_BROADWELL_G:
    70		case INTEL_FAM6_BROADWELL_X:
    71	
    72		case INTEL_FAM6_ATOM_SILVERMONT:
    73		case INTEL_FAM6_ATOM_SILVERMONT_D:
    74		case INTEL_FAM6_ATOM_AIRMONT:
    75	
    76		case INTEL_FAM6_ATOM_GOLDMONT:
    77		case INTEL_FAM6_ATOM_GOLDMONT_D:
    78		case INTEL_FAM6_ATOM_GOLDMONT_PLUS:
    79		case INTEL_FAM6_ATOM_TREMONT_D:
    80		case INTEL_FAM6_ATOM_TREMONT:
    81		case INTEL_FAM6_ATOM_TREMONT_L:
    82	
    83		case INTEL_FAM6_XEON_PHI_KNL:
    84		case INTEL_FAM6_XEON_PHI_KNM:
    85			if (idx == PERF_MSR_SMI)
    86				return true;
    87			break;
    88	
    89		case INTEL_FAM6_SKYLAKE_L:
    90		case INTEL_FAM6_SKYLAKE:
    91		case INTEL_FAM6_SKYLAKE_X:
    92		case INTEL_FAM6_KABYLAKE_L:
    93		case INTEL_FAM6_KABYLAKE:
    94		case INTEL_FAM6_COMETLAKE_L:
    95		case INTEL_FAM6_COMETLAKE:
    96		case INTEL_FAM6_ICELAKE_L:
    97		case INTEL_FAM6_ICELAKE:
    98		case INTEL_FAM6_ICELAKE_X:
    99		case INTEL_FAM6_ICELAKE_D:
   100		case INTEL_FAM6_TIGERLAKE_L:
   101		case INTEL_FAM6_TIGERLAKE:
   102		case INTEL_FAM6_ROCKETLAKE:
   103		case INTEL_FAM6_ALDERLAKE:
 > 104		case INTEL_FAM6_ALDERLAKE_L:
   105			if (idx == PERF_MSR_SMI || idx == PERF_MSR_PPERF)
   106				return true;
   107			break;
   108		}
   109	
   110		return false;
   111	}
   112	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38945 bytes --]