[meta-virtualization][PATCH 1/2] Revert "libvirt: fix host gcc can't recognized option -fmacro-prefix-map"

[meta-virtualization][PATCH 1/2] Revert "libvirt: fix host gcc can't recognized option -fmacro-prefix-map"

[Martin Jansa]

This reverts commit 08b5de42f9216a10bb2f83263b7e6789686b4c3d.

libvirt shouldn't be using host's gcc to build python module, this issue
is caused by missing inherit of python3targetconfig instead added in:
https://git.openembedded.org/openembedded-core/commit/?id=5a118d4e7985fa88f04c3611f8db813f0dafce75

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-extended/libvirt/libvirt-python.inc | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/recipes-extended/libvirt/libvirt-python.inc b/recipes-extended/libvirt/libvirt-python.inc
index 819eceb..7b87d5e 100644
--- a/recipes-extended/libvirt/libvirt-python.inc
+++ b/recipes-extended/libvirt/libvirt-python.inc
@@ -24,11 +24,6 @@ export LIBVIRT_API_PATH = "${S}/docs/libvirt-api.xml"
 export LIBVIRT_CFLAGS = "-I${S}/include"
 export LIBVIRT_LIBS = "-L${B}/src/.libs -lvirt -ldl"
 export LDFLAGS="-L${B}/src/.libs"
-export LDSHARED  = "${CCLD} -shared"
-export LDCXXSHARED  = "${CXX} -shared"
-export CCSHARED  = "-fPIC -DPIC"
-export LINKFORSHARED = "${SECURITY_CFLAGS} -Xlinker -export-dynamic"
-
 
 LIBVIRT_INSTALL_ARGS = "--root=${D} \
     --prefix=${prefix} \
-- 
2.27.0

[meta-virtualization][PATCH 2/2] libvirt-python: inherit python3targetconfig

[Martin Jansa]

* otherwise libvirt build will incorrectly use host's gcc and fail with:
  gcc: error: unrecognized command line option "-fmacro-prefix-map=/OE/libvirt/6.1.0-r0=/usr/src/debug/libvirt/6.1.0-r0"

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 recipes-extended/libvirt/libvirt-python.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-extended/libvirt/libvirt-python.inc b/recipes-extended/libvirt/libvirt-python.inc
index 7b87d5e..bcd7657 100644
--- a/recipes-extended/libvirt/libvirt-python.inc
+++ b/recipes-extended/libvirt/libvirt-python.inc
@@ -1,4 +1,4 @@
-inherit python3native python3-dir
+inherit python3native python3-dir python3targetconfig
 
 export STAGING_INCDIR
 export STAGING_LIBDIR
-- 
2.27.0

Re: [meta-virtualization][PATCH 2/2] libvirt-python: inherit python3targetconfig

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

This 2nd one should be merged to dunfell and gatesgarth branches as well
when the PYTHON_SYSCONFIGDATA_NAME changes are backported there as
discussed in:
https://lists.openembedded.org/g/openembedded-core/message/146715
https://lists.openembedded.org/g/openembedded-core/message/147844

Unfortunately it cannot be applied in advance,
because python3targetconfig.bbclass doesn't exist in oe-core/dunfell nor
gatesgarth yet, so oe-core and meta-virtualization stable branches should
be updated at the same time.

Regards,

On Tue, Feb 9, 2021 at 9:09 AM Martin Jansa via lists.yoctoproject.org
<Martin.Jansa=gmail.com@lists.yoctoproject.org> wrote:

> * otherwise libvirt build will incorrectly use host's gcc and fail with:
>   gcc: error: unrecognized command line option
> "-fmacro-prefix-map=/OE/libvirt/6.1.0-r0=/usr/src/debug/libvirt/6.1.0-r0"
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  recipes-extended/libvirt/libvirt-python.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-extended/libvirt/libvirt-python.inc
> b/recipes-extended/libvirt/libvirt-python.inc
> index 7b87d5e..bcd7657 100644
> --- a/recipes-extended/libvirt/libvirt-python.inc
> +++ b/recipes-extended/libvirt/libvirt-python.inc
> @@ -1,4 +1,4 @@
> -inherit python3native python3-dir
> +inherit python3native python3-dir python3targetconfig
>
>  export STAGING_INCDIR
>  export STAGING_LIBDIR
> --
> 2.27.0
>
>
> 
>
>

[-- Attachment #2: Type: text/html, Size: 2184 bytes --]

Re: [meta-virtualization][PATCH 2/2] libvirt-python: inherit python3targetconfig

[Bruce Ashfield]

In message: Re: [meta-virtualization][PATCH 2/2] libvirt-python: inherit python3targetconfig
on 09/02/2021 Martin Jansa wrote:

> This 2nd one should be merged to dunfell and gatesgarth branches as well when
> the PYTHON_SYSCONFIGDATA_NAME changes are backported there as discussed in:
> https://lists.openembedded.org/g/openembedded-core/message/146715
> https://lists.openembedded.org/g/openembedded-core/message/147844

I've merged both to master.

> 
> Unfortunately it cannot be applied in advance,
> because python3targetconfig.bbclass doesn't exist in oe-core/dunfell nor
> gatesgarth yet, so oe-core and meta-virtualization stable branches should be
> updated at the same time.

I'll keep this around as a reminder that there's a pending backport
and will watch for Steve's dunfell pull requests to do the merge
here.

Bruce

> 
> Regards,
> 
> On Tue, Feb 9, 2021 at 9:09 AM Martin Jansa via lists.yoctoproject.org
> <Martin.Jansa=gmail.com@lists.yoctoproject.org> wrote:
> 
>     * otherwise libvirt build will incorrectly use host's gcc and fail with:
>       gcc: error: unrecognized command line option "-fmacro-prefix-map=/OE/
>     libvirt/6.1.0-r0=/usr/src/debug/libvirt/6.1.0-r0"
> 
>     Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>     ---
>      recipes-extended/libvirt/libvirt-python.inc | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/recipes-extended/libvirt/libvirt-python.inc b/recipes-extended
>     /libvirt/libvirt-python.inc
>     index 7b87d5e..bcd7657 100644
>     --- a/recipes-extended/libvirt/libvirt-python.inc
>     +++ b/recipes-extended/libvirt/libvirt-python.inc
>     @@ -1,4 +1,4 @@
>     -inherit python3native python3-dir
>     +inherit python3native python3-dir python3targetconfig
> 
>      export STAGING_INCDIR
>      export STAGING_LIBDIR
>     --
>     2.27.0
> 
> 
> 
> 
> 

> 
> 
>