From: Christoph Hellwig <hch@lst.de>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
iommu@lists.linux-foundation.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org
Subject: Re: [PATCH 4/6] MIPS: refactor the maybe coherent DMA indicators
Date: Wed, 10 Feb 2021 09:57:24 +0100 [thread overview]
Message-ID: <20210210085724.GA24610@lst.de> (raw)
In-Reply-To: <20210209131237.GB11915@alpha.franken.de>
On Tue, Feb 09, 2021 at 02:12:37PM +0100, Thomas Bogendoerfer wrote:
> > +#ifdef CONFIG_DMA_MAYBE_COHERENT
> > +extern bool dma_default_coherent;
> > static inline bool dev_is_dma_coherent(struct device *dev)
> > {
> > - return coherentio == IO_COHERENCE_ENABLED ||
> > - (coherentio == IO_COHERENCE_DEFAULT && hw_coherentio);
> > + return dma_default_coherent;
>
> this breaks overriding of coherentio via command line. plat_mem_setup/
> plat_setup_iocoherency is called before earlyparams are handled. So
> changing coherentio after that doesn't have any effect.
Hmm. In that case a manual override does actually work for alchemy,
as that initializes coherentio from plat_mem_setup(). But the
elaborate sanity checking that malta performs in plat_setup_iocoherency
is rather pointless then, as coherentio will always be set to
IO_COHERENCE_DISABLED at this point.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Christoph Hellwig <hch@lst.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH 4/6] MIPS: refactor the maybe coherent DMA indicators
Date: Wed, 10 Feb 2021 09:57:24 +0100 [thread overview]
Message-ID: <20210210085724.GA24610@lst.de> (raw)
In-Reply-To: <20210209131237.GB11915@alpha.franken.de>
On Tue, Feb 09, 2021 at 02:12:37PM +0100, Thomas Bogendoerfer wrote:
> > +#ifdef CONFIG_DMA_MAYBE_COHERENT
> > +extern bool dma_default_coherent;
> > static inline bool dev_is_dma_coherent(struct device *dev)
> > {
> > - return coherentio == IO_COHERENCE_ENABLED ||
> > - (coherentio == IO_COHERENCE_DEFAULT && hw_coherentio);
> > + return dma_default_coherent;
>
> this breaks overriding of coherentio via command line. plat_mem_setup/
> plat_setup_iocoherency is called before earlyparams are handled. So
> changing coherentio after that doesn't have any effect.
Hmm. In that case a manual override does actually work for alchemy,
as that initializes coherentio from plat_mem_setup(). But the
elaborate sanity checking that malta performs in plat_setup_iocoherency
is rather pointless then, as coherentio will always be set to
IO_COHERENCE_DISABLED at this point.
next prev parent reply other threads:[~2021-02-10 8:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 14:50 MIPS noncoherent DMA cleanups Christoph Hellwig
2021-02-08 14:50 ` Christoph Hellwig
2021-02-08 14:50 ` [PATCH 1/6] MIPS/malta: simplify plat_setup_iocoherency Christoph Hellwig
2021-02-08 14:50 ` Christoph Hellwig
2021-02-08 14:50 ` [PATCH 2/6] MIPS/alchemy: factor out the DMA coherent setup Christoph Hellwig
2021-02-08 14:50 ` Christoph Hellwig
2021-02-08 14:50 ` [PATCH 3/6] MIPS: move the {no, }nocoherentio options to the malta setup code Christoph Hellwig
2021-02-08 14:50 ` [PATCH 3/6] MIPS: move the {no,}nocoherentio " Christoph Hellwig
2021-02-08 14:50 ` [PATCH 4/6] MIPS: refactor the maybe coherent DMA indicators Christoph Hellwig
2021-02-08 14:50 ` Christoph Hellwig
2021-02-09 13:12 ` Thomas Bogendoerfer
2021-02-10 8:57 ` Christoph Hellwig [this message]
2021-02-10 8:57 ` Christoph Hellwig
2021-02-08 14:50 ` [PATCH 5/6] driver core: lift dma_default_coherent into common code Christoph Hellwig
2021-02-08 14:50 ` Christoph Hellwig
2021-02-08 15:00 ` Greg Kroah-Hartman
2021-02-08 15:00 ` Greg Kroah-Hartman
2021-02-08 15:57 ` Maciej W. Rozycki
2021-02-08 15:57 ` Maciej W. Rozycki
2021-02-08 16:10 ` Christoph Hellwig
2021-02-08 16:10 ` Christoph Hellwig
2021-02-09 11:23 ` Maciej W. Rozycki
2021-02-09 11:23 ` Maciej W. Rozycki
2021-02-15 13:13 ` Maciej W. Rozycki
2021-02-15 13:13 ` Maciej W. Rozycki
2021-02-21 3:32 ` Maciej W. Rozycki
2021-02-21 3:32 ` Maciej W. Rozycki
2021-02-22 7:59 ` Christoph Hellwig
2021-02-22 7:59 ` Christoph Hellwig
2021-02-22 10:42 ` Maciej W. Rozycki
2021-02-22 10:42 ` Maciej W. Rozycki
2021-02-27 18:33 ` Maciej W. Rozycki
2021-02-27 18:33 ` Maciej W. Rozycki
2021-02-09 13:06 ` Thomas Bogendoerfer
2021-02-09 13:06 ` Thomas Bogendoerfer
2021-02-08 14:50 ` [PATCH 6/6] MIPS: remove CONFIG_DMA_PERDEV_COHERENT Christoph Hellwig
2021-02-08 14:50 ` Christoph Hellwig
2021-02-09 1:36 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210085724.GA24610@lst.de \
--to=hch@lst.de \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.