From: Christoph Hellwig <hch@lst.de>
To: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
Cc: y-goto@fujitsu.com, qi.fuli@fujitsu.com, snitzer@redhat.com,
linux-nvdimm@lists.01.org, rgoldwyn@suse.de,
darrick.wong@oracle.com, david@fromorbit.com,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org, dan.j.williams@intel.com,
hch@lst.de, agk@redhat.com
Subject: Re: [dm-devel] [PATCH v3 10/11] xfs: Implement ->corrupted_range() for XFS
Date: Wed, 10 Feb 2021 14:44:09 +0100 [thread overview]
Message-ID: <20210210134409.GF30109@lst.de> (raw)
In-Reply-To: <20210208105530.3072869-11-ruansy.fnst@cn.fujitsu.com>
> + if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner) ||
> + (rec->rm_flags & (XFS_RMAP_ATTR_FORK | XFS_RMAP_BMBT_BLOCK))) {
> + // TODO check and try to fix metadata
> + rc = -EFSCORRUPTED;
> + xfs_force_shutdown(cur->bc_mp, SHUTDOWN_CORRUPT_META);
Just return early here so that we can avoid the else later.
> + /*
> + * Get files that incore, filter out others that are not in use.
> + */
> + rc = xfs_iget(cur->bc_mp, cur->bc_tp, rec->rm_owner,
> + XFS_IGET_INCORE, 0, &ip);
Can we rename rc to error?
> + if (rc || !ip)
> + return rc;
No need to check for ip here.
> + if (!VFS_I(ip)->i_mapping)
> + goto out;
This can't happen either.
> +
> + mapping = VFS_I(ip)->i_mapping;
> + if (IS_DAX(VFS_I(ip)))
> + rc = mf_dax_mapping_kill_procs(mapping, rec->rm_offset,
> + *flags);
> + else {
> + rc = -EIO;
> + mapping_set_error(mapping, rc);
> + }
By passing the method directly to the DAX device we should never get
this called for the non-DAX case.
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, dm-devel@redhat.com,
darrick.wong@oracle.com, david@fromorbit.com, hch@lst.de,
agk@redhat.com, snitzer@redhat.com, rgoldwyn@suse.de,
qi.fuli@fujitsu.com, y-goto@fujitsu.com
Subject: Re: [PATCH v3 10/11] xfs: Implement ->corrupted_range() for XFS
Date: Wed, 10 Feb 2021 14:44:09 +0100 [thread overview]
Message-ID: <20210210134409.GF30109@lst.de> (raw)
In-Reply-To: <20210208105530.3072869-11-ruansy.fnst@cn.fujitsu.com>
> + if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner) ||
> + (rec->rm_flags & (XFS_RMAP_ATTR_FORK | XFS_RMAP_BMBT_BLOCK))) {
> + // TODO check and try to fix metadata
> + rc = -EFSCORRUPTED;
> + xfs_force_shutdown(cur->bc_mp, SHUTDOWN_CORRUPT_META);
Just return early here so that we can avoid the else later.
> + /*
> + * Get files that incore, filter out others that are not in use.
> + */
> + rc = xfs_iget(cur->bc_mp, cur->bc_tp, rec->rm_owner,
> + XFS_IGET_INCORE, 0, &ip);
Can we rename rc to error?
> + if (rc || !ip)
> + return rc;
No need to check for ip here.
> + if (!VFS_I(ip)->i_mapping)
> + goto out;
This can't happen either.
> +
> + mapping = VFS_I(ip)->i_mapping;
> + if (IS_DAX(VFS_I(ip)))
> + rc = mf_dax_mapping_kill_procs(mapping, rec->rm_offset,
> + *flags);
> + else {
> + rc = -EIO;
> + mapping_set_error(mapping, rc);
> + }
By passing the method directly to the DAX device we should never get
this called for the non-DAX case.
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org, dm-devel@redhat.com,
darrick.wong@oracle.com, dan.j.williams@intel.com,
david@fromorbit.com, hch@lst.de, agk@redhat.com,
snitzer@redhat.com, rgoldwyn@suse.de, qi.fuli@fujitsu.com,
y-goto@fujitsu.com
Subject: Re: [PATCH v3 10/11] xfs: Implement ->corrupted_range() for XFS
Date: Wed, 10 Feb 2021 14:44:09 +0100 [thread overview]
Message-ID: <20210210134409.GF30109@lst.de> (raw)
In-Reply-To: <20210208105530.3072869-11-ruansy.fnst@cn.fujitsu.com>
> + if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner) ||
> + (rec->rm_flags & (XFS_RMAP_ATTR_FORK | XFS_RMAP_BMBT_BLOCK))) {
> + // TODO check and try to fix metadata
> + rc = -EFSCORRUPTED;
> + xfs_force_shutdown(cur->bc_mp, SHUTDOWN_CORRUPT_META);
Just return early here so that we can avoid the else later.
> + /*
> + * Get files that incore, filter out others that are not in use.
> + */
> + rc = xfs_iget(cur->bc_mp, cur->bc_tp, rec->rm_owner,
> + XFS_IGET_INCORE, 0, &ip);
Can we rename rc to error?
> + if (rc || !ip)
> + return rc;
No need to check for ip here.
> + if (!VFS_I(ip)->i_mapping)
> + goto out;
This can't happen either.
> +
> + mapping = VFS_I(ip)->i_mapping;
> + if (IS_DAX(VFS_I(ip)))
> + rc = mf_dax_mapping_kill_procs(mapping, rec->rm_offset,
> + *flags);
> + else {
> + rc = -EIO;
> + mapping_set_error(mapping, rc);
> + }
By passing the method directly to the DAX device we should never get
this called for the non-DAX case.
next prev parent reply other threads:[~2021-02-10 13:44 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 10:55 [dm-devel] [PATCH v3 00/11] fsdax: introduce fs query to support reflink Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` [dm-devel] [PATCH v3 01/11] pagemap: Introduce ->memory_failure() Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-10 13:20 ` [dm-devel] " Christoph Hellwig
2021-02-10 13:20 ` Christoph Hellwig
2021-02-10 13:20 ` Christoph Hellwig
2021-03-06 20:36 ` [dm-devel] " Dan Williams
2021-03-06 20:36 ` Dan Williams
2021-03-06 20:36 ` Dan Williams
2021-03-08 3:38 ` [dm-devel] " ruansy.fnst
2021-03-08 3:38 ` ruansy.fnst
2021-03-08 3:38 ` ruansy.fnst
2021-03-08 5:23 ` [dm-devel] " Dan Williams
2021-03-08 5:23 ` Dan Williams
2021-03-08 5:23 ` Dan Williams
2021-03-08 11:34 ` [dm-devel] " ruansy.fnst
2021-03-08 11:34 ` ruansy.fnst
2021-03-08 11:34 ` ruansy.fnst
2021-03-08 18:01 ` [dm-devel] " Dan Williams
2021-03-08 18:01 ` Dan Williams
2021-03-08 18:01 ` Dan Williams
2021-03-12 10:18 ` [dm-devel] " ruansy.fnst
2021-03-12 10:18 ` ruansy.fnst
2021-03-12 10:18 ` ruansy.fnst
2021-03-19 2:17 ` [dm-devel] " ruansy.fnst
2021-03-19 2:17 ` ruansy.fnst
2021-03-19 2:17 ` ruansy.fnst
2021-03-24 2:19 ` [dm-devel] " Dan Williams
2021-03-24 2:19 ` Dan Williams
2021-03-24 2:19 ` Dan Williams
2021-03-24 7:47 ` [dm-devel] " Christoph Hellwig
2021-03-24 7:47 ` Christoph Hellwig
2021-03-24 7:47 ` Christoph Hellwig
2021-03-24 16:37 ` [dm-devel] " Dan Williams
2021-03-24 16:37 ` Dan Williams
2021-03-24 16:37 ` Dan Williams
2021-03-24 17:39 ` [dm-devel] " Christoph Hellwig
2021-03-24 17:39 ` Christoph Hellwig
2021-03-24 17:39 ` Christoph Hellwig
2021-03-24 18:00 ` [dm-devel] " Dan Williams
2021-03-24 18:00 ` Dan Williams
2021-03-24 18:00 ` Dan Williams
2021-02-08 10:55 ` [dm-devel] [PATCH v3 02/11] blk: Introduce ->corrupted_range() for block device Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-10 13:21 ` [dm-devel] " Christoph Hellwig
2021-02-10 13:21 ` Christoph Hellwig
2021-02-10 13:21 ` Christoph Hellwig
2021-03-04 22:42 ` [dm-devel] " Darrick J. Wong
2021-03-04 22:42 ` Darrick J. Wong
2021-03-04 22:42 ` Darrick J. Wong
2021-03-05 6:10 ` [dm-devel] " Christoph Hellwig
2021-03-05 6:10 ` Christoph Hellwig
2021-03-05 6:10 ` Christoph Hellwig
2021-02-08 10:55 ` [dm-devel] [PATCH v3 03/11] fs: Introduce ->corrupted_range() for superblock Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` [dm-devel] [PATCH v3 04/11] block_dev: Introduce bd_corrupted_range() for block device Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` [dm-devel] [PATCH v3 05/11] mm, fsdax: Refactor memory-failure handler for dax mapping Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-10 13:33 ` [dm-devel] " Christoph Hellwig
2021-02-10 13:33 ` Christoph Hellwig
2021-02-10 13:33 ` Christoph Hellwig
2021-02-17 2:56 ` [dm-devel] " Ruan Shiyang
2021-02-17 2:56 ` Ruan Shiyang
2021-02-17 2:56 ` Ruan Shiyang
2021-02-18 8:32 ` [dm-devel] " Christoph Hellwig
2021-02-18 8:32 ` Christoph Hellwig
2021-02-18 8:32 ` Christoph Hellwig
2021-02-18 8:59 ` [dm-devel] " Ruan Shiyang
2021-02-18 8:59 ` Ruan Shiyang
2021-02-18 8:59 ` Ruan Shiyang
2021-03-16 3:21 ` [dm-devel] " zhong jiang
2021-03-16 3:21 ` zhong jiang
2021-03-16 3:21 ` zhong jiang
2021-03-17 3:46 ` [dm-devel] " ruansy.fnst
2021-03-17 3:46 ` ruansy.fnst
2021-03-17 3:46 ` ruansy.fnst
2021-02-08 10:55 ` [dm-devel] [PATCH v3 06/11] mm, pmem: Implement ->memory_failure() in pmem driver Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-10 13:41 ` [dm-devel] " Christoph Hellwig
2021-02-10 13:41 ` Christoph Hellwig
2021-02-10 13:41 ` Christoph Hellwig
2021-02-08 10:55 ` [dm-devel] [PATCH v3 07/11] pmem: Implement ->corrupted_range() for " Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` [dm-devel] [PATCH v3 08/11] dm: Introduce ->rmap() to find bdev offset Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` [dm-devel] [PATCH v3 09/11] md: Implement ->corrupted_range() Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` [dm-devel] [PATCH v3 10/11] xfs: Implement ->corrupted_range() for XFS Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-10 13:44 ` Christoph Hellwig [this message]
2021-02-10 13:44 ` Christoph Hellwig
2021-02-10 13:44 ` Christoph Hellwig
2021-02-08 10:55 ` [dm-devel] [PATCH v3 11/11] fs/dax: Remove useless functions Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-08 10:55 ` Shiyang Ruan
2021-02-10 13:09 ` [dm-devel] " Christoph Hellwig
2021-02-10 13:09 ` Christoph Hellwig
2021-02-10 13:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210134409.GF30109@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=qi.fuli@fujitsu.com \
--cc=rgoldwyn@suse.de \
--cc=ruansy.fnst@cn.fujitsu.com \
--cc=snitzer@redhat.com \
--cc=y-goto@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.