From: Vladimir Oltean <olteanv@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: Ivan Vecera <ivecera@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Vadym Kochan <vkochan@marvell.com>,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
bridge@lists.linux-foundation.org,
Ioana Ciornei <ioana.ciornei@nxp.com>,
linux-kernel@vger.kernel.org,
Vivien Didelot <vivien.didelot@gmail.com>,
Taras Chornyi <tchornyi@marvell.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Roopa Prabhu <roopa@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
UNGLinuxDriver@microchip.com,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH v2 net-next 04/11] net: bridge: offload initial and final port flags through switchdev
Date: Thu, 11 Feb 2021 01:23:52 +0200 [thread overview]
Message-ID: <20210210232352.m7nqzvs2g4i74rx4@skbuf> (raw)
In-Reply-To: <20210210105949.GB287766@shredder.lan>
On Wed, Feb 10, 2021 at 12:59:49PM +0200, Ido Schimmel wrote:
> > > The reverse, during unlinking, would be to refuse unlinking if the upper
> > > has uppers of its own. netdev_upper_dev_unlink() needs to learn to
> > > return an error and callers such as team/bond need to learn to handle
> > > it, but it seems patchable.
> >
> > Again, this was treated prior to my deletion in this series and not by
> > erroring out, I just really didn't think it through.
> >
> > So you're saying that if we impose that all switchdev drivers restrict
> > the house of cards to be constructed from the bottom up, and destructed
> > from the top down, then the notification of bridge port flags can stay
> > in the bridge layer?
>
> I actually don't think it's a good idea to have this in the bridge in
> any case. I understand that it makes sense for some devices where
> learning, flooding, etc are port attributes, but in other devices these
> can be {port,vlan} attributes and then you need to take care of them
> when a vlan is added / deleted and not only when a port is removed from
> the bridge. So for such devices this really won't save anything. I would
> thus leave it to the lower levels to decide.
Just for my understanding, how are per-{port,vlan} attributes such as
learning and flooding managed by the Linux bridge? How can I disable
flooding only in a certain VLAN?
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Oltean <olteanv@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bridge@lists.linux-foundation.org,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Jiri Pirko <jiri@resnulli.us>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com, Vadym Kochan <vkochan@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Ivan Vecera <ivecera@redhat.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 net-next 04/11] net: bridge: offload initial and final port flags through switchdev
Date: Thu, 11 Feb 2021 01:23:52 +0200 [thread overview]
Message-ID: <20210210232352.m7nqzvs2g4i74rx4@skbuf> (raw)
In-Reply-To: <20210210105949.GB287766@shredder.lan>
On Wed, Feb 10, 2021 at 12:59:49PM +0200, Ido Schimmel wrote:
> > > The reverse, during unlinking, would be to refuse unlinking if the upper
> > > has uppers of its own. netdev_upper_dev_unlink() needs to learn to
> > > return an error and callers such as team/bond need to learn to handle
> > > it, but it seems patchable.
> >
> > Again, this was treated prior to my deletion in this series and not by
> > erroring out, I just really didn't think it through.
> >
> > So you're saying that if we impose that all switchdev drivers restrict
> > the house of cards to be constructed from the bottom up, and destructed
> > from the top down, then the notification of bridge port flags can stay
> > in the bridge layer?
>
> I actually don't think it's a good idea to have this in the bridge in
> any case. I understand that it makes sense for some devices where
> learning, flooding, etc are port attributes, but in other devices these
> can be {port,vlan} attributes and then you need to take care of them
> when a vlan is added / deleted and not only when a port is removed from
> the bridge. So for such devices this really won't save anything. I would
> thus leave it to the lower levels to decide.
Just for my understanding, how are per-{port,vlan} attributes such as
learning and flooding managed by the Linux bridge? How can I disable
flooding only in a certain VLAN?
next prev parent reply other threads:[~2021-02-10 23:23 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 15:19 [PATCH v2 net-next 00/11] Cleanup in brport flags switchdev offload for DSA Vladimir Oltean
2021-02-09 15:19 ` [PATCH v2 net-next 01/11] net: switchdev: propagate extack to port attributes Vladimir Oltean
2021-02-09 18:00 ` [Bridge] " Ido Schimmel
2021-02-09 18:00 ` Ido Schimmel
2021-02-09 15:19 ` [Bridge] [PATCH v2 net-next 02/11] net: bridge: offload all port flags at once in br_setport Vladimir Oltean
2021-02-09 15:19 ` Vladimir Oltean
2021-02-09 18:27 ` [Bridge] " Vladimir Oltean
2021-02-09 18:27 ` Vladimir Oltean
2021-02-09 18:36 ` [Bridge] " Vladimir Oltean
2021-02-09 18:36 ` Vladimir Oltean
2021-02-09 15:19 ` [PATCH v2 net-next 03/11] net: bridge: don't print in br_switchdev_set_port_flag Vladimir Oltean
2021-02-09 17:36 ` [Bridge] " Vladimir Oltean
2021-02-09 17:36 ` Vladimir Oltean
2021-02-09 18:26 ` [Bridge] " Ido Schimmel
2021-02-09 18:26 ` Ido Schimmel
2021-02-09 15:19 ` [Bridge] [PATCH v2 net-next 04/11] net: bridge: offload initial and final port flags through switchdev Vladimir Oltean
2021-02-09 15:19 ` Vladimir Oltean
2021-02-09 18:51 ` [Bridge] " Ido Schimmel
2021-02-09 18:51 ` Ido Schimmel
2021-02-09 20:20 ` [Bridge] " Vladimir Oltean
2021-02-09 20:20 ` Vladimir Oltean
2021-02-09 22:01 ` [Bridge] " Ido Schimmel
2021-02-09 22:01 ` Ido Schimmel
2021-02-09 22:51 ` [Bridge] " Vladimir Oltean
2021-02-09 22:51 ` Vladimir Oltean
2021-02-10 10:59 ` [Bridge] " Ido Schimmel
2021-02-10 10:59 ` Ido Schimmel
2021-02-10 23:23 ` Vladimir Oltean [this message]
2021-02-10 23:23 ` Vladimir Oltean
2021-02-11 7:44 ` [Bridge] " Ido Schimmel
2021-02-11 7:44 ` Ido Schimmel
2021-02-11 9:35 ` [Bridge] " Vladimir Oltean
2021-02-11 9:35 ` Vladimir Oltean
2021-02-11 22:20 ` [Bridge] " Ido Schimmel
2021-02-11 22:20 ` Ido Schimmel
2021-02-09 15:19 ` [Bridge] [PATCH v2 net-next 05/11] net: dsa: stop setting initial and final brport flags Vladimir Oltean
2021-02-09 15:19 ` Vladimir Oltean
2021-02-09 15:19 ` [Bridge] [PATCH v2 net-next 06/11] net: squash switchdev attributes PRE_BRIDGE_FLAGS and BRIDGE_FLAGS Vladimir Oltean
2021-02-09 15:19 ` Vladimir Oltean
2021-02-09 15:19 ` [Bridge] [PATCH v2 net-next 07/11] net: dsa: kill .port_egress_floods overengineering Vladimir Oltean
2021-02-09 15:19 ` Vladimir Oltean
2021-02-09 20:37 ` [Bridge] " Vladimir Oltean
2021-02-09 20:37 ` Vladimir Oltean
2021-02-09 21:29 ` [Bridge] " Florian Fainelli
2021-02-09 21:29 ` Florian Fainelli
2021-02-09 15:19 ` [Bridge] [PATCH v2 net-next 08/11] net: bridge: put SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS on the blocking call chain Vladimir Oltean
2021-02-09 15:19 ` Vladimir Oltean
2021-02-09 15:19 ` [PATCH v2 net-next 09/11] net: mscc: ocelot: use separate flooding PGID for broadcast Vladimir Oltean
2021-02-09 15:19 ` [PATCH v2 net-next 10/11] net: mscc: ocelot: offload bridge port flags to device Vladimir Oltean
2021-02-09 15:19 ` [PATCH v2 net-next 11/11] net: dsa: sja1105: " Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210232352.m7nqzvs2g4i74rx4@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=idosch@idosch.org \
--cc=ioana.ciornei@nxp.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=tchornyi@marvell.com \
--cc=vivien.didelot@gmail.com \
--cc=vkochan@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.