All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 6/7] package/supertux: remove explicit setting of CMAKE_BUILD_TYPE
Date: Fri, 12 Feb 2021 14:54:49 +0100	[thread overview]
Message-ID: <20210212135451.22786-7-patrickdepinguin@gmail.com> (raw)
In-Reply-To: <20210212135451.22786-1-patrickdepinguin@gmail.com>

From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

supertux explicitly set CMAKE_BUILD_TYPE=Release, ignoring any possible
value of BR2_ENABLE_DEBUG (previously) or BR2_ENABLE_RUNTIME_DEBUG (now).

With the introduction of BR2_ENABLE_RUNTIME_DEBUG, this change should no
longer be necessary. Users that do not wish to have profiling information,
just keep BR2_ENABLE_RUNTIME_DEBUG disabled (default value), and those that
enable BR2_ENABLE_RUNTIME_DEBUG will get profiling.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
 package/supertux/supertux.mk | 2 --
 1 file changed, 2 deletions(-)

diff --git a/package/supertux/supertux.mk b/package/supertux/supertux.mk
index e4a4630918..a339c42e42 100644
--- a/package/supertux/supertux.mk
+++ b/package/supertux/supertux.mk
@@ -18,7 +18,6 @@ SUPERTUX_LICENSE_FILES = LICENSE.txt data/AUTHORS
 SUPERTUX_DEPENDENCIES = host-pkgconf boost freetype libcurl libgl libglew \
 	libogg libpng libvorbis openal physfs sdl2 sdl2_image
 
-# CMAKE_BUILD_TYPE=Release: disable profiling code (-pg)
 # ENABLE_BOOST_STATIC_LIBS=OFF: use boost shared libraries since supertux
 # depends on !BR2_STATIC_LIBS and boost provide only shared libraries with
 # BR2_SHARED_LIBS.
@@ -29,7 +28,6 @@ SUPERTUX_DEPENDENCIES = host-pkgconf boost freetype libcurl libgl libglew \
 # in physfs.h (CHECK_SYMBOL_EXISTS) doesn't work.
 # ENABLE_OPENGLES2=OFF: Disable opengles2 for now.
 SUPERTUX_CONF_OPTS += \
-	-DCMAKE_BUILD_TYPE=Release \
 	-DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -DGLEW_NO_GLU" \
 	-DENABLE_BOOST_STATIC_LIBS=OFF \
 	-DBUILD_DOCUMENTATION=OFF \
-- 
2.26.2

  parent reply	other threads:[~2021-02-12 13:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 13:54 [Buildroot] [PATCHv2 0/7] Introduce BR2_ENABLE_RUNTIME_DEBUG Thomas De Schampheleire
2021-02-12 13:54 ` [Buildroot] [PATCHv2 1/7] core: introduce BR2_ENABLE_RUNTIME_DEBUG Thomas De Schampheleire
2021-02-12 13:54 ` [Buildroot] [PATCHv2 2/7] core: enable 'NDEBUG' unless BR2_ENABLE_RUNTIME_DEBUG is set Thomas De Schampheleire
2021-02-13 21:56   ` Thomas Petazzoni
2021-02-15  9:11     ` Thomas De Schampheleire
2021-05-18 12:56       ` Thomas De Schampheleire
2021-02-12 13:54 ` [Buildroot] [PATCHv2 3/7] package/pkg-cmake.mk: determine CMAKE_BUILD_TYPE depending on BR2_ENABLE_RUNTIME_DEBUG Thomas De Schampheleire
2021-02-13 15:56   ` Alexander Dahl
2021-02-15  9:18     ` Thomas De Schampheleire
2021-02-16 21:38   ` Arnout Vandecappelle
2021-02-12 13:54 ` [Buildroot] [PATCHv2 4/7] package/libjson: drop explicit '-DNDEBUG' Thomas De Schampheleire
2021-02-12 13:54 ` [Buildroot] [PATCHv2 5/7] package/flare-engine: remove explicit setting of CMAKE_BUILD_TYPE Thomas De Schampheleire
2021-02-16 21:21   ` Arnout Vandecappelle
2021-02-12 13:54 ` Thomas De Schampheleire [this message]
2021-02-16 21:22   ` [Buildroot] [PATCHv2 6/7] package/supertux: " Arnout Vandecappelle
2021-02-12 13:54 ` [Buildroot] [PATCHv2 7/7] package/sysrepo: " Thomas De Schampheleire
2021-02-12 15:20   ` Jan Kundrát
2021-02-16 21:53   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210212135451.22786-7-patrickdepinguin@gmail.com \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.