All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2 7/7] package/sysrepo: remove explicit setting of CMAKE_BUILD_TYPE
Date: Fri, 12 Feb 2021 14:54:50 +0100	[thread overview]
Message-ID: <20210212135451.22786-8-patrickdepinguin@gmail.com> (raw)
In-Reply-To: <20210212135451.22786-1-patrickdepinguin@gmail.com>

From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

sysrepo explicitly set CMAKE_BUILD_TYPE=Release, ignoring any possible
value of BR2_ENABLE_DEBUG (previously) or BR2_ENABLE_RUNTIME_DEBUG (now).

With the introduction of BR2_ENABLE_RUNTIME_DEBUG, this change should no
longer be necessary. Users that do not wish to have additional runtime
debugging just keep BR2_ENABLE_RUNTIME_DEBUG disabled (default value).

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
---
v2: Jan Kundr?t:
- explicitly set REPO_PATH, which is set to a host path in case of
  CMAKE_BUILD_TYPE=Debug (see e.g.
  https://github.com/sysrepo/sysrepo/blob/v1.4.104/CMakeLists.txt#L138-L144)

 package/sysrepo/sysrepo.mk | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/package/sysrepo/sysrepo.mk b/package/sysrepo/sysrepo.mk
index e4d553cdbd..768cde8d35 100644
--- a/package/sysrepo/sysrepo.mk
+++ b/package/sysrepo/sysrepo.mk
@@ -13,8 +13,8 @@ SYSREPO_DEPENDENCIES = libyang pcre host-sysrepo
 HOST_SYSREPO_DEPENDENCIES = host-libyang host-pcre
 
 SYSREPO_CONF_OPTS = \
-	-DCMAKE_BUILD_TYPE=Release \
-	-DBUILD_EXAMPLES=$(if $(BR2_PACKAGE_SYSREPO_EXAMPLES),ON,OFF)
+	-DBUILD_EXAMPLES=$(if $(BR2_PACKAGE_SYSREPO_EXAMPLES),ON,OFF) \
+	-DREPO_PATH=/etc/sysrepo
 
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 SYSREPO_CONF_OPTS += -DCMAKE_EXE_LINKER_FLAGS=-latomic
@@ -26,7 +26,6 @@ define SYSREPO_INSTALL_INIT_SYSV
 endef
 
 HOST_SYSREPO_CONF_OPTS = \
-	-DCMAKE_BUILD_TYPE=Release \
 	-DBUILD_EXAMPLES=OFF \
 	-DREPO_PATH=$(TARGET_DIR)/etc/sysrepo
 
-- 
2.26.2

  parent reply	other threads:[~2021-02-12 13:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 13:54 [Buildroot] [PATCHv2 0/7] Introduce BR2_ENABLE_RUNTIME_DEBUG Thomas De Schampheleire
2021-02-12 13:54 ` [Buildroot] [PATCHv2 1/7] core: introduce BR2_ENABLE_RUNTIME_DEBUG Thomas De Schampheleire
2021-02-12 13:54 ` [Buildroot] [PATCHv2 2/7] core: enable 'NDEBUG' unless BR2_ENABLE_RUNTIME_DEBUG is set Thomas De Schampheleire
2021-02-13 21:56   ` Thomas Petazzoni
2021-02-15  9:11     ` Thomas De Schampheleire
2021-05-18 12:56       ` Thomas De Schampheleire
2021-02-12 13:54 ` [Buildroot] [PATCHv2 3/7] package/pkg-cmake.mk: determine CMAKE_BUILD_TYPE depending on BR2_ENABLE_RUNTIME_DEBUG Thomas De Schampheleire
2021-02-13 15:56   ` Alexander Dahl
2021-02-15  9:18     ` Thomas De Schampheleire
2021-02-16 21:38   ` Arnout Vandecappelle
2021-02-12 13:54 ` [Buildroot] [PATCHv2 4/7] package/libjson: drop explicit '-DNDEBUG' Thomas De Schampheleire
2021-02-12 13:54 ` [Buildroot] [PATCHv2 5/7] package/flare-engine: remove explicit setting of CMAKE_BUILD_TYPE Thomas De Schampheleire
2021-02-16 21:21   ` Arnout Vandecappelle
2021-02-12 13:54 ` [Buildroot] [PATCHv2 6/7] package/supertux: " Thomas De Schampheleire
2021-02-16 21:22   ` Arnout Vandecappelle
2021-02-12 13:54 ` Thomas De Schampheleire [this message]
2021-02-12 15:20   ` [Buildroot] [PATCHv2 7/7] package/sysrepo: " Jan Kundrát
2021-02-16 21:53   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210212135451.22786-8-patrickdepinguin@gmail.com \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.