From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH] perf libperf: Remove unused xyarray.c
Date: Fri, 12 Feb 2021 17:26:16 -0300 [thread overview]
Message-ID: <20210212202616.GG1398414@kernel.org> (raw)
In-Reply-To: <YCY9dtFKwTLjTq+w@krava>
Em Fri, Feb 12, 2021 at 09:33:58AM +0100, Jiri Olsa escreveu:
> On Thu, Feb 11, 2021 at 08:38:03PM -0800, Ian Rogers wrote:
> > Migrated to libperf in:
> > commit 4b247fa7314c ("libperf: Adopt xyarray class from perf")
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied.
- Arnaldo
> thanks,
> jirka
>
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/perf/util/xyarray.c | 33 ---------------------------------
> > 1 file changed, 33 deletions(-)
> > delete mode 100644 tools/perf/util/xyarray.c
> >
> > diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
> > deleted file mode 100644
> > index 86889ebc3514..000000000000
> > --- a/tools/perf/util/xyarray.c
> > +++ /dev/null
> > @@ -1,33 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > -#include "xyarray.h"
> > -#include <stdlib.h>
> > -#include <string.h>
> > -#include <linux/zalloc.h>
> > -
> > -struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
> > -{
> > - size_t row_size = ylen * entry_size;
> > - struct xyarray *xy = zalloc(sizeof(*xy) + xlen * row_size);
> > -
> > - if (xy != NULL) {
> > - xy->entry_size = entry_size;
> > - xy->row_size = row_size;
> > - xy->entries = xlen * ylen;
> > - xy->max_x = xlen;
> > - xy->max_y = ylen;
> > - }
> > -
> > - return xy;
> > -}
> > -
> > -void xyarray__reset(struct xyarray *xy)
> > -{
> > - size_t n = xy->entries * xy->entry_size;
> > -
> > - memset(xy->contents, 0, n);
> > -}
> > -
> > -void xyarray__delete(struct xyarray *xy)
> > -{
> > - free(xy);
> > -}
> > --
> > 2.30.0.478.g8a0d178c01-goog
> >
>
--
- Arnaldo
prev parent reply other threads:[~2021-02-12 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 4:38 [PATCH] perf libperf: Remove unused xyarray.c Ian Rogers
2021-02-12 8:33 ` Jiri Olsa
2021-02-12 20:26 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212202616.GG1398414@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.