* [PATCH] perf libperf: Remove unused xyarray.c
@ 2021-02-12 4:38 Ian Rogers
2021-02-12 8:33 ` Jiri Olsa
0 siblings, 1 reply; 3+ messages in thread
From: Ian Rogers @ 2021-02-12 4:38 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
linux-kernel
Cc: Stephane Eranian, Ian Rogers
Migrated to libperf in:
commit 4b247fa7314c ("libperf: Adopt xyarray class from perf")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/xyarray.c | 33 ---------------------------------
1 file changed, 33 deletions(-)
delete mode 100644 tools/perf/util/xyarray.c
diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
deleted file mode 100644
index 86889ebc3514..000000000000
--- a/tools/perf/util/xyarray.c
+++ /dev/null
@@ -1,33 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-#include "xyarray.h"
-#include <stdlib.h>
-#include <string.h>
-#include <linux/zalloc.h>
-
-struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
-{
- size_t row_size = ylen * entry_size;
- struct xyarray *xy = zalloc(sizeof(*xy) + xlen * row_size);
-
- if (xy != NULL) {
- xy->entry_size = entry_size;
- xy->row_size = row_size;
- xy->entries = xlen * ylen;
- xy->max_x = xlen;
- xy->max_y = ylen;
- }
-
- return xy;
-}
-
-void xyarray__reset(struct xyarray *xy)
-{
- size_t n = xy->entries * xy->entry_size;
-
- memset(xy->contents, 0, n);
-}
-
-void xyarray__delete(struct xyarray *xy)
-{
- free(xy);
-}
--
2.30.0.478.g8a0d178c01-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf libperf: Remove unused xyarray.c
2021-02-12 4:38 [PATCH] perf libperf: Remove unused xyarray.c Ian Rogers
@ 2021-02-12 8:33 ` Jiri Olsa
2021-02-12 20:26 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Olsa @ 2021-02-12 8:33 UTC (permalink / raw)
To: Ian Rogers
Cc: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Namhyung Kim, linux-kernel,
Stephane Eranian
On Thu, Feb 11, 2021 at 08:38:03PM -0800, Ian Rogers wrote:
> Migrated to libperf in:
> commit 4b247fa7314c ("libperf: Adopt xyarray class from perf")
Acked-by: Jiri Olsa <jolsa@redhat.com>
thanks,
jirka
>
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/util/xyarray.c | 33 ---------------------------------
> 1 file changed, 33 deletions(-)
> delete mode 100644 tools/perf/util/xyarray.c
>
> diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
> deleted file mode 100644
> index 86889ebc3514..000000000000
> --- a/tools/perf/util/xyarray.c
> +++ /dev/null
> @@ -1,33 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0
> -#include "xyarray.h"
> -#include <stdlib.h>
> -#include <string.h>
> -#include <linux/zalloc.h>
> -
> -struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
> -{
> - size_t row_size = ylen * entry_size;
> - struct xyarray *xy = zalloc(sizeof(*xy) + xlen * row_size);
> -
> - if (xy != NULL) {
> - xy->entry_size = entry_size;
> - xy->row_size = row_size;
> - xy->entries = xlen * ylen;
> - xy->max_x = xlen;
> - xy->max_y = ylen;
> - }
> -
> - return xy;
> -}
> -
> -void xyarray__reset(struct xyarray *xy)
> -{
> - size_t n = xy->entries * xy->entry_size;
> -
> - memset(xy->contents, 0, n);
> -}
> -
> -void xyarray__delete(struct xyarray *xy)
> -{
> - free(xy);
> -}
> --
> 2.30.0.478.g8a0d178c01-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] perf libperf: Remove unused xyarray.c
2021-02-12 8:33 ` Jiri Olsa
@ 2021-02-12 20:26 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2021-02-12 20:26 UTC (permalink / raw)
To: Jiri Olsa
Cc: Ian Rogers, Peter Zijlstra, Ingo Molnar, Mark Rutland,
Alexander Shishkin, Namhyung Kim, linux-kernel, Stephane Eranian
Em Fri, Feb 12, 2021 at 09:33:58AM +0100, Jiri Olsa escreveu:
> On Thu, Feb 11, 2021 at 08:38:03PM -0800, Ian Rogers wrote:
> > Migrated to libperf in:
> > commit 4b247fa7314c ("libperf: Adopt xyarray class from perf")
>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied.
- Arnaldo
> thanks,
> jirka
>
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> > tools/perf/util/xyarray.c | 33 ---------------------------------
> > 1 file changed, 33 deletions(-)
> > delete mode 100644 tools/perf/util/xyarray.c
> >
> > diff --git a/tools/perf/util/xyarray.c b/tools/perf/util/xyarray.c
> > deleted file mode 100644
> > index 86889ebc3514..000000000000
> > --- a/tools/perf/util/xyarray.c
> > +++ /dev/null
> > @@ -1,33 +0,0 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > -#include "xyarray.h"
> > -#include <stdlib.h>
> > -#include <string.h>
> > -#include <linux/zalloc.h>
> > -
> > -struct xyarray *xyarray__new(int xlen, int ylen, size_t entry_size)
> > -{
> > - size_t row_size = ylen * entry_size;
> > - struct xyarray *xy = zalloc(sizeof(*xy) + xlen * row_size);
> > -
> > - if (xy != NULL) {
> > - xy->entry_size = entry_size;
> > - xy->row_size = row_size;
> > - xy->entries = xlen * ylen;
> > - xy->max_x = xlen;
> > - xy->max_y = ylen;
> > - }
> > -
> > - return xy;
> > -}
> > -
> > -void xyarray__reset(struct xyarray *xy)
> > -{
> > - size_t n = xy->entries * xy->entry_size;
> > -
> > - memset(xy->contents, 0, n);
> > -}
> > -
> > -void xyarray__delete(struct xyarray *xy)
> > -{
> > - free(xy);
> > -}
> > --
> > 2.30.0.478.g8a0d178c01-goog
> >
>
--
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-12 20:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-12 4:38 [PATCH] perf libperf: Remove unused xyarray.c Ian Rogers
2021-02-12 8:33 ` Jiri Olsa
2021-02-12 20:26 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.