From: Florian Westphal <fw@strlen.de>
To: kbuild-all@lists.01.org
Subject: Re: [linux-next:master 5178/10581] net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here
Date: Sat, 13 Feb 2021 00:04:48 +0100 [thread overview]
Message-ID: <20210212230448.GG2766@breakpoint.cc> (raw)
In-Reply-To: <202102130043.4UIBML4o-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 898 bytes --]
kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 671176b0016c80b3943cb5387312c886aba3308d
> commit: 83ace77f51175023c3757e2d08a92565f9b1c7f3 [5178/10581] netfilter: ctnetlink: remove get_ct indirection
> >> net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here [-Wuninitialized]
> if (ct && nfnl_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
> ^~~~~~
> net/netfilter/nfnetlink_queue.c:391:2: note: variable 'ctinfo' is declared here
Looks like a false positive.
ctinfo is uninitialized only if ct == NULL.
The config even has "CONFIG_NF_CONNTRACK is no set"
so ct is always NULL.
Could be "fixed" by adding aother ifdef but it would
add even more clutter to an huge function.
WARNING: multiple messages have this Message-ID (diff)
From: Florian Westphal <fw@strlen.de>
To: kernel test robot <lkp@intel.com>
Cc: Florian Westphal <fw@strlen.de>,
kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Linux Memory Management List <linux-mm@kvack.org>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [linux-next:master 5178/10581] net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here
Date: Sat, 13 Feb 2021 00:04:48 +0100 [thread overview]
Message-ID: <20210212230448.GG2766@breakpoint.cc> (raw)
In-Reply-To: <202102130043.4UIBML4o-lkp@intel.com>
kernel test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 671176b0016c80b3943cb5387312c886aba3308d
> commit: 83ace77f51175023c3757e2d08a92565f9b1c7f3 [5178/10581] netfilter: ctnetlink: remove get_ct indirection
> >> net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here [-Wuninitialized]
> if (ct && nfnl_ct->build(skb, ct, ctinfo, NFQA_CT, NFQA_CT_INFO) < 0)
> ^~~~~~
> net/netfilter/nfnetlink_queue.c:391:2: note: variable 'ctinfo' is declared here
Looks like a false positive.
ctinfo is uninitialized only if ct == NULL.
The config even has "CONFIG_NF_CONNTRACK is no set"
so ct is always NULL.
Could be "fixed" by adding aother ifdef but it would
add even more clutter to an huge function.
next prev parent reply other threads:[~2021-02-12 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 16:39 [linux-next:master 5178/10581] net/netfilter/nfnetlink_queue.c:601:36: warning: variable 'ctinfo' is uninitialized when used here kernel test robot
2021-02-12 16:39 ` kernel test robot
2021-02-12 23:04 ` Florian Westphal [this message]
2021-02-12 23:04 ` Florian Westphal
2021-02-12 23:14 ` Nick Desaulniers
2021-02-12 23:14 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212230448.GG2766@breakpoint.cc \
--to=fw@strlen.de \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.