Re: [PATCH 1/1] v4l: async: Fix kerneldoc documentation for async functions

All of lore.kernel.org
 help / color / mirror / Atom feed

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/1] v4l: async: Fix kerneldoc documentation for async functions
Date: Mon, 15 Feb 2021 23:42:35 +0800	[thread overview]
Message-ID: <202102152320.lEmMqNqs-lkp@intel.com> (raw)
In-Reply-To: <20210215123728.16362-1-sakari.ailus@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 6501 bytes --]

Hi Sakari,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20210212]
[cannot apply to v5.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-async-Fix-kerneldoc-documentation-for-async-functions/20210215-204146
base:   git://linuxtv.org/media_tree.git master
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8e8c47cba531c1706847f07a4af5cd19aa33f351
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sakari-Ailus/v4l-async-Fix-kerneldoc-documentation-for-async-functions/20210215-204146
        git checkout 8e8c47cba531c1706847f07a4af5cd19aa33f351
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/media/platform/ti-vpe/cal.c:24:
   drivers/media/platform/ti-vpe/cal.c: In function 'cal_async_notifier_register':
   include/media/v4l2-async.h:179:4: error: '__type' undeclared (first use in this function); did you mean '_ctype'?
     179 |  ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \
         |    ^~~~~~
   drivers/media/platform/ti-vpe/cal.c:694:10: note: in expansion of macro 'v4l2_async_notifier_add_fwnode_subdev'
     694 |   casd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-async.h:179:4: note: each undeclared identifier is reported only once for each function it appears in
     179 |  ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \
         |    ^~~~~~
   drivers/media/platform/ti-vpe/cal.c:694:10: note: in expansion of macro 'v4l2_async_notifier_add_fwnode_subdev'
     694 |   casd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-async.h:179:12: error: expected expression before ')' token
     179 |  ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \
         |            ^
   drivers/media/platform/ti-vpe/cal.c:694:10: note: in expansion of macro 'v4l2_async_notifier_add_fwnode_subdev'
     694 |   casd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/ti-vpe/cal.c:688:25: warning: variable 'fwnode' set but not used [-Wunused-but-set-variable]
     688 |   struct fwnode_handle *fwnode;
         |                         ^~~~~~


vim +/fwnode +688 drivers/media/platform/ti-vpe/cal.c

b6ee3f0dcf43dc Laurent Pinchart 2017-08-30  676  
a539a0536f6e22 Laurent Pinchart 2020-07-06  677  static int cal_async_notifier_register(struct cal_dev *cal)
343e89a792a571 Benoit Parrot    2016-01-06  678  {
a539a0536f6e22 Laurent Pinchart 2020-07-06  679  	unsigned int i;
a539a0536f6e22 Laurent Pinchart 2020-07-06  680  	int ret;
a539a0536f6e22 Laurent Pinchart 2020-07-06  681  
a539a0536f6e22 Laurent Pinchart 2020-07-06  682  	v4l2_async_notifier_init(&cal->notifier);
a539a0536f6e22 Laurent Pinchart 2020-07-06  683  	cal->notifier.ops = &cal_async_notifier_ops;
a539a0536f6e22 Laurent Pinchart 2020-07-06  684  
71c1f16ddd528d Laurent Pinchart 2020-12-07  685  	for (i = 0; i < cal->data->num_csi2_phy; ++i) {
539e7c5d7c0281 Laurent Pinchart 2020-07-06  686  		struct cal_camerarx *phy = cal->phy[i];
8fcb7576ad197b Laurent Pinchart 2020-07-06  687  		struct cal_v4l2_async_subdev *casd;
f5ddf19eca3328 Laurent Pinchart 2020-07-06 @688  		struct fwnode_handle *fwnode;
343e89a792a571 Benoit Parrot    2016-01-06  689  
71c1f16ddd528d Laurent Pinchart 2020-12-07  690  		if (!phy->sensor_node)
a539a0536f6e22 Laurent Pinchart 2020-07-06  691  			continue;
d079f94c90469f Steve Longerbeam 2018-09-29  692  
539e7c5d7c0281 Laurent Pinchart 2020-07-06  693  		fwnode = of_fwnode_handle(phy->sensor_node);
b01edcbd409cf7 Laurent Pinchart 2021-01-18  694  		casd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
a539a0536f6e22 Laurent Pinchart 2020-07-06  695  							     fwnode,
b01edcbd409cf7 Laurent Pinchart 2021-01-18  696  							     struct cal_v4l2_async_subdev);
b01edcbd409cf7 Laurent Pinchart 2021-01-18  697  		if (IS_ERR(casd)) {
539e7c5d7c0281 Laurent Pinchart 2020-07-06  698  			phy_err(phy, "Failed to add subdev to notifier\n");
b01edcbd409cf7 Laurent Pinchart 2021-01-18  699  			ret = PTR_ERR(casd);
a539a0536f6e22 Laurent Pinchart 2020-07-06  700  			goto error;
d079f94c90469f Steve Longerbeam 2018-09-29  701  		}
d079f94c90469f Steve Longerbeam 2018-09-29  702  
539e7c5d7c0281 Laurent Pinchart 2020-07-06  703  		casd->phy = phy;
a539a0536f6e22 Laurent Pinchart 2020-07-06  704  	}
8fcb7576ad197b Laurent Pinchart 2020-07-06  705  
a539a0536f6e22 Laurent Pinchart 2020-07-06  706  	ret = v4l2_async_notifier_register(&cal->v4l2_dev, &cal->notifier);
343e89a792a571 Benoit Parrot    2016-01-06  707  	if (ret) {
a539a0536f6e22 Laurent Pinchart 2020-07-06  708  		cal_err(cal, "Error registering async notifier\n");
a539a0536f6e22 Laurent Pinchart 2020-07-06  709  		goto error;
343e89a792a571 Benoit Parrot    2016-01-06  710  	}
343e89a792a571 Benoit Parrot    2016-01-06  711  
f5ddf19eca3328 Laurent Pinchart 2020-07-06  712  	return 0;
a539a0536f6e22 Laurent Pinchart 2020-07-06  713  
a539a0536f6e22 Laurent Pinchart 2020-07-06  714  error:
a539a0536f6e22 Laurent Pinchart 2020-07-06  715  	v4l2_async_notifier_cleanup(&cal->notifier);
a539a0536f6e22 Laurent Pinchart 2020-07-06  716  	return ret;
a539a0536f6e22 Laurent Pinchart 2020-07-06  717  }
a539a0536f6e22 Laurent Pinchart 2020-07-06  718  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68816 bytes --]

WARNING: multiple messages have this Message-ID (diff)

From: kernel test robot <lkp@intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: kbuild-all@lists.01.org, Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 1/1] v4l: async: Fix kerneldoc documentation for async functions
Date: Mon, 15 Feb 2021 23:42:35 +0800	[thread overview]
Message-ID: <202102152320.lEmMqNqs-lkp@intel.com> (raw)
In-Reply-To: <20210215123728.16362-1-sakari.ailus@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 6395 bytes --]

Hi Sakari,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20210212]
[cannot apply to v5.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-async-Fix-kerneldoc-documentation-for-async-functions/20210215-204146
base:   git://linuxtv.org/media_tree.git master
config: sparc-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8e8c47cba531c1706847f07a4af5cd19aa33f351
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Sakari-Ailus/v4l-async-Fix-kerneldoc-documentation-for-async-functions/20210215-204146
        git checkout 8e8c47cba531c1706847f07a4af5cd19aa33f351
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/media/platform/ti-vpe/cal.c:24:
   drivers/media/platform/ti-vpe/cal.c: In function 'cal_async_notifier_register':
   include/media/v4l2-async.h:179:4: error: '__type' undeclared (first use in this function); did you mean '_ctype'?
     179 |  ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \
         |    ^~~~~~
   drivers/media/platform/ti-vpe/cal.c:694:10: note: in expansion of macro 'v4l2_async_notifier_add_fwnode_subdev'
     694 |   casd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-async.h:179:4: note: each undeclared identifier is reported only once for each function it appears in
     179 |  ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \
         |    ^~~~~~
   drivers/media/platform/ti-vpe/cal.c:694:10: note: in expansion of macro 'v4l2_async_notifier_add_fwnode_subdev'
     694 |   casd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/media/v4l2-async.h:179:12: error: expected expression before ')' token
     179 |  ((__type *)__v4l2_async_notifier_add_fwnode_subdev(notifier, fwnode, \
         |            ^
   drivers/media/platform/ti-vpe/cal.c:694:10: note: in expansion of macro 'v4l2_async_notifier_add_fwnode_subdev'
     694 |   casd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/media/platform/ti-vpe/cal.c:688:25: warning: variable 'fwnode' set but not used [-Wunused-but-set-variable]
     688 |   struct fwnode_handle *fwnode;
         |                         ^~~~~~


vim +/fwnode +688 drivers/media/platform/ti-vpe/cal.c

b6ee3f0dcf43dc Laurent Pinchart 2017-08-30  676  
a539a0536f6e22 Laurent Pinchart 2020-07-06  677  static int cal_async_notifier_register(struct cal_dev *cal)
343e89a792a571 Benoit Parrot    2016-01-06  678  {
a539a0536f6e22 Laurent Pinchart 2020-07-06  679  	unsigned int i;
a539a0536f6e22 Laurent Pinchart 2020-07-06  680  	int ret;
a539a0536f6e22 Laurent Pinchart 2020-07-06  681  
a539a0536f6e22 Laurent Pinchart 2020-07-06  682  	v4l2_async_notifier_init(&cal->notifier);
a539a0536f6e22 Laurent Pinchart 2020-07-06  683  	cal->notifier.ops = &cal_async_notifier_ops;
a539a0536f6e22 Laurent Pinchart 2020-07-06  684  
71c1f16ddd528d Laurent Pinchart 2020-12-07  685  	for (i = 0; i < cal->data->num_csi2_phy; ++i) {
539e7c5d7c0281 Laurent Pinchart 2020-07-06  686  		struct cal_camerarx *phy = cal->phy[i];
8fcb7576ad197b Laurent Pinchart 2020-07-06  687  		struct cal_v4l2_async_subdev *casd;
f5ddf19eca3328 Laurent Pinchart 2020-07-06 @688  		struct fwnode_handle *fwnode;
343e89a792a571 Benoit Parrot    2016-01-06  689  
71c1f16ddd528d Laurent Pinchart 2020-12-07  690  		if (!phy->sensor_node)
a539a0536f6e22 Laurent Pinchart 2020-07-06  691  			continue;
d079f94c90469f Steve Longerbeam 2018-09-29  692  
539e7c5d7c0281 Laurent Pinchart 2020-07-06  693  		fwnode = of_fwnode_handle(phy->sensor_node);
b01edcbd409cf7 Laurent Pinchart 2021-01-18  694  		casd = v4l2_async_notifier_add_fwnode_subdev(&cal->notifier,
a539a0536f6e22 Laurent Pinchart 2020-07-06  695  							     fwnode,
b01edcbd409cf7 Laurent Pinchart 2021-01-18  696  							     struct cal_v4l2_async_subdev);
b01edcbd409cf7 Laurent Pinchart 2021-01-18  697  		if (IS_ERR(casd)) {
539e7c5d7c0281 Laurent Pinchart 2020-07-06  698  			phy_err(phy, "Failed to add subdev to notifier\n");
b01edcbd409cf7 Laurent Pinchart 2021-01-18  699  			ret = PTR_ERR(casd);
a539a0536f6e22 Laurent Pinchart 2020-07-06  700  			goto error;
d079f94c90469f Steve Longerbeam 2018-09-29  701  		}
d079f94c90469f Steve Longerbeam 2018-09-29  702  
539e7c5d7c0281 Laurent Pinchart 2020-07-06  703  		casd->phy = phy;
a539a0536f6e22 Laurent Pinchart 2020-07-06  704  	}
8fcb7576ad197b Laurent Pinchart 2020-07-06  705  
a539a0536f6e22 Laurent Pinchart 2020-07-06  706  	ret = v4l2_async_notifier_register(&cal->v4l2_dev, &cal->notifier);
343e89a792a571 Benoit Parrot    2016-01-06  707  	if (ret) {
a539a0536f6e22 Laurent Pinchart 2020-07-06  708  		cal_err(cal, "Error registering async notifier\n");
a539a0536f6e22 Laurent Pinchart 2020-07-06  709  		goto error;
343e89a792a571 Benoit Parrot    2016-01-06  710  	}
343e89a792a571 Benoit Parrot    2016-01-06  711  
f5ddf19eca3328 Laurent Pinchart 2020-07-06  712  	return 0;
a539a0536f6e22 Laurent Pinchart 2020-07-06  713  
a539a0536f6e22 Laurent Pinchart 2020-07-06  714  error:
a539a0536f6e22 Laurent Pinchart 2020-07-06  715  	v4l2_async_notifier_cleanup(&cal->notifier);
a539a0536f6e22 Laurent Pinchart 2020-07-06  716  	return ret;
a539a0536f6e22 Laurent Pinchart 2020-07-06  717  }
a539a0536f6e22 Laurent Pinchart 2020-07-06  718  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68816 bytes --]

next prev parent reply	other threads:[~2021-02-15 15:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 12:37 [PATCH 1/1] v4l: async: Fix kerneldoc documentation for async functions Sakari Ailus
2021-02-15 15:16 ` kernel test robot
2021-02-15 15:16   ` kernel test robot
2021-02-15 15:42 ` kernel test robot [this message]
2021-02-15 15:42   ` kernel test robot
2021-02-15 16:10 ` kernel test robot
2021-02-15 16:10   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202102152320.lEmMqNqs-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.