Re: [PATCH v5 10/10] powerpc/signal64: Use __get_user() to copy sigset_t

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4980 bytes --]

Hi "Christopher,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on v5.11 next-20210215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christopher-M-Riedl/Improve-signal-performance-on-PPC64-with-KUAP/20210204-025741
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc64-randconfig-s031-20210215 (attached as .config)
compiler: powerpc64le-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://github.com/0day-ci/linux/commit/c6e40a98c1ba2f91d123ef23844732b97ea96fb3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christopher-M-Riedl/Improve-signal-performance-on-PPC64-with-KUAP/20210204-025741
        git checkout c6e40a98c1ba2f91d123ef23844732b97ea96fb3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> arch/powerpc/kernel/signal_64.c:752:36: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected struct sigset_t const [usertype] *src @@     got struct sigset_t [noderef] __user * @@
   arch/powerpc/kernel/signal_64.c:752:36: sparse:     expected struct sigset_t const [usertype] *src
   arch/powerpc/kernel/signal_64.c:752:36: sparse:     got struct sigset_t [noderef] __user *
   arch/powerpc/kernel/signal_64.c:712:36: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected struct sigset_t const [usertype] *src @@     got struct sigset_t [noderef] __user * @@
   arch/powerpc/kernel/signal_64.c:712:36: sparse:     expected struct sigset_t const [usertype] *src
   arch/powerpc/kernel/signal_64.c:712:36: sparse:     got struct sigset_t [noderef] __user *
>> arch/powerpc/kernel/signal_64.c:103:24: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_addr @@     got unsigned long const * @@
   arch/powerpc/kernel/signal_64.c:103:24: sparse:     expected unsigned long const [noderef] __user *__gu_addr
   arch/powerpc/kernel/signal_64.c:103:24: sparse:     got unsigned long const *
>> arch/powerpc/kernel/signal_64.c:105:46: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void const [noderef] __user *from @@     got struct sigset_t const [usertype] *src @@
   arch/powerpc/kernel/signal_64.c:105:46: sparse:     expected void const [noderef] __user *from
   arch/powerpc/kernel/signal_64.c:105:46: sparse:     got struct sigset_t const [usertype] *src
>> arch/powerpc/kernel/signal_64.c:103:24: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected unsigned long const [noderef] __user *__gu_addr @@     got unsigned long const * @@
   arch/powerpc/kernel/signal_64.c:103:24: sparse:     expected unsigned long const [noderef] __user *__gu_addr
   arch/powerpc/kernel/signal_64.c:103:24: sparse:     got unsigned long const *
>> arch/powerpc/kernel/signal_64.c:105:46: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void const [noderef] __user *from @@     got struct sigset_t const [usertype] *src @@
   arch/powerpc/kernel/signal_64.c:105:46: sparse:     expected void const [noderef] __user *from
   arch/powerpc/kernel/signal_64.c:105:46: sparse:     got struct sigset_t const [usertype] *src

vim +752 arch/powerpc/kernel/signal_64.c

   733	
   734	
   735	/*
   736	 * Do a signal return; undo the signal stack.
   737	 */
   738	
   739	SYSCALL_DEFINE0(rt_sigreturn)
   740	{
   741		struct pt_regs *regs = current_pt_regs();
   742		struct ucontext __user *uc = (struct ucontext __user *)regs->gpr[1];
   743		sigset_t set;
   744		unsigned long msr;
   745	
   746		/* Always make any pending restarted system calls return -EINTR */
   747		current->restart_block.fn = do_no_restart_syscall;
   748	
   749		if (!access_ok(uc, sizeof(*uc)))
   750			goto badframe;
   751	
 > 752		if (get_user_sigset(&set, &uc->uc_sigmask))
   753			goto badframe;
   754	
   755		set_current_blocked(&set);
   756	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30676 bytes --]