[intel-linux-intel-lts:5.4/yocto 39/1142] drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock'.

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [intel-linux-intel-lts:5.4/yocto 39/1142] drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock'.
Date: Tue, 16 Feb 2021 11:51:55 +0300	[thread overview]
Message-ID: <20210216085155.GU2087@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 3208 bytes --]

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   eeb611e5394c56d45c5cc8f7dc484c9f19e93143
commit: 2baf6e1cd6f179dd497cfc10294920e99bc3a66e [39/1142] dmaengine: dw-axi-dma: support slave dma mode
config: i386-randconfig-m021-20210215 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock'.
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'flags'.

vim +941 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c

1fe20f1b84548b Eugeniy Paltsev 2018-03-06  913  static noinline void axi_chan_handle_err(struct axi_dma_chan *chan, u32 status)
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  914  {
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  915  	struct virt_dma_desc *vd;
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  916  	unsigned long flags;
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  917  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  918  	spin_lock_irqsave(&chan->vc.lock, flags);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  919  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  920  	axi_chan_disable(chan);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  921  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  922  	/* The bad descriptor currently is in the head of vc list */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  923  	vd = vchan_next_desc(&chan->vc);
2baf6e1cd6f179 Sia Jee Heng    2020-06-26  924  	if (!vd)
2baf6e1cd6f179 Sia Jee Heng    2020-06-26  925  		return;

unlock and restore IRQs before returning.

2baf6e1cd6f179 Sia Jee Heng    2020-06-26  926  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  927  	/* Remove the completed descriptor from issued list */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  928  	list_del(&vd->node);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  929  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  930  	/* WARN about bad descriptor */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  931  	dev_err(chan2dev(chan),
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  932  		"Bad descriptor submitted for %s, cookie: %d, irq: 0x%08x\n",
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  933  		axi_chan_name(chan), vd->tx.cookie, status);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  934  	axi_chan_list_dump_lli(chan, vd_to_axi_desc(vd));
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  935  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  936  	vchan_cookie_complete(vd);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  937  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  938  	/* Try to restart the controller */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  939  	axi_chan_start_first_queued(chan);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  940  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06 @941  	spin_unlock_irqrestore(&chan->vc.lock, flags);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  942  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36970 bytes --]

WARNING: multiple messages have this Message-ID (diff)

From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [intel-linux-intel-lts:5.4/yocto 39/1142] drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock'.
Date: Tue, 16 Feb 2021 11:51:55 +0300	[thread overview]
Message-ID: <20210216085155.GU2087@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 3208 bytes --]

tree:   https://github.com/intel/linux-intel-lts.git 5.4/yocto
head:   eeb611e5394c56d45c5cc8f7dc484c9f19e93143
commit: 2baf6e1cd6f179dd497cfc10294920e99bc3a66e [39/1142] dmaengine: dw-axi-dma: support slave dma mode
config: i386-randconfig-m021-20210215 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock'.
drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'flags'.

vim +941 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c

1fe20f1b84548b Eugeniy Paltsev 2018-03-06  913  static noinline void axi_chan_handle_err(struct axi_dma_chan *chan, u32 status)
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  914  {
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  915  	struct virt_dma_desc *vd;
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  916  	unsigned long flags;
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  917  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  918  	spin_lock_irqsave(&chan->vc.lock, flags);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  919  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  920  	axi_chan_disable(chan);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  921  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  922  	/* The bad descriptor currently is in the head of vc list */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  923  	vd = vchan_next_desc(&chan->vc);
2baf6e1cd6f179 Sia Jee Heng    2020-06-26  924  	if (!vd)
2baf6e1cd6f179 Sia Jee Heng    2020-06-26  925  		return;

unlock and restore IRQs before returning.

2baf6e1cd6f179 Sia Jee Heng    2020-06-26  926  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  927  	/* Remove the completed descriptor from issued list */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  928  	list_del(&vd->node);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  929  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  930  	/* WARN about bad descriptor */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  931  	dev_err(chan2dev(chan),
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  932  		"Bad descriptor submitted for %s, cookie: %d, irq: 0x%08x\n",
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  933  		axi_chan_name(chan), vd->tx.cookie, status);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  934  	axi_chan_list_dump_lli(chan, vd_to_axi_desc(vd));
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  935  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  936  	vchan_cookie_complete(vd);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  937  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  938  	/* Try to restart the controller */
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  939  	axi_chan_start_first_queued(chan);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  940  
1fe20f1b84548b Eugeniy Paltsev 2018-03-06 @941  	spin_unlock_irqrestore(&chan->vc.lock, flags);
1fe20f1b84548b Eugeniy Paltsev 2018-03-06  942  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36970 bytes --]

next             reply	other threads:[~2021-02-16  8:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  8:51 Dan Carpenter [this message]
2021-02-16  8:51 ` [intel-linux-intel-lts:5.4/yocto 39/1142] drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock' Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2021-07-01 19:14 [intel-linux-intel-lts:5.4/yocto 39/1142] drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns '&chan->vc.lock' kernel test robot
2021-02-15 18:35 [intel-linux-intel-lts:5.4/yocto 39/1142] drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:941 axi_chan_handle_err() warn: inconsistent returns 'chan->vc.lock' kernel test robot
2020-12-14 10:34 Dan Carpenter
2020-12-14 10:34 ` Dan Carpenter
2020-12-12  9:37 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210216085155.GU2087@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.