From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Mårten Lindahl" <Marten.Lindahl@axis.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>, kernel <kernel@axis.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: exynos5: Preserve high speed master code
Date: Wed, 17 Feb 2021 09:32:11 +0100 [thread overview]
Message-ID: <20210217083211.GN30470@axis.com> (raw)
In-Reply-To: <20210217080747.a7nqzbotszwlb3dd@kozik-lap>
On Wed, Feb 17, 2021 at 09:07:47AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Feb 16, 2021 at 11:09:33PM +0100, Marten Lindahl wrote:
> > > Any reason why not "|= MASTER_ID(i2c->adap.nr)" here instead of more
> > > expensive IO read? It's quite important because your current code will
> > > bitwise-or old I2C slave address with a new one... This should break
> > > during tests with multiple I2C slave devices, shouldn't it?
> > >
> >
> > You are correct. It is better to use the macro instead, and yes,
> > safer too. I only have one device that supports high speed i2c, but
> > I get your point. It could potentially break.
> >
> > > On which HW did you test it?
> >
> > I used an Artpec development board as master and INA230EVM board
> > as slave.
>
> Artpec development board with? What SoC?
The ARTPEC-line of SoC:s are Axis Communications own ASICs, in the latest iteration
it's a Cortex-53 and includes instances of the exynos5 HSI2C ip.
> Best regards,
> Krzysztof
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"Mårten Lindahl" <Marten.Lindahl@axis.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kernel <kernel@axis.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] i2c: exynos5: Preserve high speed master code
Date: Wed, 17 Feb 2021 09:32:11 +0100 [thread overview]
Message-ID: <20210217083211.GN30470@axis.com> (raw)
In-Reply-To: <20210217080747.a7nqzbotszwlb3dd@kozik-lap>
On Wed, Feb 17, 2021 at 09:07:47AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Feb 16, 2021 at 11:09:33PM +0100, Marten Lindahl wrote:
> > > Any reason why not "|= MASTER_ID(i2c->adap.nr)" here instead of more
> > > expensive IO read? It's quite important because your current code will
> > > bitwise-or old I2C slave address with a new one... This should break
> > > during tests with multiple I2C slave devices, shouldn't it?
> > >
> >
> > You are correct. It is better to use the macro instead, and yes,
> > safer too. I only have one device that supports high speed i2c, but
> > I get your point. It could potentially break.
> >
> > > On which HW did you test it?
> >
> > I used an Artpec development board as master and INA230EVM board
> > as slave.
>
> Artpec development board with? What SoC?
The ARTPEC-line of SoC:s are Axis Communications own ASICs, in the latest iteration
it's a Cortex-53 and includes instances of the exynos5 HSI2C ip.
> Best regards,
> Krzysztof
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-17 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 19:03 [PATCH] i2c: exynos5: Preserve high speed master code Mårten Lindahl
2021-02-15 19:03 ` Mårten Lindahl
2021-02-16 7:51 ` Krzysztof Kozlowski
2021-02-16 7:51 ` Krzysztof Kozlowski
2021-02-16 22:09 ` Marten Lindahl
2021-02-16 22:09 ` Marten Lindahl
2021-02-17 8:07 ` Krzysztof Kozlowski
2021-02-17 8:07 ` Krzysztof Kozlowski
2021-02-17 8:32 ` Jesper Nilsson [this message]
2021-02-17 8:32 ` Jesper Nilsson
2021-02-17 8:43 ` Krzysztof Kozlowski
2021-02-17 8:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217083211.GN30470@axis.com \
--to=jesper.nilsson@axis.com \
--cc=Marten.Lindahl@axis.com \
--cc=kernel@axis.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.