[jlayton:ceph-netfs-lib 4/6] fs/ceph/addr.c:304:37: sparse: sparse: symbol 'ceph_netfs_read_ops' was not declared. Should it be

[jlayton:ceph-netfs-lib 4/6] fs/ceph/addr.c:304:37: sparse: sparse: symbol 'ceph_netfs_read_ops' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git ceph-netfs-lib
head:   1147b94f2c8d567a46fd3550db71b7e2d3c7bb3d
commit: a4c56bdbfcd408a31457f881a270b6826bd80636 [4/6] ceph: convert readpage to fscache read helper
config: i386-randconfig-s002-20210217 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-215-g0fb77bb6-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git/commit/?id=a4c56bdbfcd408a31457f881a270b6826bd80636
        git remote add jlayton https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git
        git fetch --no-tags jlayton ceph-netfs-lib
        git checkout a4c56bdbfcd408a31457f881a270b6826bd80636
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> fs/ceph/addr.c:304:37: sparse: sparse: symbol 'ceph_netfs_read_ops' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33978 bytes --]

[RFC PATCH jlayton] ceph: ceph_netfs_read_ops can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]


Fixes: a4c56bdbfcd4 ("ceph: convert readpage to fscache read helper")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 addr.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 81146d75f85e5..0a73121341efb 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -301,7 +301,7 @@ static void ceph_init_rreq(struct netfs_read_request *rreq, struct file *file)
 {
 }
 
-const struct netfs_read_request_ops ceph_netfs_read_ops = {
+static const struct netfs_read_request_ops ceph_netfs_read_ops = {
 	.init_rreq		= ceph_init_rreq,
 	.is_cache_enabled	= ceph_is_cache_enabled,
 	.begin_cache_operation	= ceph_begin_cache_operation,