All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>,
	ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
	bpf@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
	"Björn Töpel" <bjorn.topel@intel.com>,
	maciej.fijalkowski@intel.com, hawk@kernel.org, toke@redhat.com,
	magnus.karlsson@intel.com, john.fastabend@gmail.com
Subject: Re: [PATCH bpf-next 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP
Date: Sat, 20 Feb 2021 02:13:08 +0800	[thread overview]
Message-ID: <202102200255.9ojVROBd-lkp@intel.com> (raw)
In-Reply-To: <20210219145922.63655-2-bjorn.topel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 9899 bytes --]

Hi "Björn,

I love your patch! Yet something to improve:

[auto build test ERROR on 7b1e385c9a488de9291eaaa412146d3972e9dec5]

url:    https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Optimize-bpf_redirect_map-xdp_do_redirect/20210219-230349
base:   7b1e385c9a488de9291eaaa412146d3972e9dec5
config: x86_64-randconfig-r032-20210219 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/e784328ffb3b588155aeee02ff6a96b4a6b7cf20
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bj-rn-T-pel/Optimize-bpf_redirect_map-xdp_do_redirect/20210219-230349
        git checkout e784328ffb3b588155aeee02ff6a96b4a6b7cf20
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from arch/x86/kernel/asm-offsets.c:13:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: warning: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   1 warning generated.
--
   In file included from arch/x86/mm/ioremap.c:23:
   In file included from arch/x86/include/asm/efi.h:7:
   In file included from arch/x86/include/asm/tlb.h:12:
   In file included from include/asm-generic/tlb.h:15:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: warning: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   arch/x86/mm/ioremap.c:737:17: warning: no previous prototype for function 'early_memremap_pgprot_adjust' [-Wmissing-prototypes]
   pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
                   ^
   arch/x86/mm/ioremap.c:737:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
   ^
   static 
   2 warnings generated.
--
   In file included from arch/x86/mm/extable.c:9:
   In file included from arch/x86/include/asm/traps.h:9:
   In file included from arch/x86/include/asm/idtentry.h:9:
   In file included from include/linux/entry-common.h:5:
   In file included from include/linux/tracehook.h:50:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: warning: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   arch/x86/mm/extable.c:27:16: warning: no previous prototype for function 'ex_handler_default' [-Wmissing-prototypes]
   __visible bool ex_handler_default(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:27:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_default(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:37:16: warning: no previous prototype for function 'ex_handler_fault' [-Wmissing-prototypes]
   __visible bool ex_handler_fault(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:37:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_fault(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:58:16: warning: no previous prototype for function 'ex_handler_fprestore' [-Wmissing-prototypes]
   __visible bool ex_handler_fprestore(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:58:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_fprestore(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:73:16: warning: no previous prototype for function 'ex_handler_uaccess' [-Wmissing-prototypes]
   __visible bool ex_handler_uaccess(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:73:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_uaccess(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:84:16: warning: no previous prototype for function 'ex_handler_copy' [-Wmissing-prototypes]
   __visible bool ex_handler_copy(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:84:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_copy(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:96:16: warning: no previous prototype for function 'ex_handler_rdmsr_unsafe' [-Wmissing-prototypes]
   __visible bool ex_handler_rdmsr_unsafe(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:96:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_rdmsr_unsafe(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:113:16: warning: no previous prototype for function 'ex_handler_wrmsr_unsafe' [-Wmissing-prototypes]
   __visible bool ex_handler_wrmsr_unsafe(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:113:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_wrmsr_unsafe(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:129:16: warning: no previous prototype for function 'ex_handler_clear_fs' [-Wmissing-prototypes]
   __visible bool ex_handler_clear_fs(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:129:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_clear_fs(const struct exception_table_entry *fixup,
             ^
             static 
   9 warnings generated.
--
   In file included from <built-in>:3:
   In file included from drivers/gpu/drm/i915/display/intel_cdclk.h:11:
   In file included from drivers/gpu/drm/i915/i915_drv.h:46:
   In file included from include/linux/perf_event.h:57:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: error: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Werror,-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   1 error generated.
--
   In file included from arch/x86/kernel/asm-offsets.c:13:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: warning: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   1 warning generated.


vim +1629 include/linux/bpf.h

9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1628  
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16 @1629  static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1630  				  struct xdp_buff *xdp,
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1631  				  struct net_device *dev_rx)
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1632  {
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1633  	return 0;
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1634  }
040ee69226f8a9 Al Viro                2017-12-02  1635  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33551 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH bpf-next 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP
Date: Sat, 20 Feb 2021 02:13:08 +0800	[thread overview]
Message-ID: <202102200255.9ojVROBd-lkp@intel.com> (raw)
In-Reply-To: <20210219145922.63655-2-bjorn.topel@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 10071 bytes --]

Hi "Björn,

I love your patch! Yet something to improve:

[auto build test ERROR on 7b1e385c9a488de9291eaaa412146d3972e9dec5]

url:    https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Optimize-bpf_redirect_map-xdp_do_redirect/20210219-230349
base:   7b1e385c9a488de9291eaaa412146d3972e9dec5
config: x86_64-randconfig-r032-20210219 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c9439ca36342fb6013187d0a69aef92736951476)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/e784328ffb3b588155aeee02ff6a96b4a6b7cf20
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Bj-rn-T-pel/Optimize-bpf_redirect_map-xdp_do_redirect/20210219-230349
        git checkout e784328ffb3b588155aeee02ff6a96b4a6b7cf20
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from arch/x86/kernel/asm-offsets.c:13:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: warning: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   1 warning generated.
--
   In file included from arch/x86/mm/ioremap.c:23:
   In file included from arch/x86/include/asm/efi.h:7:
   In file included from arch/x86/include/asm/tlb.h:12:
   In file included from include/asm-generic/tlb.h:15:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: warning: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   arch/x86/mm/ioremap.c:737:17: warning: no previous prototype for function 'early_memremap_pgprot_adjust' [-Wmissing-prototypes]
   pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
                   ^
   arch/x86/mm/ioremap.c:737:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   pgprot_t __init early_memremap_pgprot_adjust(resource_size_t phys_addr,
   ^
   static 
   2 warnings generated.
--
   In file included from arch/x86/mm/extable.c:9:
   In file included from arch/x86/include/asm/traps.h:9:
   In file included from arch/x86/include/asm/idtentry.h:9:
   In file included from include/linux/entry-common.h:5:
   In file included from include/linux/tracehook.h:50:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: warning: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   arch/x86/mm/extable.c:27:16: warning: no previous prototype for function 'ex_handler_default' [-Wmissing-prototypes]
   __visible bool ex_handler_default(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:27:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_default(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:37:16: warning: no previous prototype for function 'ex_handler_fault' [-Wmissing-prototypes]
   __visible bool ex_handler_fault(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:37:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_fault(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:58:16: warning: no previous prototype for function 'ex_handler_fprestore' [-Wmissing-prototypes]
   __visible bool ex_handler_fprestore(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:58:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_fprestore(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:73:16: warning: no previous prototype for function 'ex_handler_uaccess' [-Wmissing-prototypes]
   __visible bool ex_handler_uaccess(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:73:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_uaccess(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:84:16: warning: no previous prototype for function 'ex_handler_copy' [-Wmissing-prototypes]
   __visible bool ex_handler_copy(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:84:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_copy(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:96:16: warning: no previous prototype for function 'ex_handler_rdmsr_unsafe' [-Wmissing-prototypes]
   __visible bool ex_handler_rdmsr_unsafe(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:96:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_rdmsr_unsafe(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:113:16: warning: no previous prototype for function 'ex_handler_wrmsr_unsafe' [-Wmissing-prototypes]
   __visible bool ex_handler_wrmsr_unsafe(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:113:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_wrmsr_unsafe(const struct exception_table_entry *fixup,
             ^
             static 
   arch/x86/mm/extable.c:129:16: warning: no previous prototype for function 'ex_handler_clear_fs' [-Wmissing-prototypes]
   __visible bool ex_handler_clear_fs(const struct exception_table_entry *fixup,
                  ^
   arch/x86/mm/extable.c:129:11: note: declare 'static' if the function is not intended to be used outside of this translation unit
   __visible bool ex_handler_clear_fs(const struct exception_table_entry *fixup,
             ^
             static 
   9 warnings generated.
--
   In file included from <built-in>:3:
   In file included from drivers/gpu/drm/i915/display/intel_cdclk.h:11:
   In file included from drivers/gpu/drm/i915/i915_drv.h:46:
   In file included from include/linux/perf_event.h:57:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: error: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Werror,-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   1 error generated.
--
   In file included from arch/x86/kernel/asm-offsets.c:13:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:28:
   In file included from include/linux/cgroup-defs.h:22:
   In file included from include/linux/bpf-cgroup.h:5:
>> include/linux/bpf.h:1629:42: warning: declaration of 'struct bpf_cpu_map_entry' will not be visible outside of this function [-Wvisibility]
   static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
                                            ^
   1 warning generated.


vim +1629 include/linux/bpf.h

9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1628  
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16 @1629  static inline int cpu_map_enqueue(struct bpf_cpu_map_entry *rcpu,
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1630  				  struct xdp_buff *xdp,
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1631  				  struct net_device *dev_rx)
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1632  {
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1633  	return 0;
9c270af37bb62e Jesper Dangaard Brouer 2017-10-16  1634  }
040ee69226f8a9 Al Viro                2017-12-02  1635  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33551 bytes --]

  parent reply	other threads:[~2021-02-19 18:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19 14:59 [PATCH bpf-next 0/2] Optimize bpf_redirect_map()/xdp_do_redirect() Björn Töpel
2021-02-19 14:59 ` [PATCH bpf-next 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP Björn Töpel
2021-02-19 17:05   ` Toke Høiland-Jørgensen
2021-02-19 17:47     ` Björn Töpel
2021-02-19 17:08   ` kernel test robot
2021-02-19 17:08     ` kernel test robot
2021-02-19 18:13   ` kernel test robot [this message]
2021-02-19 18:13     ` kernel test robot
2021-02-19 14:59 ` [PATCH bpf-next 2/2] bpf, xdp: restructure redirect actions Björn Töpel
2021-02-19 17:10   ` Toke Høiland-Jørgensen
2021-02-19 17:49     ` Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202102200255.9ojVROBd-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@gmail.com \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=daniel@iogearbox.net \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=magnus.karlsson@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.