* [PATCH 1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile"
@ 2021-02-21 21:02 Elia Devito
2021-02-22 9:55 ` Hans de Goede
2021-03-04 13:26 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Elia Devito @ 2021-02-21 21:02 UTC (permalink / raw)
Cc: Elia Devito, Hans de Goede, Mark Gross, platform-driver-x86,
linux-kernel
rename "thermal policy" with the more appropriate term "thermal profile"
Signed-off-by: Elia Devito <eliadevito@gmail.com>
---
drivers/platform/x86/hp-wmi.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index e94e59283ecb..6d7b91b8109b 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -85,7 +85,7 @@ enum hp_wmi_commandtype {
HPWMI_FEATURE2_QUERY = 0x0d,
HPWMI_WIRELESS2_QUERY = 0x1b,
HPWMI_POSTCODEERROR_QUERY = 0x2a,
- HPWMI_THERMAL_POLICY_QUERY = 0x4c,
+ HPWMI_THERMAL_PROFILE_QUERY = 0x4c,
};
enum hp_wmi_command {
@@ -869,19 +869,19 @@ static int __init hp_wmi_rfkill2_setup(struct platform_device *device)
return err;
}
-static int thermal_policy_setup(struct platform_device *device)
+static int thermal_profile_setup(struct platform_device *device)
{
int err, tp;
- tp = hp_wmi_read_int(HPWMI_THERMAL_POLICY_QUERY);
+ tp = hp_wmi_read_int(HPWMI_THERMAL_PROFILE_QUERY);
if (tp < 0)
return tp;
/*
- * call thermal policy write command to ensure that the firmware correctly
+ * call thermal profile write command to ensure that the firmware correctly
* sets the OEM variables for the DPTF
*/
- err = hp_wmi_perform_query(HPWMI_THERMAL_POLICY_QUERY, HPWMI_WRITE, &tp,
+ err = hp_wmi_perform_query(HPWMI_THERMAL_PROFILE_QUERY, HPWMI_WRITE, &tp,
sizeof(tp), 0);
if (err)
return err;
@@ -900,7 +900,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device)
if (hp_wmi_rfkill_setup(device))
hp_wmi_rfkill2_setup(device);
- thermal_policy_setup(device);
+ thermal_profile_setup(device);
return 0;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile"
2021-02-21 21:02 [PATCH 1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile" Elia Devito
@ 2021-02-22 9:55 ` Hans de Goede
2021-03-04 13:26 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-02-22 9:55 UTC (permalink / raw)
To: Elia Devito; +Cc: Mark Gross, platform-driver-x86, linux-kernel
Hi,
On 2/21/21 10:02 PM, Elia Devito wrote:
> rename "thermal policy" with the more appropriate term "thermal profile"
>
> Signed-off-by: Elia Devito <eliadevito@gmail.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
I will merge this once we are out of the merge-window / once 5.12-rc1 is out.
Regards,
Hans
> ---
> drivers/platform/x86/hp-wmi.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index e94e59283ecb..6d7b91b8109b 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -85,7 +85,7 @@ enum hp_wmi_commandtype {
> HPWMI_FEATURE2_QUERY = 0x0d,
> HPWMI_WIRELESS2_QUERY = 0x1b,
> HPWMI_POSTCODEERROR_QUERY = 0x2a,
> - HPWMI_THERMAL_POLICY_QUERY = 0x4c,
> + HPWMI_THERMAL_PROFILE_QUERY = 0x4c,
> };
>
> enum hp_wmi_command {
> @@ -869,19 +869,19 @@ static int __init hp_wmi_rfkill2_setup(struct platform_device *device)
> return err;
> }
>
> -static int thermal_policy_setup(struct platform_device *device)
> +static int thermal_profile_setup(struct platform_device *device)
> {
> int err, tp;
>
> - tp = hp_wmi_read_int(HPWMI_THERMAL_POLICY_QUERY);
> + tp = hp_wmi_read_int(HPWMI_THERMAL_PROFILE_QUERY);
> if (tp < 0)
> return tp;
>
> /*
> - * call thermal policy write command to ensure that the firmware correctly
> + * call thermal profile write command to ensure that the firmware correctly
> * sets the OEM variables for the DPTF
> */
> - err = hp_wmi_perform_query(HPWMI_THERMAL_POLICY_QUERY, HPWMI_WRITE, &tp,
> + err = hp_wmi_perform_query(HPWMI_THERMAL_PROFILE_QUERY, HPWMI_WRITE, &tp,
> sizeof(tp), 0);
> if (err)
> return err;
> @@ -900,7 +900,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device)
> if (hp_wmi_rfkill_setup(device))
> hp_wmi_rfkill2_setup(device);
>
> - thermal_policy_setup(device);
> + thermal_profile_setup(device);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile"
2021-02-21 21:02 [PATCH 1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile" Elia Devito
2021-02-22 9:55 ` Hans de Goede
@ 2021-03-04 13:26 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2021-03-04 13:26 UTC (permalink / raw)
To: Elia Devito; +Cc: Mark Gross, platform-driver-x86, linux-kernel
Hi,
On 2/21/21 10:02 PM, Elia Devito wrote:
> rename "thermal policy" with the more appropriate term "thermal profile"
>
> Signed-off-by: Elia Devito <eliadevito@gmail.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/hp-wmi.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
> index e94e59283ecb..6d7b91b8109b 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -85,7 +85,7 @@ enum hp_wmi_commandtype {
> HPWMI_FEATURE2_QUERY = 0x0d,
> HPWMI_WIRELESS2_QUERY = 0x1b,
> HPWMI_POSTCODEERROR_QUERY = 0x2a,
> - HPWMI_THERMAL_POLICY_QUERY = 0x4c,
> + HPWMI_THERMAL_PROFILE_QUERY = 0x4c,
> };
>
> enum hp_wmi_command {
> @@ -869,19 +869,19 @@ static int __init hp_wmi_rfkill2_setup(struct platform_device *device)
> return err;
> }
>
> -static int thermal_policy_setup(struct platform_device *device)
> +static int thermal_profile_setup(struct platform_device *device)
> {
> int err, tp;
>
> - tp = hp_wmi_read_int(HPWMI_THERMAL_POLICY_QUERY);
> + tp = hp_wmi_read_int(HPWMI_THERMAL_PROFILE_QUERY);
> if (tp < 0)
> return tp;
>
> /*
> - * call thermal policy write command to ensure that the firmware correctly
> + * call thermal profile write command to ensure that the firmware correctly
> * sets the OEM variables for the DPTF
> */
> - err = hp_wmi_perform_query(HPWMI_THERMAL_POLICY_QUERY, HPWMI_WRITE, &tp,
> + err = hp_wmi_perform_query(HPWMI_THERMAL_PROFILE_QUERY, HPWMI_WRITE, &tp,
> sizeof(tp), 0);
> if (err)
> return err;
> @@ -900,7 +900,7 @@ static int __init hp_wmi_bios_setup(struct platform_device *device)
> if (hp_wmi_rfkill_setup(device))
> hp_wmi_rfkill2_setup(device);
>
> - thermal_policy_setup(device);
> + thermal_profile_setup(device);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-04 13:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-21 21:02 [PATCH 1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile" Elia Devito
2021-02-22 9:55 ` Hans de Goede
2021-03-04 13:26 ` Hans de Goede
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.