From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [RFC PATCH v5 4/4] dm kcopyd: add simple copy offload support
Date: Mon, 22 Feb 2021 08:28:27 +0300 [thread overview]
Message-ID: <20210222052827.GE2087@kadam> (raw)
In-Reply-To: <20210219124517.79359-5-selvakuma.s1@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 3564 bytes --]
Hi SelvaKumar,
url: https://github.com/0day-ci/linux/commits/SelvaKumar-S/block-make-bio_map_kern-non-static/20210220-100547
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f40ddce88593482919761f74910f42f4b84c004b
config: i386-randconfig-m021-20210219 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/md/dm-kcopyd.c:613 run_copy_job() error: uninitialized symbol 'r'.
vim +/r +613 drivers/md/dm-kcopyd.c
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 586 static int run_copy_job(struct kcopyd_job *job)
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 587 {
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 588 int r, i, count = 0;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 589 unsigned long flags = 0;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 590 struct range_entry srange;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 591
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 592 flags |= BLKDEV_COPY_NOEMULATION;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 593 for (i = 0; i < job->num_dests; i++) {
^^^^^^^^^^^^^^^^^^
Can job->num_dests be zero?
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 594 srange.src = job->source.sector;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 595 srange.len = job->source.count;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 596
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 597 r = blkdev_issue_copy(job->source.bdev, 1, &srange,
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 598 job->dests[i].bdev, job->dests[i].sector, GFP_KERNEL, flags);
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 599 if (r)
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 600 break;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 601
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 602 job->dests[i].count = 0;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 603 count++;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 604 }
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 605
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 606 if (count == job->num_dests) {
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 607 push(&job->kc->complete_jobs, job);
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 608 } else {
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 609 push(&job->kc->pages_jobs, job);
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 610 r = 0;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 611 }
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 612
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 @613 return r;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 614 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35671 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH v5 4/4] dm kcopyd: add simple copy offload support
Date: Mon, 22 Feb 2021 08:28:27 +0300 [thread overview]
Message-ID: <20210222052827.GE2087@kadam> (raw)
In-Reply-To: <20210219124517.79359-5-selvakuma.s1@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 3564 bytes --]
Hi SelvaKumar,
url: https://github.com/0day-ci/linux/commits/SelvaKumar-S/block-make-bio_map_kern-non-static/20210220-100547
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f40ddce88593482919761f74910f42f4b84c004b
config: i386-randconfig-m021-20210219 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/md/dm-kcopyd.c:613 run_copy_job() error: uninitialized symbol 'r'.
vim +/r +613 drivers/md/dm-kcopyd.c
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 586 static int run_copy_job(struct kcopyd_job *job)
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 587 {
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 588 int r, i, count = 0;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 589 unsigned long flags = 0;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 590 struct range_entry srange;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 591
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 592 flags |= BLKDEV_COPY_NOEMULATION;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 593 for (i = 0; i < job->num_dests; i++) {
^^^^^^^^^^^^^^^^^^
Can job->num_dests be zero?
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 594 srange.src = job->source.sector;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 595 srange.len = job->source.count;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 596
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 597 r = blkdev_issue_copy(job->source.bdev, 1, &srange,
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 598 job->dests[i].bdev, job->dests[i].sector, GFP_KERNEL, flags);
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 599 if (r)
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 600 break;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 601
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 602 job->dests[i].count = 0;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 603 count++;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 604 }
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 605
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 606 if (count == job->num_dests) {
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 607 push(&job->kc->complete_jobs, job);
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 608 } else {
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 609 push(&job->kc->pages_jobs, job);
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 610 r = 0;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 611 }
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 612
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 @613 return r;
f79939bb63c402 drivers/md/dm-kcopyd.c SelvaKumar S 2021-02-19 614 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35671 bytes --]
next prev parent reply other threads:[~2021-02-22 5:28 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210219124555epcas5p1334e7c4d64ada5dc4a2ca0feb48c1d44@epcas5p1.samsung.com>
2021-02-19 12:45 ` [dm-devel] [RFC PATCH v5 0/4] add simple copy support SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-19 12:45 ` [dm-devel] [RFC PATCH v5 1/4] block: make bio_map_kern() non static SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-19 12:45 ` [dm-devel] [RFC PATCH v5 2/4] block: add simple copy support SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-20 4:59 ` [dm-devel] " Damien Le Moal
2021-02-20 4:59 ` Damien Le Moal
2021-02-20 4:59 ` Damien Le Moal
2021-04-07 11:32 ` [dm-devel] " Selva Jove
2021-04-07 11:32 ` Selva Jove
2021-04-07 11:32 ` Selva Jove
2021-04-12 0:24 ` [dm-devel] " Damien Le Moal
2021-04-12 0:24 ` Damien Le Moal
2021-04-12 0:24 ` Damien Le Moal
2021-04-12 14:34 ` [dm-devel] " Selva Jove
2021-04-12 14:34 ` Selva Jove
2021-04-12 14:34 ` Selva Jove
2021-04-13 0:32 ` [dm-devel] " Damien Le Moal
2021-04-13 0:32 ` Damien Le Moal
2021-04-13 0:32 ` Damien Le Moal
2021-04-14 6:58 ` [dm-devel] " Selva Jove
2021-04-14 6:58 ` Selva Jove
2021-04-14 6:58 ` Selva Jove
2021-02-20 5:24 ` kernel test robot
2021-02-19 12:45 ` [dm-devel] [RFC PATCH v5 3/4] nvme: " SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-20 3:36 ` [dm-devel] " Matthew Wilcox
2021-02-20 3:36 ` Matthew Wilcox
2021-02-20 3:36 ` Matthew Wilcox
2021-02-22 15:57 ` [dm-devel] " Selva Jove
2021-02-22 15:57 ` Selva Jove
2021-02-22 15:57 ` Selva Jove
2021-02-19 12:45 ` [dm-devel] [RFC PATCH v5 4/4] dm kcopyd: add simple copy offload support SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-19 12:45 ` SelvaKumar S
2021-02-22 5:28 ` Dan Carpenter [this message]
2021-02-22 5:28 ` Dan Carpenter
2021-02-20 18:01 ` [dm-devel] [RFC PATCH v5 0/4] add simple copy support David Laight
2021-02-20 18:01 ` David Laight
2021-02-20 18:01 ` David Laight
2021-02-20 19:08 ` [dm-devel] " Matthew Wilcox
2021-02-20 19:08 ` Matthew Wilcox
2021-02-20 19:08 ` Matthew Wilcox
2021-02-20 19:19 ` [dm-devel] " Keith Busch
2021-02-20 19:19 ` Keith Busch
2021-02-20 19:19 ` Keith Busch
2021-02-21 23:52 ` [dm-devel] " Dave Chinner
2021-02-21 23:52 ` Dave Chinner
2021-02-21 23:52 ` Dave Chinner
2021-02-23 9:14 ` [dm-devel] " Selva Jove
2021-02-23 9:14 ` Selva Jove
2021-02-23 9:14 ` Selva Jove
2021-02-22 1:31 ` [dm-devel] " Ming Lei
2021-02-22 1:31 ` Ming Lei
2021-02-22 1:31 ` Ming Lei
2021-02-22 6:52 ` [dm-devel] " Su Yue
2021-02-22 6:52 ` Su Yue
2021-02-22 6:52 ` Su Yue
2021-02-23 9:00 ` [dm-devel] " Selva Jove
2021-02-23 9:00 ` Selva Jove
2021-02-23 9:00 ` Selva Jove
2021-04-10 0:21 ` [dm-devel] " Max Gurtovoy
2021-04-10 0:21 ` Max Gurtovoy
2021-04-10 0:21 ` Max Gurtovoy
2021-04-10 0:29 ` [dm-devel] " Chaitanya Kulkarni
2021-04-10 0:29 ` Chaitanya Kulkarni
2021-04-10 0:29 ` Chaitanya Kulkarni
2021-04-10 6:32 ` [dm-devel] " Javier González
2021-04-10 6:32 ` Javier González
2021-04-10 6:32 ` Javier González
2021-04-11 9:10 ` [dm-devel] " Max Gurtovoy
2021-04-11 9:10 ` Max Gurtovoy
2021-04-11 9:10 ` Max Gurtovoy
2021-04-11 19:26 ` [dm-devel] " Javier González
2021-04-11 19:26 ` Javier González
2021-04-11 19:26 ` Javier González
2021-04-13 15:38 ` [dm-devel] " Max Gurtovoy
2021-04-13 15:38 ` Max Gurtovoy
2021-04-13 15:38 ` Max Gurtovoy
2021-04-13 18:25 ` [dm-devel] " Javier González
2021-04-13 18:25 ` Javier González
2021-04-13 18:25 ` Javier González
2021-04-13 18:36 ` [dm-devel] " Chaitanya Kulkarni
2021-04-13 18:36 ` Chaitanya Kulkarni
2021-04-13 18:36 ` Chaitanya Kulkarni
2021-02-20 5:52 [RFC PATCH v5 4/4] dm kcopyd: add simple copy offload support kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222052827.GE2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.