From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: shahafs@mellanox.com, rdunlap@infradead.org,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH V4 0/3] virtio-pci: introduce modern device module
Date: Tue, 23 Feb 2021 07:16:16 -0500 [thread overview]
Message-ID: <20210223071553-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210223061905.422659-1-jasowang@redhat.com>
On Tue, Feb 23, 2021 at 02:19:02PM +0800, Jason Wang wrote:
> Hi all:
>
> This series tries to implement a vDPA driver for virtio-pci device
> which will bridge between vDPA bus and virtio-pci device.
>
> This could be used for future feature prototyping and testing.
>
> Please review
OK just one thing: subject should have had V5, not V4.
> Changes since V4:
> - include the patch to let VIRTIO_PCI_LIB to be auto selected
> - style fixes in the Kconfig for vp-vdpa driver
> - fix the err value returned during vp-vdpa driver probing
>
> Changes since V3:
> - rebase to vhost.git
>
> Changes since V2:
>
> - tweak config prompt
> - switch from 'cb' to 'config_cb' for vp_vdpa config interrupt
> - use a macro for vp_vdpa msix name length
>
> Changes since V1:
>
> - don't try to use devres for virtio-pci core
> - tweak the commit log
> - split the patches furtherly to ease the reviewing
>
> Changes since RFC:
>
> - Split common codes from virito-pci and share it with vDPA driver
> - Use dynamic id in order to be less confusing with virtio-pci driver
> - No feature whitelist, supporting any features (mq, config etc)
>
> Jason Wang (3):
> virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
> vdpa: set the virtqueue num during register
> vdpa: introduce virtio pci driver
>
> drivers/vdpa/Kconfig | 7 +
> drivers/vdpa/Makefile | 1 +
> drivers/vdpa/ifcvf/ifcvf_main.c | 5 +-
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 +-
> drivers/vdpa/vdpa.c | 18 +-
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +-
> drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 2 +-
> drivers/vdpa/virtio_pci/Makefile | 2 +
> drivers/vdpa/virtio_pci/vp_vdpa.c | 458 +++++++++++++++++++++++++++
> drivers/virtio/Kconfig | 11 +-
> drivers/virtio/Makefile | 2 +-
> include/linux/vdpa.h | 10 +-
> 12 files changed, 496 insertions(+), 26 deletions(-)
> create mode 100644 drivers/vdpa/virtio_pci/Makefile
> create mode 100644 drivers/vdpa/virtio_pci/vp_vdpa.c
>
> --
> 2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, shahafs@mellanox.com,
sgarzare@redhat.com, rdunlap@infradead.org
Subject: Re: [PATCH V4 0/3] virtio-pci: introduce modern device module
Date: Tue, 23 Feb 2021 07:16:16 -0500 [thread overview]
Message-ID: <20210223071553-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210223061905.422659-1-jasowang@redhat.com>
On Tue, Feb 23, 2021 at 02:19:02PM +0800, Jason Wang wrote:
> Hi all:
>
> This series tries to implement a vDPA driver for virtio-pci device
> which will bridge between vDPA bus and virtio-pci device.
>
> This could be used for future feature prototyping and testing.
>
> Please review
OK just one thing: subject should have had V5, not V4.
> Changes since V4:
> - include the patch to let VIRTIO_PCI_LIB to be auto selected
> - style fixes in the Kconfig for vp-vdpa driver
> - fix the err value returned during vp-vdpa driver probing
>
> Changes since V3:
> - rebase to vhost.git
>
> Changes since V2:
>
> - tweak config prompt
> - switch from 'cb' to 'config_cb' for vp_vdpa config interrupt
> - use a macro for vp_vdpa msix name length
>
> Changes since V1:
>
> - don't try to use devres for virtio-pci core
> - tweak the commit log
> - split the patches furtherly to ease the reviewing
>
> Changes since RFC:
>
> - Split common codes from virito-pci and share it with vDPA driver
> - Use dynamic id in order to be less confusing with virtio-pci driver
> - No feature whitelist, supporting any features (mq, config etc)
>
> Jason Wang (3):
> virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN
> vdpa: set the virtqueue num during register
> vdpa: introduce virtio pci driver
>
> drivers/vdpa/Kconfig | 7 +
> drivers/vdpa/Makefile | 1 +
> drivers/vdpa/ifcvf/ifcvf_main.c | 5 +-
> drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 +-
> drivers/vdpa/vdpa.c | 18 +-
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 2 +-
> drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 2 +-
> drivers/vdpa/virtio_pci/Makefile | 2 +
> drivers/vdpa/virtio_pci/vp_vdpa.c | 458 +++++++++++++++++++++++++++
> drivers/virtio/Kconfig | 11 +-
> drivers/virtio/Makefile | 2 +-
> include/linux/vdpa.h | 10 +-
> 12 files changed, 496 insertions(+), 26 deletions(-)
> create mode 100644 drivers/vdpa/virtio_pci/Makefile
> create mode 100644 drivers/vdpa/virtio_pci/vp_vdpa.c
>
> --
> 2.25.1
next prev parent reply other threads:[~2021-02-23 12:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 6:19 [PATCH V4 0/3] virtio-pci: introduce modern device module Jason Wang
2021-02-23 6:19 ` Jason Wang
2021-02-23 6:19 ` [PATCH V4 1/3] virtio: don't prompt CONFIG_VIRTIO_PCI_MODERN Jason Wang
2021-02-23 6:19 ` Jason Wang
2021-02-23 8:05 ` Arnd Bergmann
2021-02-23 15:22 ` Guenter Roeck
2021-02-23 15:22 ` Guenter Roeck
2021-02-23 15:50 ` Daniel Díaz
2021-02-23 15:53 ` Michael S. Tsirkin
2021-02-23 15:53 ` Michael S. Tsirkin
2021-02-24 12:30 ` Christian Borntraeger
2021-02-24 12:30 ` Christian Borntraeger
2021-02-23 6:19 ` [PATCH V4 2/3] vdpa: set the virtqueue num during register Jason Wang
2021-02-23 6:19 ` Jason Wang
2021-02-23 6:19 ` [PATCH V4 3/3] vdpa: introduce virtio pci driver Jason Wang
2021-02-23 6:19 ` Jason Wang
2021-02-23 8:17 ` Stefano Garzarella
2021-02-23 8:17 ` Stefano Garzarella
2021-02-23 12:16 ` Michael S. Tsirkin [this message]
2021-02-23 12:16 ` [PATCH V4 0/3] virtio-pci: introduce modern device module Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223071553-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=shahafs@mellanox.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.