All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Allen Pais <apais@linux.microsoft.com>
Cc: Dhananjay Phadke <dphadke@linux.microsoft.com>,
	allen.lkml@gmail.com, zajec5@gmail.com,
	linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
	op-tee@lists.trustedfirmware.org,
	linux-arm-kernel@lists.infradead.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 1/2] optee: fix tee out of memory failure seen during kexec reboot
Date: Tue, 23 Feb 2021 09:19:48 +0100	[thread overview]
Message-ID: <20210223081948.GA1836717@jade> (raw)
In-Reply-To: <8d87655f-27c6-6a66-6eb0-9244279fbf2c@linux.microsoft.com>

On Mon, Feb 22, 2021 at 06:15:08PM +0530, Allen Pais wrote:
> 
> > On Wed, 17 Feb 2021 14:57:12 +0530, Allen Pais wrote:
> > > -	/*
> > > -	 * Ask OP-TEE to free all cached shared memory objects to decrease
> > > -	 * reference counters and also avoid wild pointers in secure world
> > > -	 * into the old shared memory range.
> > > -	 */
> > > -	optee_disable_shm_cache(optee);
> > > +	if (shutdown) {
> > > +		optee_disable_shm_cache(optee);
> > > +	} else {
> > > +		/*
> > > +		 * Ask OP-TEE to free all cached shared memory
> > > +		 * objects to decrease reference counters and
> > > +		 * also avoid wild pointers in secure world
> > > +		 * into the old shared memory range.
> > > +		 */
> > > +		optee_disable_shm_cache(optee);
> > Calling optee_disable_shm_cache() in both if and else. It could be
> > put in front of if().
> > 
> 
>   Ideally, I could just use optee_remove for shutdown() too.
> But it would not look good. Hence this approach.

What is the problem with using optee_remove() for shutdown()?

Cheers,
Jens

WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH 1/2] optee: fix tee out of memory failure seen during kexec reboot
Date: Tue, 23 Feb 2021 09:19:48 +0100	[thread overview]
Message-ID: <20210223081948.GA1836717@jade> (raw)
In-Reply-To: <8d87655f-27c6-6a66-6eb0-9244279fbf2c@linux.microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

On Mon, Feb 22, 2021 at 06:15:08PM +0530, Allen Pais wrote:
> 
> > On Wed, 17 Feb 2021 14:57:12 +0530, Allen Pais wrote:
> > > -	/*
> > > -	 * Ask OP-TEE to free all cached shared memory objects to decrease
> > > -	 * reference counters and also avoid wild pointers in secure world
> > > -	 * into the old shared memory range.
> > > -	 */
> > > -	optee_disable_shm_cache(optee);
> > > +	if (shutdown) {
> > > +		optee_disable_shm_cache(optee);
> > > +	} else {
> > > +		/*
> > > +		 * Ask OP-TEE to free all cached shared memory
> > > +		 * objects to decrease reference counters and
> > > +		 * also avoid wild pointers in secure world
> > > +		 * into the old shared memory range.
> > > +		 */
> > > +		optee_disable_shm_cache(optee);
> > Calling optee_disable_shm_cache() in both if and else. It could be
> > put in front of if().
> > 
> 
>   Ideally, I could just use optee_remove for shutdown() too.
> But it would not look good. Hence this approach.

What is the problem with using optee_remove() for shutdown()?

Cheers,
Jens

WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Allen Pais <apais@linux.microsoft.com>
Cc: zajec5@gmail.com, linux-kernel@vger.kernel.org,
	linux-mips@vger.kernel.org, op-tee@lists.trustedfirmware.org,
	bcm-kernel-feedback-list@broadcom.com,
	Dhananjay Phadke <dphadke@linux.microsoft.com>,
	allen.lkml@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] optee: fix tee out of memory failure seen during kexec reboot
Date: Tue, 23 Feb 2021 09:19:48 +0100	[thread overview]
Message-ID: <20210223081948.GA1836717@jade> (raw)
In-Reply-To: <8d87655f-27c6-6a66-6eb0-9244279fbf2c@linux.microsoft.com>

On Mon, Feb 22, 2021 at 06:15:08PM +0530, Allen Pais wrote:
> 
> > On Wed, 17 Feb 2021 14:57:12 +0530, Allen Pais wrote:
> > > -	/*
> > > -	 * Ask OP-TEE to free all cached shared memory objects to decrease
> > > -	 * reference counters and also avoid wild pointers in secure world
> > > -	 * into the old shared memory range.
> > > -	 */
> > > -	optee_disable_shm_cache(optee);
> > > +	if (shutdown) {
> > > +		optee_disable_shm_cache(optee);
> > > +	} else {
> > > +		/*
> > > +		 * Ask OP-TEE to free all cached shared memory
> > > +		 * objects to decrease reference counters and
> > > +		 * also avoid wild pointers in secure world
> > > +		 * into the old shared memory range.
> > > +		 */
> > > +		optee_disable_shm_cache(optee);
> > Calling optee_disable_shm_cache() in both if and else. It could be
> > put in front of if().
> > 
> 
>   Ideally, I could just use optee_remove for shutdown() too.
> But it would not look good. Hence this approach.

What is the problem with using optee_remove() for shutdown()?

Cheers,
Jens

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-02-23  8:20 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17  9:27 [PATCH 0/2] optee: fix OOM seen due to tee_shm_free() Allen Pais
2021-02-17  9:27 ` Allen Pais
2021-02-17  9:27 ` [PATCH 1/2] optee: fix tee out of memory failure seen during kexec reboot Allen Pais
2021-02-18 20:03   ` Dhananjay Phadke
2021-02-18 20:03   ` Dhananjay Phadke
2021-02-17  9:27   ` Allen Pais
2021-02-22 12:45   ` Allen Pais
2021-02-22 12:45     ` Allen Pais
2021-02-22 12:45     ` Allen Pais
2021-02-23  8:19     ` Jens Wiklander [this message]
2021-02-23  8:19       ` Jens Wiklander
2021-02-23  8:19       ` Jens Wiklander
2021-02-23 16:26       ` Allen Pais
2021-02-23 16:26         ` Allen Pais
2021-02-23 16:26         ` Allen Pais
2021-02-24  8:15         ` Jens Wiklander
2021-02-24  8:15           ` Jens Wiklander
2021-02-24  8:15           ` Jens Wiklander
2021-02-24 16:53           ` Allen Pais
2021-02-24 16:53             ` Allen Pais
2021-02-24 16:53             ` Allen Pais
2021-02-17  9:27 ` [PATCH 2/2] firmware: tee_bnxt: implement shutdown method to handle kexec reboots Allen Pais
2021-02-17  9:27   ` Allen Pais
2021-02-18 18:12 ` [PATCH 0/2] optee: fix OOM seen due to tee_shm_free() Dhananjay Phadke
2021-02-18 18:12   ` Dhananjay Phadke
2021-02-18 18:12   ` Dhananjay Phadke
2021-02-23  6:17 ` Allen Pais
2021-02-23  6:17   ` Allen Pais

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210223081948.GA1836717@jade \
    --to=jens.wiklander@linaro.org \
    --cc=allen.lkml@gmail.com \
    --cc=apais@linux.microsoft.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dphadke@linux.microsoft.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=op-tee@lists.trustedfirmware.org \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.