All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Wiklander <jens.wiklander@linaro.org>
To: op-tee@lists.trustedfirmware.org
Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints
Date: Wed, 24 Feb 2021 09:10:54 +0100	[thread overview]
Message-ID: <20210224081054.GA2653493@jade> (raw)
In-Reply-To: <20210223091936.5b390f35@gandalf.local.home>

[-- Attachment #1: Type: text/plain, Size: 1658 bytes --]

On Tue, Feb 23, 2021 at 09:19:36AM -0500, Steven Rostedt wrote:
> On Tue, 23 Feb 2021 14:11:24 +0100
> Jens Wiklander <jens.wiklander@linaro.org> wrote:
> 
> > I used the -strict option.
> > 
> > ./scripts/checkpatch.pl -strict 0001-tee-optee-add-invoke_fn-tracepoints.patch
> > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > #44: 
> > new file mode 100644
> 
> The above is just asking for someone to take maintainership of the new file.
> 
> > 
> > CHECK: Alignment should match open parenthesis
> > #68: FILE: drivers/tee/optee/optee_trace.h:20:
> > +TRACE_EVENT(optee_invoke_fn_begin,
> > +	TP_PROTO(struct optee_rpc_param *param),
> > 
> > CHECK: Lines should not end with a '('
> > #71: FILE: drivers/tee/optee/optee_trace.h:23:
> > +	TP_STRUCT__entry(
> > 
> > CHECK: Lines should not end with a '('
> > #76: FILE: drivers/tee/optee/optee_trace.h:28:
> > +	TP_fast_assign(
> > 
> > CHECK: Alignment should match open parenthesis
> > #89: FILE: drivers/tee/optee/optee_trace.h:41:
> > +TRACE_EVENT(optee_invoke_fn_end,
> > +	TP_PROTO(struct optee_rpc_param *param, struct arm_smccc_res *res),
> > 
> > CHECK: Lines should not end with a '('
> > #92: FILE: drivers/tee/optee/optee_trace.h:44:
> > +	TP_STRUCT__entry(
> > 
> > CHECK: Lines should not end with a '('
> > #97: FILE: drivers/tee/optee/optee_trace.h:49:
> > +	TP_fast_assign(
> 
> The TRACE_EVENT() macro is "special", and checkpatch notoriously stumbles
> over it. I usually recommend that people ignore the checkpatch warnings on
> TRACE_EVENT() macros.

Makes sense. I'll pick this up as it is.

Thanks,
Jens

WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
	op-tee@lists.trustedfirmware.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints
Date: Wed, 24 Feb 2021 09:10:54 +0100	[thread overview]
Message-ID: <20210224081054.GA2653493@jade> (raw)
In-Reply-To: <20210223091936.5b390f35@gandalf.local.home>

On Tue, Feb 23, 2021 at 09:19:36AM -0500, Steven Rostedt wrote:
> On Tue, 23 Feb 2021 14:11:24 +0100
> Jens Wiklander <jens.wiklander@linaro.org> wrote:
> 
> > I used the -strict option.
> > 
> > ./scripts/checkpatch.pl -strict 0001-tee-optee-add-invoke_fn-tracepoints.patch
> > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > #44: 
> > new file mode 100644
> 
> The above is just asking for someone to take maintainership of the new file.
> 
> > 
> > CHECK: Alignment should match open parenthesis
> > #68: FILE: drivers/tee/optee/optee_trace.h:20:
> > +TRACE_EVENT(optee_invoke_fn_begin,
> > +	TP_PROTO(struct optee_rpc_param *param),
> > 
> > CHECK: Lines should not end with a '('
> > #71: FILE: drivers/tee/optee/optee_trace.h:23:
> > +	TP_STRUCT__entry(
> > 
> > CHECK: Lines should not end with a '('
> > #76: FILE: drivers/tee/optee/optee_trace.h:28:
> > +	TP_fast_assign(
> > 
> > CHECK: Alignment should match open parenthesis
> > #89: FILE: drivers/tee/optee/optee_trace.h:41:
> > +TRACE_EVENT(optee_invoke_fn_end,
> > +	TP_PROTO(struct optee_rpc_param *param, struct arm_smccc_res *res),
> > 
> > CHECK: Lines should not end with a '('
> > #92: FILE: drivers/tee/optee/optee_trace.h:44:
> > +	TP_STRUCT__entry(
> > 
> > CHECK: Lines should not end with a '('
> > #97: FILE: drivers/tee/optee/optee_trace.h:49:
> > +	TP_fast_assign(
> 
> The TRACE_EVENT() macro is "special", and checkpatch notoriously stumbles
> over it. I usually recommend that people ignore the checkpatch warnings on
> TRACE_EVENT() macros.

Makes sense. I'll pick this up as it is.

Thanks,
Jens

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jens Wiklander <jens.wiklander@linaro.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	op-tee@lists.trustedfirmware.org,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] tee: optee: add invoke_fn tracepoints
Date: Wed, 24 Feb 2021 09:10:54 +0100	[thread overview]
Message-ID: <20210224081054.GA2653493@jade> (raw)
In-Reply-To: <20210223091936.5b390f35@gandalf.local.home>

On Tue, Feb 23, 2021 at 09:19:36AM -0500, Steven Rostedt wrote:
> On Tue, 23 Feb 2021 14:11:24 +0100
> Jens Wiklander <jens.wiklander@linaro.org> wrote:
> 
> > I used the -strict option.
> > 
> > ./scripts/checkpatch.pl -strict 0001-tee-optee-add-invoke_fn-tracepoints.patch
> > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> > #44: 
> > new file mode 100644
> 
> The above is just asking for someone to take maintainership of the new file.
> 
> > 
> > CHECK: Alignment should match open parenthesis
> > #68: FILE: drivers/tee/optee/optee_trace.h:20:
> > +TRACE_EVENT(optee_invoke_fn_begin,
> > +	TP_PROTO(struct optee_rpc_param *param),
> > 
> > CHECK: Lines should not end with a '('
> > #71: FILE: drivers/tee/optee/optee_trace.h:23:
> > +	TP_STRUCT__entry(
> > 
> > CHECK: Lines should not end with a '('
> > #76: FILE: drivers/tee/optee/optee_trace.h:28:
> > +	TP_fast_assign(
> > 
> > CHECK: Alignment should match open parenthesis
> > #89: FILE: drivers/tee/optee/optee_trace.h:41:
> > +TRACE_EVENT(optee_invoke_fn_end,
> > +	TP_PROTO(struct optee_rpc_param *param, struct arm_smccc_res *res),
> > 
> > CHECK: Lines should not end with a '('
> > #92: FILE: drivers/tee/optee/optee_trace.h:44:
> > +	TP_STRUCT__entry(
> > 
> > CHECK: Lines should not end with a '('
> > #97: FILE: drivers/tee/optee/optee_trace.h:49:
> > +	TP_fast_assign(
> 
> The TRACE_EVENT() macro is "special", and checkpatch notoriously stumbles
> over it. I usually recommend that people ignore the checkpatch warnings on
> TRACE_EVENT() macros.

Makes sense. I'll pick this up as it is.

Thanks,
Jens

  reply	other threads:[~2021-02-24  8:10 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] < <CAHUa44E-_czjhRxr2JjggYu0sDCsRvOA3Uc=hqp7j5Cmtb9q0w@mail.gmail.com>
2021-02-23 10:40 ` [PATCH] tee: optee: add invoke_fn tracepoints Jisheng Zhang
2021-02-23 10:40   ` Jisheng Zhang
2021-02-23 10:40   ` Jisheng Zhang
2021-02-23 13:11   ` Jens Wiklander
2021-02-23 13:11     ` Jens Wiklander
2021-02-23 13:11     ` Jens Wiklander
2021-02-23 14:19     ` Steven Rostedt
2021-02-23 14:19       ` Steven Rostedt
2021-02-23 14:19       ` Steven Rostedt
2021-02-24  8:10       ` Jens Wiklander [this message]
2021-02-24  8:10         ` Jens Wiklander
2021-02-24  8:10         ` Jens Wiklander
2021-02-10  6:44 Jisheng Zhang
2021-02-10  6:44 ` Jisheng Zhang
2021-02-10  6:44 ` Jisheng Zhang
2021-02-10 14:37 ` Steven Rostedt
2021-02-10 14:37   ` Steven Rostedt
2021-02-10 14:37   ` Steven Rostedt
2021-02-23  7:59 ` Jens Wiklander
2021-02-23  7:59   ` Jens Wiklander
2021-02-23  7:59   ` Jens Wiklander
2021-03-24 14:34 ` Guenter Roeck
2021-03-24 14:34   ` Guenter Roeck
2021-03-24 14:34   ` Guenter Roeck
2021-03-24 14:48   ` Guenter Roeck
2021-03-24 14:48     ` Guenter Roeck
2021-03-24 14:48     ` Guenter Roeck
2021-03-24 14:53     ` Steven Rostedt
2021-03-24 14:53       ` Steven Rostedt
2021-03-24 14:53       ` Steven Rostedt
2021-03-25  3:50       ` Jisheng Zhang
2021-03-25  3:50         ` Jisheng Zhang
2021-03-25  3:50         ` Jisheng Zhang
2021-03-25  7:49         ` Jens Wiklander
2021-03-25  7:49           ` Jens Wiklander
2021-03-25  7:49           ` Jens Wiklander
  -- strict thread matches above, loose matches on Subject: below --
2021-02-09 11:02 Jisheng Zhang
2021-02-09 11:02 ` Jisheng Zhang
2021-02-09 11:02 ` Jisheng Zhang
2021-02-09 15:58 ` Steven Rostedt
2021-02-09 15:58   ` Steven Rostedt
2021-02-09 15:58   ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210224081054.GA2653493@jade \
    --to=jens.wiklander@linaro.org \
    --cc=op-tee@lists.trustedfirmware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.