All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: [lee-linaro:tb-fix-w1-warnings 15/194] drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2057 bw_calcs_init() warn: possible memory leak of 'dceip'
Date: Fri, 26 Feb 2021 12:07:05 +0300	[thread overview]
Message-ID: <20210226090705.GX2087@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 4158 bytes --]

tree:   https://git.linaro.org/people/lee.jones/linux.git tb-fix-w1-warnings
head:   88ee6a99115ba595216378f4f3f1eaf160547d1f
commit: 12f826c4dc0ee5a163fec3ac5aa6b8c7b9be552e [15/194] drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from the stack
config: parisc-randconfig-m031-20210225 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2057 bw_calcs_init() warn: possible memory leak of 'dceip'

vim +/dceip +2057 drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c

4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2042  void bw_calcs_init(struct bw_calcs_dceip *bw_dceip,
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2043  	struct bw_calcs_vbios *bw_vbios,
00c91d0d480a0c drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Joshua Aberback     2017-01-09  2044  	struct hw_asic_id asic_id)
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2045  {
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2046  	struct bw_calcs_dceip *dceip;
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2047  	struct bw_calcs_vbios *vbios;
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2048  
00c91d0d480a0c drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Joshua Aberback     2017-01-09  2049  	enum bw_calcs_version version = bw_calcs_version_from_asic_id(asic_id);
00c91d0d480a0c drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Joshua Aberback     2017-01-09  2050  
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2051  	dceip = kzalloc(sizeof(dceip), GFP_KERNEL);
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2052  	if (!dceip)
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2053  		return;
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2054  
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2055  	vbios = kzalloc(sizeof(vbios), GFP_KERNEL);
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2056  	if (!vbios)
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08 @2057  		return;

kfree(dceip);

12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2058  
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2059  	dceip->version = version;
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2060  
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2061  	switch (version) {
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2062  	case BW_CALCS_VERSION_CARRIZO:
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2063  		vbios->memory_type = bw_def_gddr5;
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2064  		vbios->dram_channel_width_in_bits = 64;
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2065  		vbios->number_of_dram_channels = asic_id.vram_width / vbios->dram_channel_width_in_bits;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32013 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: [lee-linaro:tb-fix-w1-warnings 15/194] drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2057 bw_calcs_init() warn: possible memory leak of 'dceip'
Date: Fri, 26 Feb 2021 12:07:05 +0300	[thread overview]
Message-ID: <20210226090705.GX2087@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 4158 bytes --]

tree:   https://git.linaro.org/people/lee.jones/linux.git tb-fix-w1-warnings
head:   88ee6a99115ba595216378f4f3f1eaf160547d1f
commit: 12f826c4dc0ee5a163fec3ac5aa6b8c7b9be552e [15/194] drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from the stack
config: parisc-randconfig-m031-20210225 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2057 bw_calcs_init() warn: possible memory leak of 'dceip'

vim +/dceip +2057 drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c

4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2042  void bw_calcs_init(struct bw_calcs_dceip *bw_dceip,
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2043  	struct bw_calcs_vbios *bw_vbios,
00c91d0d480a0c drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Joshua Aberback     2017-01-09  2044  	struct hw_asic_id asic_id)
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2045  {
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2046  	struct bw_calcs_dceip *dceip;
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2047  	struct bw_calcs_vbios *vbios;
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2048  
00c91d0d480a0c drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Joshua Aberback     2017-01-09  2049  	enum bw_calcs_version version = bw_calcs_version_from_asic_id(asic_id);
00c91d0d480a0c drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Joshua Aberback     2017-01-09  2050  
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2051  	dceip = kzalloc(sizeof(dceip), GFP_KERNEL);
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2052  	if (!dceip)
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2053  		return;
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2054  
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2055  	vbios = kzalloc(sizeof(vbios), GFP_KERNEL);
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2056  	if (!vbios)
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08 @2057  		return;

kfree(dceip);

12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2058  
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2059  	dceip->version = version;
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2060  
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2061  	switch (version) {
4562236b3bc0a2 drivers/gpu/drm/amd/display/dc/calcs/bandwidth_calcs.c Harry Wentland      2017-09-12  2062  	case BW_CALCS_VERSION_CARRIZO:
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2063  		vbios->memory_type = bw_def_gddr5;
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2064  		vbios->dram_channel_width_in_bits = 64;
12f826c4dc0ee5 drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c       Lee Jones           2021-01-08  2065  		vbios->number_of_dram_channels = asic_id.vram_width / vbios->dram_channel_width_in_bits;

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32013 bytes --]

             reply	other threads:[~2021-02-26  9:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26  9:07 Dan Carpenter [this message]
2021-02-26  9:07 ` [lee-linaro:tb-fix-w1-warnings 15/194] drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:2057 bw_calcs_init() warn: possible memory leak of 'dceip' Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2021-02-25 23:44 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226090705.GX2087@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.