From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net 2/2] igb: Fix duplicate include guard
Date: Fri, 26 Feb 2021 14:30:32 -0800 [thread overview]
Message-ID: <20210226143032.00005184@intel.com> (raw)
In-Reply-To: <20210222040005.20126-2-tseewald@gmail.com>
Tom Seewald wrote:
> The include guard "_E1000_HW_H_" is used by two separate header files in
> two different drivers (e1000/e1000_hw.h and igb/e1000_hw.h). Using the
> same include guard macro in more than one header file may cause
> unexpected behavior from the compiler. Fix this by renaming the
> duplicate guard in the igb driver.
>
> Fixes: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver")
> Signed-off-by: Tom Seewald <tseewald@gmail.com>
Change is simple and makes sense.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Tom Seewald <tseewald@gmail.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Jeff Garzik <jeff@garzik.org>,
Auke Kok <auke-jan.h.kok@intel.com>
Subject: Re: [PATCH net 2/2] igb: Fix duplicate include guard
Date: Fri, 26 Feb 2021 14:30:32 -0800 [thread overview]
Message-ID: <20210226143032.00005184@intel.com> (raw)
In-Reply-To: <20210222040005.20126-2-tseewald@gmail.com>
Tom Seewald wrote:
> The include guard "_E1000_HW_H_" is used by two separate header files in
> two different drivers (e1000/e1000_hw.h and igb/e1000_hw.h). Using the
> same include guard macro in more than one header file may cause
> unexpected behavior from the compiler. Fix this by renaming the
> duplicate guard in the igb driver.
>
> Fixes: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver")
> Signed-off-by: Tom Seewald <tseewald@gmail.com>
Change is simple and makes sense.
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
next prev parent reply other threads:[~2021-02-26 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 4:00 [Intel-wired-lan] [PATCH net 1/2] e1000e: Fix duplicate include guard Tom Seewald
2021-02-22 4:00 ` Tom Seewald
2021-02-22 4:00 ` [Intel-wired-lan] [PATCH net 2/2] igb: " Tom Seewald
2021-02-22 4:00 ` Tom Seewald
2021-02-26 22:30 ` Jesse Brandeburg [this message]
2021-02-26 22:30 ` Jesse Brandeburg
2021-03-02 7:55 ` [Intel-wired-lan] [PATCH net 1/2] e1000e: " Dvora Fuxbrumer
2021-03-02 7:55 ` Dvora Fuxbrumer
2021-03-02 8:29 ` Neftin, Sasha
2021-03-02 8:29 ` Neftin, Sasha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226143032.00005184@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.