From: "Michael S. Tsirkin" <mst@redhat.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, elic@nvidia.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero
Date: Sun, 28 Feb 2021 16:27:23 -0500 [thread overview]
Message-ID: <20210228162604-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <3e833db8-e132-0b00-34d0-7559bab10123@oracle.com>
On Thu, Feb 25, 2021 at 04:56:42PM -0800, Si-Wei Liu wrote:
>
> Hi Michael,
>
> Are you okay to live without this ioctl for now? I think QEMU is the one
> that needs to be fixed and will have to be made legacy guest aware. I think
> the kernel can just honor the feature negotiation result done by QEMU and do
> as what's told to.Will you agree?
>
> If it's fine, I would proceed to reverting commit fe36cbe067 and related
> code in question from the kernel.
>
> Thanks,
> -Siwei
Not really, I don't see why that's a good idea. fe36cbe067 is the code
checking MTU before FEATURES_OK. Spec explicitly allows that.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: Jason Wang <jasowang@redhat.com>,
elic@nvidia.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero
Date: Sun, 28 Feb 2021 16:27:23 -0500 [thread overview]
Message-ID: <20210228162604-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <3e833db8-e132-0b00-34d0-7559bab10123@oracle.com>
On Thu, Feb 25, 2021 at 04:56:42PM -0800, Si-Wei Liu wrote:
>
> Hi Michael,
>
> Are you okay to live without this ioctl for now? I think QEMU is the one
> that needs to be fixed and will have to be made legacy guest aware. I think
> the kernel can just honor the feature negotiation result done by QEMU and do
> as what's told to.Will you agree?
>
> If it's fine, I would proceed to reverting commit fe36cbe067 and related
> code in question from the kernel.
>
> Thanks,
> -Siwei
Not really, I don't see why that's a good idea. fe36cbe067 is the code
checking MTU before FEATURES_OK. Spec explicitly allows that.
--
MST
next prev parent reply other threads:[~2021-02-28 21:27 UTC|newest]
Thread overview: 196+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 11:54 [PATCH] vdpa/mlx5: set_features should allow reset to zero Si-Wei Liu
2021-02-19 11:54 ` Si-Wei Liu
2021-02-21 14:44 ` Eli Cohen
2021-02-21 21:52 ` Michael S. Tsirkin
2021-02-21 21:52 ` Michael S. Tsirkin
2021-02-22 6:05 ` Eli Cohen
2021-02-23 9:26 ` Michael S. Tsirkin
2021-02-23 9:26 ` Michael S. Tsirkin
2021-02-23 9:48 ` Jason Wang
2021-02-23 9:48 ` Jason Wang
2021-02-23 9:55 ` Michael S. Tsirkin
2021-02-23 9:55 ` Michael S. Tsirkin
2021-02-22 4:14 ` Jason Wang
2021-02-22 4:14 ` Jason Wang
2021-02-22 7:34 ` Michael S. Tsirkin
2021-02-22 7:34 ` Michael S. Tsirkin
2021-02-23 1:12 ` Si-Wei Liu
2021-02-23 1:12 ` Si-Wei Liu
2021-02-23 2:03 ` Jason Wang
2021-02-23 2:03 ` Jason Wang
2021-02-23 13:26 ` Michael S. Tsirkin
2021-02-23 13:26 ` Michael S. Tsirkin
2021-02-23 19:35 ` Si-Wei Liu
2021-02-23 19:35 ` Si-Wei Liu
2021-02-24 3:20 ` Jason Wang
2021-02-24 3:20 ` Jason Wang
2021-02-24 5:17 ` Michael S. Tsirkin
2021-02-24 5:17 ` Michael S. Tsirkin
2021-02-24 6:02 ` Jason Wang
2021-02-24 6:02 ` Jason Wang
2021-02-24 6:45 ` Eli Cohen
2021-02-24 6:47 ` Michael S. Tsirkin
2021-02-24 6:47 ` Michael S. Tsirkin
2021-02-24 6:55 ` Jason Wang
2021-02-24 6:55 ` Jason Wang
2021-02-24 7:12 ` Michael S. Tsirkin
2021-02-24 7:12 ` Michael S. Tsirkin
2021-02-24 12:40 ` Eli Cohen
2021-02-24 7:17 ` Eli Cohen
2021-02-24 5:04 ` Michael S. Tsirkin
2021-02-24 5:04 ` Michael S. Tsirkin
2021-02-24 6:04 ` Jason Wang
2021-02-24 6:04 ` Jason Wang
2021-02-24 6:46 ` Michael S. Tsirkin
2021-02-24 6:46 ` Michael S. Tsirkin
2021-02-24 6:53 ` Jason Wang
2021-02-24 6:53 ` Jason Wang
2021-02-24 7:17 ` Michael S. Tsirkin
2021-02-24 7:17 ` Michael S. Tsirkin
2021-02-24 8:26 ` Jason Wang
2021-02-24 8:43 ` Michael S. Tsirkin
2021-02-24 8:43 ` Michael S. Tsirkin
2021-02-24 9:30 ` Jason Wang
2021-02-24 9:30 ` Jason Wang
2021-02-28 21:30 ` Michael S. Tsirkin
2021-02-28 21:30 ` Michael S. Tsirkin
2021-03-01 3:53 ` Jason Wang
2021-03-01 3:53 ` Jason Wang
2021-02-24 18:24 ` Si-Wei Liu
2021-02-24 18:24 ` Si-Wei Liu
2021-02-26 0:35 ` Si-Wei Liu
2021-02-26 0:56 ` Si-Wei Liu
2021-02-26 0:56 ` Si-Wei Liu
2021-02-28 21:27 ` Michael S. Tsirkin [this message]
2021-02-28 21:27 ` Michael S. Tsirkin
2021-03-01 18:08 ` Si-Wei Liu
2021-03-01 18:08 ` Si-Wei Liu
2021-02-28 21:28 ` Michael S. Tsirkin
2021-02-28 21:28 ` Michael S. Tsirkin
2021-02-28 21:34 ` Michael S. Tsirkin
2021-02-28 21:34 ` Michael S. Tsirkin
2021-03-01 3:56 ` Jason Wang
2021-03-01 3:56 ` Jason Wang
2021-03-02 9:47 ` Michael S. Tsirkin
2021-03-02 9:47 ` Michael S. Tsirkin
2021-03-02 10:53 ` Jason Wang
2021-03-02 10:53 ` Jason Wang
2021-12-11 1:44 ` vdpa legacy guest support (was Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero) Si-Wei Liu
2021-12-11 1:44 ` Si-Wei Liu
2021-12-12 9:26 ` Michael S. Tsirkin
2021-12-12 9:26 ` Michael S. Tsirkin
2021-12-13 3:02 ` Jason Wang
2021-12-13 3:02 ` Jason Wang
2021-12-13 8:06 ` Michael S. Tsirkin
2021-12-13 8:06 ` Michael S. Tsirkin
2021-12-13 8:57 ` Jason Wang
2021-12-13 8:57 ` Jason Wang
2021-12-13 10:42 ` Michael S. Tsirkin
2021-12-13 10:42 ` Michael S. Tsirkin
2021-12-14 1:13 ` Si-Wei Liu
2021-12-14 1:13 ` Si-Wei Liu
2021-12-14 1:59 ` Si-Wei Liu
2021-12-14 1:59 ` Si-Wei Liu
2021-12-14 3:01 ` Jason Wang
2021-12-14 3:01 ` Jason Wang
2021-12-14 5:06 ` Michael S. Tsirkin
2021-12-14 5:06 ` Michael S. Tsirkin
2021-12-15 1:05 ` Si-Wei Liu
2021-12-15 1:05 ` Si-Wei Liu
2021-12-15 2:06 ` Jason Wang
2021-12-15 2:06 ` Jason Wang
2021-12-15 20:52 ` Si-Wei Liu
2021-12-15 20:52 ` Si-Wei Liu
2021-12-15 21:33 ` Michael S. Tsirkin
2021-12-15 21:33 ` Michael S. Tsirkin
2021-12-16 2:01 ` Si-Wei Liu
2021-12-16 2:01 ` Si-Wei Liu
2021-12-16 2:53 ` Jason Wang
2021-12-16 2:53 ` Jason Wang
2021-12-16 22:32 ` Si-Wei Liu
2021-12-16 22:32 ` Si-Wei Liu
2021-12-17 1:57 ` Jason Wang
2021-12-17 1:57 ` Jason Wang
2021-12-17 2:00 ` Michael S. Tsirkin
2021-12-17 2:00 ` Michael S. Tsirkin
2021-12-17 2:15 ` Jason Wang
2021-12-17 2:15 ` Jason Wang
2021-12-16 6:35 ` Michael S. Tsirkin
2021-12-16 6:35 ` Michael S. Tsirkin
2021-12-16 3:43 ` Jason Wang
2021-12-16 3:43 ` Jason Wang
2021-12-17 1:08 ` Si-Wei Liu
2021-12-17 1:08 ` Si-Wei Liu
2021-12-17 2:01 ` Jason Wang
2021-12-17 2:01 ` Jason Wang
2021-02-22 17:09 ` [PATCH] vdpa/mlx5: set_features should allow reset to zero Si-Wei Liu
2021-02-22 17:09 ` Si-Wei Liu
2021-02-23 2:03 ` Jason Wang
2021-02-23 2:03 ` Jason Wang
2021-02-23 9:25 ` [virtio-dev] " Michael S. Tsirkin
2021-02-23 9:25 ` Michael S. Tsirkin
2021-02-23 9:25 ` Michael S. Tsirkin
2021-02-23 9:46 ` [virtio-dev] " Jason Wang
2021-02-23 9:46 ` Jason Wang
2021-02-23 9:46 ` Jason Wang
2021-02-23 10:01 ` [virtio-dev] " Michael S. Tsirkin
2021-02-23 10:01 ` Michael S. Tsirkin
2021-02-23 10:01 ` Michael S. Tsirkin
2021-02-23 10:17 ` [virtio-dev] " Jason Wang
2021-02-23 10:17 ` Jason Wang
2021-02-23 10:17 ` Jason Wang
2021-02-24 9:40 ` [virtio-dev] " Jason Wang
2021-02-24 9:40 ` Jason Wang
2021-02-24 9:40 ` Jason Wang
2021-02-23 10:04 ` [virtio-dev] " Cornelia Huck
2021-02-23 10:04 ` Cornelia Huck
2021-02-23 10:04 ` Cornelia Huck
2021-02-23 10:31 ` Jason Wang
2021-02-23 10:31 ` Jason Wang
2021-02-23 10:31 ` Jason Wang
2021-02-23 10:58 ` Cornelia Huck
2021-02-23 10:58 ` Cornelia Huck
2021-02-23 10:58 ` Cornelia Huck
2021-02-24 9:29 ` Jason Wang
2021-02-24 9:29 ` Jason Wang
2021-02-24 9:29 ` Jason Wang
2021-02-24 11:12 ` Cornelia Huck
2021-02-24 11:12 ` Cornelia Huck
2021-02-24 11:12 ` Cornelia Huck
2021-02-25 4:36 ` Jason Wang
2021-02-25 4:36 ` Jason Wang
2021-02-25 4:36 ` Jason Wang
2021-02-25 13:26 ` Cornelia Huck
2021-02-25 13:26 ` Cornelia Huck
2021-02-25 13:26 ` Cornelia Huck
2021-02-25 18:53 ` Michael S. Tsirkin
2021-02-25 18:53 ` Michael S. Tsirkin
2021-02-25 18:53 ` Michael S. Tsirkin
2021-02-26 8:19 ` Jason Wang
2021-02-26 8:19 ` Jason Wang
2021-02-26 8:19 ` Jason Wang
2021-02-28 21:25 ` Michael S. Tsirkin
2021-02-28 21:25 ` Michael S. Tsirkin
2021-02-28 21:25 ` Michael S. Tsirkin
2021-03-01 3:51 ` Jason Wang
2021-03-01 3:51 ` Jason Wang
2021-03-01 3:51 ` Jason Wang
2021-03-02 12:08 ` Cornelia Huck
2021-03-02 12:08 ` Cornelia Huck
2021-03-02 12:08 ` Cornelia Huck
2021-03-03 4:01 ` Jason Wang
2021-03-03 4:01 ` Jason Wang
2021-03-03 8:29 ` Cornelia Huck
2021-03-03 8:29 ` Cornelia Huck
2021-03-03 8:29 ` Cornelia Huck
2021-03-04 8:24 ` Jason Wang
2021-03-04 8:24 ` Jason Wang
2021-03-04 8:24 ` Jason Wang
2021-03-04 13:50 ` Cornelia Huck
2021-03-04 13:50 ` Cornelia Huck
2021-03-04 13:50 ` Cornelia Huck
2021-03-05 3:01 ` Jason Wang
2021-03-05 3:01 ` Jason Wang
2021-03-05 3:01 ` Jason Wang
2021-02-23 12:26 ` Michael S. Tsirkin
2021-02-23 12:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210228162604-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=elic@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.