All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] vdpa/mlx5: Fix wrong use of bit numbers
Date: Tue, 2 Mar 2021 06:24:19 -0500	[thread overview]
Message-ID: <20210302062405-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210302052306.GA227464@mtl-vdi-166.wap.labs.mlnx>

On Tue, Mar 02, 2021 at 07:23:06AM +0200, Eli Cohen wrote:
> On Mon, Mar 01, 2021 at 10:33:14AM -0500, Michael S. Tsirkin wrote:
> > On Mon, Mar 01, 2021 at 03:52:45PM +0800, Jason Wang wrote:
> > > 
> > > On 2021/3/1 2:28 下午, Eli Cohen wrote:
> > > > VIRTIO_F_VERSION_1 is a bit number. Use BIT_ULL() with mask
> > > > conditionals.
> > > > 
> > > > Also, in mlx5_vdpa_is_little_endian() use BIT_ULL for consistency with
> > > > the rest of the code.
> > > > 
> > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> > > > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > > 
> > > 
> > > Acked-by: Jason Wang <jasowang@redhat.com>
> > 
> > And CC stable I guess?
> 
> Is this a question or a request? :-)

A question. net patches are cc'd by net maintainer.

> > 
> > > 
> > > > ---
> > > >   drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
> > > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > > index dc7031132fff..7d21b857a94a 100644
> > > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > > @@ -821,7 +821,7 @@ static int create_virtqueue(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtque
> > > >   	MLX5_SET(virtio_q, vq_ctx, event_qpn_or_msix, mvq->fwqp.mqp.qpn);
> > > >   	MLX5_SET(virtio_q, vq_ctx, queue_size, mvq->num_ent);
> > > >   	MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0,
> > > > -		 !!(ndev->mvdev.actual_features & VIRTIO_F_VERSION_1));
> > > > +		 !!(ndev->mvdev.actual_features & BIT_ULL(VIRTIO_F_VERSION_1)));
> > > >   	MLX5_SET64(virtio_q, vq_ctx, desc_addr, mvq->desc_addr);
> > > >   	MLX5_SET64(virtio_q, vq_ctx, used_addr, mvq->device_addr);
> > > >   	MLX5_SET64(virtio_q, vq_ctx, available_addr, mvq->driver_addr);
> > > > @@ -1578,7 +1578,7 @@ static void teardown_virtqueues(struct mlx5_vdpa_net *ndev)
> > > >   static inline bool mlx5_vdpa_is_little_endian(struct mlx5_vdpa_dev *mvdev)
> > > >   {
> > > >   	return virtio_legacy_is_little_endian() ||
> > > > -		(mvdev->actual_features & (1ULL << VIRTIO_F_VERSION_1));
> > > > +		(mvdev->actual_features & BIT_ULL(VIRTIO_F_VERSION_1));
> > > >   }
> > > >   static __virtio16 cpu_to_mlx5vdpa16(struct mlx5_vdpa_dev *mvdev, u16 val)
> > 

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: Jason Wang <jasowang@redhat.com>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: Fix wrong use of bit numbers
Date: Tue, 2 Mar 2021 06:24:19 -0500	[thread overview]
Message-ID: <20210302062405-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20210302052306.GA227464@mtl-vdi-166.wap.labs.mlnx>

On Tue, Mar 02, 2021 at 07:23:06AM +0200, Eli Cohen wrote:
> On Mon, Mar 01, 2021 at 10:33:14AM -0500, Michael S. Tsirkin wrote:
> > On Mon, Mar 01, 2021 at 03:52:45PM +0800, Jason Wang wrote:
> > > 
> > > On 2021/3/1 2:28 下午, Eli Cohen wrote:
> > > > VIRTIO_F_VERSION_1 is a bit number. Use BIT_ULL() with mask
> > > > conditionals.
> > > > 
> > > > Also, in mlx5_vdpa_is_little_endian() use BIT_ULL for consistency with
> > > > the rest of the code.
> > > > 
> > > > Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
> > > > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > > 
> > > 
> > > Acked-by: Jason Wang <jasowang@redhat.com>
> > 
> > And CC stable I guess?
> 
> Is this a question or a request? :-)

A question. net patches are cc'd by net maintainer.

> > 
> > > 
> > > > ---
> > > >   drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++--
> > > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > > index dc7031132fff..7d21b857a94a 100644
> > > > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> > > > @@ -821,7 +821,7 @@ static int create_virtqueue(struct mlx5_vdpa_net *ndev, struct mlx5_vdpa_virtque
> > > >   	MLX5_SET(virtio_q, vq_ctx, event_qpn_or_msix, mvq->fwqp.mqp.qpn);
> > > >   	MLX5_SET(virtio_q, vq_ctx, queue_size, mvq->num_ent);
> > > >   	MLX5_SET(virtio_q, vq_ctx, virtio_version_1_0,
> > > > -		 !!(ndev->mvdev.actual_features & VIRTIO_F_VERSION_1));
> > > > +		 !!(ndev->mvdev.actual_features & BIT_ULL(VIRTIO_F_VERSION_1)));
> > > >   	MLX5_SET64(virtio_q, vq_ctx, desc_addr, mvq->desc_addr);
> > > >   	MLX5_SET64(virtio_q, vq_ctx, used_addr, mvq->device_addr);
> > > >   	MLX5_SET64(virtio_q, vq_ctx, available_addr, mvq->driver_addr);
> > > > @@ -1578,7 +1578,7 @@ static void teardown_virtqueues(struct mlx5_vdpa_net *ndev)
> > > >   static inline bool mlx5_vdpa_is_little_endian(struct mlx5_vdpa_dev *mvdev)
> > > >   {
> > > >   	return virtio_legacy_is_little_endian() ||
> > > > -		(mvdev->actual_features & (1ULL << VIRTIO_F_VERSION_1));
> > > > +		(mvdev->actual_features & BIT_ULL(VIRTIO_F_VERSION_1));
> > > >   }
> > > >   static __virtio16 cpu_to_mlx5vdpa16(struct mlx5_vdpa_dev *mvdev, u16 val)
> > 


  reply	other threads:[~2021-03-02 11:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01  6:28 [PATCH] vdpa/mlx5: Fix wrong use of bit numbers Eli Cohen
2021-03-01  7:52 ` Jason Wang
2021-03-01  7:52   ` Jason Wang
2021-03-01 15:33   ` Michael S. Tsirkin
2021-03-01 15:33     ` Michael S. Tsirkin
2021-03-02  5:23     ` Eli Cohen
2021-03-02 11:24       ` Michael S. Tsirkin [this message]
2021-03-02 11:24         ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302062405-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=elic@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.