From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: Su Yue <l@damenly.su>, Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [report] lockdep warning when mounting seed device
Date: Tue, 2 Mar 2021 12:16:19 +0100 [thread overview]
Message-ID: <20210302111619.GG7604@suse.cz> (raw)
In-Reply-To: <4df51f3d-e63b-92be-aaf4-8198a0e95ff5@oracle.com>
On Tue, Mar 02, 2021 at 01:04:19PM +0800, Anand Jain wrote:
> On 26/02/2021 23:10, David Sterba wrote:
> > On Fri, Feb 26, 2021 at 01:01:02PM +0800, Anand Jain wrote:
> >> On 25/02/2021 12:39, Su Yue wrote:
> >>>
> >>> While playing with seed device(misc/next and v5.11), lockdep complains
> >>> the following:
> >>>
> >>> To reproduce:
> >>>
> >>> dev1=/dev/sdb1
> >>> dev2=/dev/sdb2
> >>>
> >>> umount /mnt
> >>>
> >>> mkfs.btrfs -f $dev1
> >>>
> >>> btrfstune -S 1 $dev1
> >>>
> >>> mount $dev1 /mnt
> >>>
> >>> btrfs device add $dev2 /mnt/ -f
> >>>
> >>> umount /mnt
> >>>
> >>> mount $dev2 /mnt
> >>>
> >>> umount /mnt
> >>>
> >>>
> >>
> >> In my understanding the commit 01d01caf19ff7c537527d352d169c4368375c0a1
> >> (btrfs: move the chunk_mutex in btrfs_read_chunk_tree
> >> fixed this bug in 5.9.
> >> Could you please try this [1] patch,
> >> [1]
> >> https://patchwork.kernel.org/project/linux-btrfs/patch/20200717100525.320697-1-anand.jain@oracle.com/
> >> Patch [1] still relevant as the device_list_mutex in clone_fs_devices()
> >> is redundant. We could remove it as well.
> >
> > So the fix 01d01caf19ff7c was not sufficient, the lockdep splat is
> > reproducible.
>
> Yes indeed. Except for adding another reported by, the patch[1] applies
> on misc-next as it is. Do you need a resend of the patch?
Yes please resend, we had other fixes around device locking and that
patch also has a nak because of other fixes so we need to put that into
the right context.
next prev parent reply other threads:[~2021-03-03 2:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 4:39 [report] lockdep warning when mounting seed device Su Yue
2021-02-26 5:01 ` Anand Jain
2021-02-26 5:59 ` Su Yue
2021-02-26 15:10 ` David Sterba
2021-03-02 5:04 ` Anand Jain
2021-03-02 11:16 ` David Sterba [this message]
2021-02-27 1:12 ` Chris Murphy
2021-02-27 3:34 ` damenly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302111619.GG7604@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=l@damenly.su \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.