From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.
Date: Tue, 02 Mar 2021 19:32:11 +0300 [thread overview]
Message-ID: <20210302163211.GW2222@kadam> (raw)
In-Reply-To: <20210302162805.GV2222@kadam>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
On Tue, Mar 02, 2021 at 07:28:05PM +0300, Dan Carpenter wrote:
> On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote:
> > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > > New smatch warnings:
> > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.
> > >
> > > Old smatch warnings:
> > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: uninitialized symbol 'pullup'.
> >
> > I don't think these are real problems, but maybe there is some way to explicitly
> > express that so that smatch knows as well?
>
> They will call syzbot warning at runtime as well. Syzbot complains
> about the read, and not that the value is important for flow analysis.
s/flow analysis/flow control/... Syzbot doesn't care if the
uninitialized value affects runtime.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.
Date: Tue, 02 Mar 2021 19:32:11 +0300 [thread overview]
Message-ID: <20210302163211.GW2222@kadam> (raw)
In-Reply-To: <20210302162805.GV2222@kadam>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
On Tue, Mar 02, 2021 at 07:28:05PM +0300, Dan Carpenter wrote:
> On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote:
> > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > > New smatch warnings:
> > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.
> > >
> > > Old smatch warnings:
> > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: uninitialized symbol 'pullup'.
> >
> > I don't think these are real problems, but maybe there is some way to explicitly
> > express that so that smatch knows as well?
>
> They will call syzbot warning at runtime as well. Syzbot complains
> about the read, and not that the value is important for flow analysis.
s/flow analysis/flow control/... Syzbot doesn't care if the
uninitialized value affects runtime.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
kbuild@lists.01.org, kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.
Date: Tue, 2 Mar 2021 19:32:11 +0300 [thread overview]
Message-ID: <20210302163211.GW2222@kadam> (raw)
In-Reply-To: <20210302162805.GV2222@kadam>
On Tue, Mar 02, 2021 at 07:28:05PM +0300, Dan Carpenter wrote:
> On Tue, Mar 02, 2021 at 04:47:01PM +0100, Linus Walleij wrote:
> > On Sat, Feb 27, 2021 at 10:22 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > > New smatch warnings:
> > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength'.
> > >
> > > Old smatch warnings:
> > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:457 lpi_config_set() error: uninitialized symbol 'pullup'.
> >
> > I don't think these are real problems, but maybe there is some way to explicitly
> > express that so that smatch knows as well?
>
> They will call syzbot warning at runtime as well. Syzbot complains
> about the read, and not that the value is important for flow analysis.
s/flow analysis/flow control/... Syzbot doesn't care if the
uninitialized value affects runtime.
regards,
dan carpenter
next prev parent reply other threads:[~2021-03-02 16:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 9:21 drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:458 lpi_config_set() error: uninitialized symbol 'strength' Dan Carpenter
2021-02-27 9:21 ` Dan Carpenter
2021-02-27 9:21 ` Dan Carpenter
2021-03-02 15:47 ` Linus Walleij
2021-03-02 15:47 ` Linus Walleij
2021-03-02 16:28 ` Dan Carpenter
2021-03-02 16:28 ` Dan Carpenter
2021-03-02 16:28 ` Dan Carpenter
2021-03-02 16:32 ` Dan Carpenter [this message]
2021-03-02 16:32 ` Dan Carpenter
2021-03-02 16:32 ` Dan Carpenter
2021-03-02 16:53 ` Bjorn Andersson
2021-03-02 16:53 ` Bjorn Andersson
2021-03-02 17:01 ` Dan Carpenter
2021-03-02 17:01 ` Dan Carpenter
2021-03-02 17:01 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-02-26 17:41 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302163211.GW2222@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.