All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'
Date: Wed, 03 Mar 2021 08:35:10 +0300	[thread overview]
Message-ID: <20210303053510.GW2087@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 5056 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7a7fd0de4a9804299793e564a555a49c1fc924cb
commit: dd65030295e20338bbb8238454c2e9546b6e5e17 soc: mediatek: pm-domains: Don't print an error if child domain is deferred
config: nds32-randconfig-m031-20210302 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'

vim +/ret +492 drivers/soc/mediatek/mtk-pm-domains.c

59b644b01cf48d Enric Balletbo i Serra 2020-10-30  465  static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *parent)
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  466  {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  467  	struct generic_pm_domain *child_pd, *parent_pd;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  468  	struct device_node *child;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  469  	int ret;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  470  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  471  	for_each_child_of_node(parent, child) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  472  		u32 id;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  473  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  474  		ret = of_property_read_u32(parent, "reg", &id);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  475  		if (ret) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  476  			dev_err(scpsys->dev, "%pOF: failed to get parent domain id\n", child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  477  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  478  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  479  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  480  		if (!scpsys->pd_data.domains[id]) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  481  			ret = -EINVAL;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  482  			dev_err(scpsys->dev, "power domain with id %d does not exist\n", id);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  483  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  484  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  485  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  486  		parent_pd = scpsys->pd_data.domains[id];
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  487  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  488  		child_pd = scpsys_add_one_domain(scpsys, child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  489  		if (IS_ERR(child_pd)) {
dd65030295e203 Enric Balletbo i Serra 2021-01-13  490  			dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
dd65030295e203 Enric Balletbo i Serra 2021-01-13  491  				      "%pOF: failed to get child domain id\n", child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 @492  			goto err_put_node;

err = PTR_ERR(child_pd);

59b644b01cf48d Enric Balletbo i Serra 2020-10-30  493  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  494  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  495  		ret = pm_genpd_add_subdomain(parent_pd, child_pd);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  496  		if (ret) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  497  			dev_err(scpsys->dev, "failed to add %s subdomain to parent %s\n",
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  498  				child_pd->name, parent_pd->name);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  499  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  500  		} else {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  501  			dev_dbg(scpsys->dev, "%s add subdomain: %s\n", parent_pd->name,
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  502  				child_pd->name);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  503  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  504  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  505  		/* recursive call to add all subdomains */
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  506  		ret = scpsys_add_subdomain(scpsys, child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  507  		if (ret)
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  508  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  509  	}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  510  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  511  	return 0;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  512  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  513  err_put_node:
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  514  	of_node_put(child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  515  	return ret;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  516  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28256 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'
Date: Wed, 03 Mar 2021 08:35:10 +0300	[thread overview]
Message-ID: <20210303053510.GW2087@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 5056 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7a7fd0de4a9804299793e564a555a49c1fc924cb
commit: dd65030295e20338bbb8238454c2e9546b6e5e17 soc: mediatek: pm-domains: Don't print an error if child domain is deferred
config: nds32-randconfig-m031-20210302 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'

vim +/ret +492 drivers/soc/mediatek/mtk-pm-domains.c

59b644b01cf48d Enric Balletbo i Serra 2020-10-30  465  static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *parent)
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  466  {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  467  	struct generic_pm_domain *child_pd, *parent_pd;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  468  	struct device_node *child;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  469  	int ret;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  470  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  471  	for_each_child_of_node(parent, child) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  472  		u32 id;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  473  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  474  		ret = of_property_read_u32(parent, "reg", &id);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  475  		if (ret) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  476  			dev_err(scpsys->dev, "%pOF: failed to get parent domain id\n", child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  477  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  478  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  479  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  480  		if (!scpsys->pd_data.domains[id]) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  481  			ret = -EINVAL;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  482  			dev_err(scpsys->dev, "power domain with id %d does not exist\n", id);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  483  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  484  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  485  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  486  		parent_pd = scpsys->pd_data.domains[id];
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  487  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  488  		child_pd = scpsys_add_one_domain(scpsys, child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  489  		if (IS_ERR(child_pd)) {
dd65030295e203 Enric Balletbo i Serra 2021-01-13  490  			dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
dd65030295e203 Enric Balletbo i Serra 2021-01-13  491  				      "%pOF: failed to get child domain id\n", child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 @492  			goto err_put_node;

err = PTR_ERR(child_pd);

59b644b01cf48d Enric Balletbo i Serra 2020-10-30  493  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  494  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  495  		ret = pm_genpd_add_subdomain(parent_pd, child_pd);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  496  		if (ret) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  497  			dev_err(scpsys->dev, "failed to add %s subdomain to parent %s\n",
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  498  				child_pd->name, parent_pd->name);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  499  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  500  		} else {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  501  			dev_dbg(scpsys->dev, "%s add subdomain: %s\n", parent_pd->name,
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  502  				child_pd->name);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  503  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  504  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  505  		/* recursive call to add all subdomains */
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  506  		ret = scpsys_add_subdomain(scpsys, child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  507  		if (ret)
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  508  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  509  	}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  510  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  511  	return 0;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  512  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  513  err_put_node:
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  514  	of_node_put(child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  515  	return ret;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  516  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 28256 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org,
	Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
	linux-kernel@vger.kernel.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Hsin-Yi Wang <hsinyi@chromium.org>
Subject: drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'
Date: Wed, 3 Mar 2021 08:35:10 +0300	[thread overview]
Message-ID: <20210303053510.GW2087@kadam> (raw)

[-- Attachment #1: Type: text/plain, Size: 4980 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7a7fd0de4a9804299793e564a555a49c1fc924cb
commit: dd65030295e20338bbb8238454c2e9546b6e5e17 soc: mediatek: pm-domains: Don't print an error if child domain is deferred
config: nds32-randconfig-m031-20210302 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'

vim +/ret +492 drivers/soc/mediatek/mtk-pm-domains.c

59b644b01cf48d Enric Balletbo i Serra 2020-10-30  465  static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *parent)
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  466  {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  467  	struct generic_pm_domain *child_pd, *parent_pd;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  468  	struct device_node *child;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  469  	int ret;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  470  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  471  	for_each_child_of_node(parent, child) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  472  		u32 id;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  473  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  474  		ret = of_property_read_u32(parent, "reg", &id);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  475  		if (ret) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  476  			dev_err(scpsys->dev, "%pOF: failed to get parent domain id\n", child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  477  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  478  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  479  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  480  		if (!scpsys->pd_data.domains[id]) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  481  			ret = -EINVAL;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  482  			dev_err(scpsys->dev, "power domain with id %d does not exist\n", id);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  483  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  484  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  485  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  486  		parent_pd = scpsys->pd_data.domains[id];
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  487  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  488  		child_pd = scpsys_add_one_domain(scpsys, child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  489  		if (IS_ERR(child_pd)) {
dd65030295e203 Enric Balletbo i Serra 2021-01-13  490  			dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
dd65030295e203 Enric Balletbo i Serra 2021-01-13  491  				      "%pOF: failed to get child domain id\n", child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 @492  			goto err_put_node;

err = PTR_ERR(child_pd);

59b644b01cf48d Enric Balletbo i Serra 2020-10-30  493  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  494  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  495  		ret = pm_genpd_add_subdomain(parent_pd, child_pd);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  496  		if (ret) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  497  			dev_err(scpsys->dev, "failed to add %s subdomain to parent %s\n",
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  498  				child_pd->name, parent_pd->name);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  499  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  500  		} else {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  501  			dev_dbg(scpsys->dev, "%s add subdomain: %s\n", parent_pd->name,
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  502  				child_pd->name);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  503  		}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  504  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  505  		/* recursive call to add all subdomains */
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  506  		ret = scpsys_add_subdomain(scpsys, child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  507  		if (ret)
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  508  			goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  509  	}
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  510  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  511  	return 0;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  512  
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  513  err_put_node:
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  514  	of_node_put(child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  515  	return ret;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30  516  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28256 bytes --]

             reply	other threads:[~2021-03-03  5:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  5:35 Dan Carpenter [this message]
2021-03-03  5:35 ` drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret' Dan Carpenter
2021-03-03  5:35 ` Dan Carpenter
  -- strict thread matches above, loose matches on Subject: below --
2021-03-02 17:51 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210303053510.GW2087@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.