All of lore.kernel.org
 help / color / mirror / Atom feed
* [mtd:nand/next 12/20] drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'
@ 2021-03-02 19:47 kernel test robot
  0 siblings, 0 replies; 5+ messages in thread
From: kernel test robot @ 2021-03-02 19:47 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 7194 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Sascha Hauer <s.hauer@pengutronix.de>
CC: Miquel Raynal <miquel.raynal@bootlin.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
head:   095b4dabff2a929cefd330110c5c578956213188
commit: 19877b2c5de809e6f553e158c263b7a8bb65222d [12/20] mtd: nand: fix error handling in nand_prog_page_op() #2
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: x86_64-randconfig-m001-20210302 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'

Old smatch warnings:
drivers/mtd/nand/raw/nand_base.c:842 nand_setup_interface() warn: missing error code 'ret'

vim +1466 drivers/mtd/nand/raw/nand_base.c

97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1423  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1424  /**
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1425   * nand_prog_page_op - Do a full PROG PAGE operation
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1426   * @chip: The NAND chip
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1427   * @page: page to write
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1428   * @offset_in_page: offset within the page
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1429   * @buf: buffer containing the data to write to the page
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1430   * @len: length of the buffer
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1431   *
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1432   * This function issues a full PROG PAGE operation.
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1433   * This function does not select/unselect the CS line.
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1434   *
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1435   * Returns 0 on success, a negative error code otherwise.
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1436   */
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1437  int nand_prog_page_op(struct nand_chip *chip, unsigned int page,
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1438  		      unsigned int offset_in_page, const void *buf,
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1439  		      unsigned int len)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1440  {
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1441  	struct mtd_info *mtd = nand_to_mtd(chip);
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1442  	u8 status;
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1443  	int ret;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1444  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1445  	if (!len || !buf)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1446  		return -EINVAL;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1447  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1448  	if (offset_in_page + len > mtd->writesize + mtd->oobsize)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1449  		return -EINVAL;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1450  
f2abfeb2078b96 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-11-11  1451  	if (nand_has_exec_op(chip)) {
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1452  		ret = nand_exec_prog_page_op(chip, page, offset_in_page, buf,
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1453  						len, true);
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1454  		if (ret)
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1455  			return ret;
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1456  
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1457  		ret = nand_status_op(chip, &status);
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1458  		if (ret)
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1459  			return ret;
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1460  	} else {
bf6065c6c08fa3 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1461  		chip->legacy.cmdfunc(chip, NAND_CMD_SEQIN, offset_in_page,
bf6065c6c08fa3 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1462  				     page);
716bbbabcc68c2 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1463  		chip->legacy.write_buf(chip, buf, len);
bf6065c6c08fa3 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1464  		chip->legacy.cmdfunc(chip, NAND_CMD_PAGEPROG, -1, -1);
8395b753d7cad2 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1465  		status = chip->legacy.waitfunc(chip);
52f67def97f1c5 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05 @1466  		if (status < 0)
52f67def97f1c5 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1467  			return status;
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1468  	}
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1469  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1470  	if (status & NAND_STATUS_FAIL)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1471  		return -EIO;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1472  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1473  	return 0;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1474  }
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1475  EXPORT_SYMBOL_GPL(nand_prog_page_op);
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1476  

:::::: The code@line 1466 was first introduced by commit
:::::: 52f67def97f1c56779a86babdc96ea65b3a0af3e mtd: nand: fix error handling in nand_prog_page_op() #1

:::::: TO: Sascha Hauer <s.hauer@pengutronix.de>
:::::: CC: Miquel Raynal <miquel.raynal@bootlin.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36904 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [mtd:nand/next 12/20] drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'
@ 2021-03-03  5:54 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-03-03  5:54 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 5238 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
head:   095b4dabff2a929cefd330110c5c578956213188
commit: 19877b2c5de809e6f553e158c263b7a8bb65222d [12/20] mtd: nand: fix error handling in nand_prog_page_op() #2
config: x86_64-randconfig-m001-20210302 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'

Old smatch warnings:
drivers/mtd/nand/raw/nand_base.c:842 nand_setup_interface() warn: missing error code 'ret'

vim +1466 drivers/mtd/nand/raw/nand_base.c

97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1437  int nand_prog_page_op(struct nand_chip *chip, unsigned int page,
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1438  		      unsigned int offset_in_page, const void *buf,
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1439  		      unsigned int len)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1440  {
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1441  	struct mtd_info *mtd = nand_to_mtd(chip);
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1442  	u8 status;
                                                                                        ^^^^^^^^^^
This needs to be changed to an int

19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1443  	int ret;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1444  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1445  	if (!len || !buf)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1446  		return -EINVAL;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1447  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1448  	if (offset_in_page + len > mtd->writesize + mtd->oobsize)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1449  		return -EINVAL;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1450  
f2abfeb2078b96 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-11-11  1451  	if (nand_has_exec_op(chip)) {
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1452  		ret = nand_exec_prog_page_op(chip, page, offset_in_page, buf,
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1453  						len, true);
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1454  		if (ret)
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1455  			return ret;
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1456  
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1457  		ret = nand_status_op(chip, &status);
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1458  		if (ret)
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1459  			return ret;
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1460  	} else {
bf6065c6c08fa3 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1461  		chip->legacy.cmdfunc(chip, NAND_CMD_SEQIN, offset_in_page,
bf6065c6c08fa3 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1462  				     page);
716bbbabcc68c2 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1463  		chip->legacy.write_buf(chip, buf, len);
bf6065c6c08fa3 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1464  		chip->legacy.cmdfunc(chip, NAND_CMD_PAGEPROG, -1, -1);
8395b753d7cad2 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1465  		status = chip->legacy.waitfunc(chip);
52f67def97f1c5 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05 @1466  		if (status < 0)
                                                                                                    ^^^^^^^^^^
for the error handling to work

52f67def97f1c5 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1467  			return status;
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1468  	}
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1469  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1470  	if (status & NAND_STATUS_FAIL)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1471  		return -EIO;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1472  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1473  	return 0;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1474  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36904 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [mtd:nand/next 12/20] drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'
@ 2021-03-03  5:54 ` Dan Carpenter
  0 siblings, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2021-03-03  5:54 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 5238 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
head:   095b4dabff2a929cefd330110c5c578956213188
commit: 19877b2c5de809e6f553e158c263b7a8bb65222d [12/20] mtd: nand: fix error handling in nand_prog_page_op() #2
config: x86_64-randconfig-m001-20210302 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'

Old smatch warnings:
drivers/mtd/nand/raw/nand_base.c:842 nand_setup_interface() warn: missing error code 'ret'

vim +1466 drivers/mtd/nand/raw/nand_base.c

97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1437  int nand_prog_page_op(struct nand_chip *chip, unsigned int page,
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1438  		      unsigned int offset_in_page, const void *buf,
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1439  		      unsigned int len)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1440  {
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1441  	struct mtd_info *mtd = nand_to_mtd(chip);
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1442  	u8 status;
                                                                                        ^^^^^^^^^^
This needs to be changed to an int

19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1443  	int ret;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1444  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1445  	if (!len || !buf)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1446  		return -EINVAL;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1447  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1448  	if (offset_in_page + len > mtd->writesize + mtd->oobsize)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1449  		return -EINVAL;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1450  
f2abfeb2078b96 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-11-11  1451  	if (nand_has_exec_op(chip)) {
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1452  		ret = nand_exec_prog_page_op(chip, page, offset_in_page, buf,
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1453  						len, true);
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1454  		if (ret)
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1455  			return ret;
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1456  
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1457  		ret = nand_status_op(chip, &status);
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1458  		if (ret)
19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1459  			return ret;
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1460  	} else {
bf6065c6c08fa3 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1461  		chip->legacy.cmdfunc(chip, NAND_CMD_SEQIN, offset_in_page,
bf6065c6c08fa3 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1462  				     page);
716bbbabcc68c2 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1463  		chip->legacy.write_buf(chip, buf, len);
bf6065c6c08fa3 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1464  		chip->legacy.cmdfunc(chip, NAND_CMD_PAGEPROG, -1, -1);
8395b753d7cad2 drivers/mtd/nand/raw/nand_base.c Boris Brezillon 2018-09-07  1465  		status = chip->legacy.waitfunc(chip);
52f67def97f1c5 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05 @1466  		if (status < 0)
                                                                                                    ^^^^^^^^^^
for the error handling to work

52f67def97f1c5 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1467  			return status;
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1468  	}
8878b126df7698 drivers/mtd/nand/nand_base.c     Miquel Raynal   2017-11-09  1469  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1470  	if (status & NAND_STATUS_FAIL)
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1471  		return -EIO;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1472  
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1473  	return 0;
97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1474  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36904 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [mtd:nand/next 12/20] drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'
  2021-03-03  5:54 ` Dan Carpenter
  (?)
@ 2021-03-03  6:40 ` Sascha Hauer
  2021-03-03  8:34   ` Miquel Raynal
  -1 siblings, 1 reply; 5+ messages in thread
From: Sascha Hauer @ 2021-03-03  6:40 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 3467 bytes --]

On Wed, Mar 03, 2021 at 08:54:42AM +0300, Dan Carpenter wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
> head:   095b4dabff2a929cefd330110c5c578956213188
> commit: 19877b2c5de809e6f553e158c263b7a8bb65222d [12/20] mtd: nand: fix error handling in nand_prog_page_op() #2
> config: x86_64-randconfig-m001-20210302 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> New smatch warnings:
> drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'
> 
> Old smatch warnings:
> drivers/mtd/nand/raw/nand_base.c:842 nand_setup_interface() warn: missing error code 'ret'
> 
> vim +1466 drivers/mtd/nand/raw/nand_base.c
> 
> 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1437  int nand_prog_page_op(struct nand_chip *chip, unsigned int page,
> 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1438  		      unsigned int offset_in_page, const void *buf,
> 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1439  		      unsigned int len)
> 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1440  {
> 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1441  	struct mtd_info *mtd = nand_to_mtd(chip);
> 19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1442  	u8 status;
>                                                                                         ^^^^^^^^^^
> This needs to be changed to an int

&status is passed to nand_status_op(), so this gives us:

drivers/mtd/nand/raw/nand_base.c:1457:30: error: passing argument 2 of ‘nand_status_op’ from incompatible pointer type [-Werror=incompatible-pointer-types]

I'd rather suggest the following.

Sascha

--------------------------------8<---------------------------------

>From ea216bee86618a04ea743fbdb59835c28e92c7c9 Mon Sep 17 00:00:00 2001
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: Wed, 3 Mar 2021 07:32:35 +0100
Subject: [PATCH] fixup! mtd: nand: fix error handling in nand_prog_page_op()
 #2

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 drivers/mtd/nand/raw/nand_base.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index 0f6babefaed2..4f263c22c80d 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -1462,9 +1462,10 @@ int nand_prog_page_op(struct nand_chip *chip, unsigned int page,
 				     page);
 		chip->legacy.write_buf(chip, buf, len);
 		chip->legacy.cmdfunc(chip, NAND_CMD_PAGEPROG, -1, -1);
-		status = chip->legacy.waitfunc(chip);
-		if (status < 0)
-			return status;
+		ret = chip->legacy.waitfunc(chip);
+		if (ret < 0)
+			return ret;
+		status = ret;
 	}
 
 	if (status & NAND_STATUS_FAIL)
-- 
2.29.2


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [mtd:nand/next 12/20] drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'
  2021-03-03  6:40 ` Sascha Hauer
@ 2021-03-03  8:34   ` Miquel Raynal
  0 siblings, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2021-03-03  8:34 UTC (permalink / raw)
  To: Sascha Hauer; +Cc: Dan Carpenter, kbuild, lkp, kbuild-all, linux-mtd

Hi Sascha,

Sascha Hauer <s.hauer@pengutronix.de> wrote on Wed, 3 Mar 2021 07:40:13
+0100:

> On Wed, Mar 03, 2021 at 08:54:42AM +0300, Dan Carpenter wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next
> > head:   095b4dabff2a929cefd330110c5c578956213188
> > commit: 19877b2c5de809e6f553e158c263b7a8bb65222d [12/20] mtd: nand: fix error handling in nand_prog_page_op() #2
> > config: x86_64-randconfig-m001-20210302 (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > 
> > New smatch warnings:
> > drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)'
> > 
> > Old smatch warnings:
> > drivers/mtd/nand/raw/nand_base.c:842 nand_setup_interface() warn: missing error code 'ret'
> > 
> > vim +1466 drivers/mtd/nand/raw/nand_base.c
> > 
> > 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1437  int nand_prog_page_op(struct nand_chip *chip, unsigned int page,
> > 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1438  		      unsigned int offset_in_page, const void *buf,
> > 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1439  		      unsigned int len)
> > 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1440  {
> > 97d90da8a88694 drivers/mtd/nand/nand_base.c     Boris Brezillon 2017-11-30  1441  	struct mtd_info *mtd = nand_to_mtd(chip);
> > 19877b2c5de809 drivers/mtd/nand/raw/nand_base.c Sascha Hauer    2021-02-05  1442  	u8 status;
> >                                                                                         ^^^^^^^^^^
> > This needs to be changed to an int  
> 
> &status is passed to nand_status_op(), so this gives us:
> 
> drivers/mtd/nand/raw/nand_base.c:1457:30: error: passing argument 2 of ‘nand_status_op’ from incompatible pointer type [-Werror=incompatible-pointer-types]
> 
> I'd rather suggest the following.
> 
> Sascha
> 
> --------------------------------8<---------------------------------
> 
> From ea216bee86618a04ea743fbdb59835c28e92c7c9 Mon Sep 17 00:00:00 2001
> From: Sascha Hauer <s.hauer@pengutronix.de>
> Date: Wed, 3 Mar 2021 07:32:35 +0100
> Subject: [PATCH] fixup! mtd: nand: fix error handling in nand_prog_page_op()
>  #2
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/mtd/nand/raw/nand_base.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> index 0f6babefaed2..4f263c22c80d 100644
> --- a/drivers/mtd/nand/raw/nand_base.c
> +++ b/drivers/mtd/nand/raw/nand_base.c
> @@ -1462,9 +1462,10 @@ int nand_prog_page_op(struct nand_chip *chip, unsigned int page,
>  				     page);
>  		chip->legacy.write_buf(chip, buf, len);
>  		chip->legacy.cmdfunc(chip, NAND_CMD_PAGEPROG, -1, -1);
> -		status = chip->legacy.waitfunc(chip);
> -		if (status < 0)
> -			return status;
> +		ret = chip->legacy.waitfunc(chip);
> +		if (ret < 0)
> +			return ret;
> +		status = ret;

Yep, LGTM. I edited the commit and pushed -f nand/next. Don't tell
Richard ;-)

Cheers,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-03 14:40 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-03  5:54 [mtd:nand/next 12/20] drivers/mtd/nand/raw/nand_base.c:1466 nand_prog_page_op() warn: impossible condition '(status < 0) => (0-255 < 0)' Dan Carpenter
2021-03-03  5:54 ` Dan Carpenter
2021-03-03  6:40 ` Sascha Hauer
2021-03-03  8:34   ` Miquel Raynal
  -- strict thread matches above, loose matches on Subject: below --
2021-03-02 19:47 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.