From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Chris Browy <cbrowy@avery-design.com>
Cc: <armbru@redhat.com>, <ben.widawsky@intel.com>,
<dan.j.williams@intel.com>, <david@redhat.com>, <f4bug@amsat.org>,
<imammedo@redhat.com>, <ira.weiny@intel.com>,
<jgroves@micron.com>, <linux-cxl@vger.kernel.org>,
<mst@redhat.com>, <qemu-devel@nongnu.org>,
<vishal.l.verma@intel.com>
Subject: Re: [RFC PATCH v2 1/2] Basic PCIe DOE support
Date: Thu, 4 Mar 2021 19:21:58 +0000 [thread overview]
Message-ID: <20210304192158.00004296@Huawei.com> (raw)
In-Reply-To: <1612902949-9992-1-git-send-email-cbrowy@avery-design.com>
On Tue, 9 Feb 2021 15:35:49 -0500
Chris Browy <cbrowy@avery-design.com> wrote:
Hi Chris,
One more thing hit whilst debugging linux side of this.
> +static void pcie_doe_irq_assert(DOECap *doe_cap)
> +{
> + PCIDevice *dev = doe_cap->doe->pdev;
> +
> + if (doe_cap->cap.intr && doe_cap->ctrl.intr) {
need something like
doe_cap->status.intr = 1;
I think or anyone checking the status register is going to think
this interrupt is spurious.
Otherwise all seems to work. I need to do a bit of tidying up on
kernel code but should be able to send out early next week.
> + /* Interrupt notify */
> + if (msix_enabled(dev)) {
> + msix_notify(dev, doe_cap->cap.vec);
> + } else if (msi_enabled(dev)) {
> + msi_notify(dev, doe_cap->cap.vec);
> + }
> + /* Not support legacy IRQ */
> + }
> +}
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Chris Browy <cbrowy@avery-design.com>
Cc: ben.widawsky@intel.com, david@redhat.com, qemu-devel@nongnu.org,
vishal.l.verma@intel.com, jgroves@micron.com, armbru@redhat.com,
linux-cxl@vger.kernel.org, f4bug@amsat.org, mst@redhat.com,
imammedo@redhat.com, dan.j.williams@intel.com,
ira.weiny@intel.com
Subject: Re: [RFC PATCH v2 1/2] Basic PCIe DOE support
Date: Thu, 4 Mar 2021 19:21:58 +0000 [thread overview]
Message-ID: <20210304192158.00004296@Huawei.com> (raw)
In-Reply-To: <1612902949-9992-1-git-send-email-cbrowy@avery-design.com>
On Tue, 9 Feb 2021 15:35:49 -0500
Chris Browy <cbrowy@avery-design.com> wrote:
Hi Chris,
One more thing hit whilst debugging linux side of this.
> +static void pcie_doe_irq_assert(DOECap *doe_cap)
> +{
> + PCIDevice *dev = doe_cap->doe->pdev;
> +
> + if (doe_cap->cap.intr && doe_cap->ctrl.intr) {
need something like
doe_cap->status.intr = 1;
I think or anyone checking the status register is going to think
this interrupt is spurious.
Otherwise all seems to work. I need to do a bit of tidying up on
kernel code but should be able to send out early next week.
> + /* Interrupt notify */
> + if (msix_enabled(dev)) {
> + msix_notify(dev, doe_cap->cap.vec);
> + } else if (msi_enabled(dev)) {
> + msi_notify(dev, doe_cap->cap.vec);
> + }
> + /* Not support legacy IRQ */
> + }
> +}
next prev parent reply other threads:[~2021-03-04 19:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 19:59 [RFC PATCH v2 0/2] PCIe DOE for PCIe and CXL 2.0 v2 release Chris Browy
2021-02-09 20:35 ` [RFC PATCH v2 1/2] Basic PCIe DOE support Chris Browy
2021-02-09 21:42 ` Ben Widawsky
2021-02-09 21:42 ` Ben Widawsky
2021-02-09 22:10 ` Chris Browy
2021-02-09 22:10 ` Chris Browy
2021-02-12 16:24 ` Jonathan Cameron
2021-02-12 16:24 ` Jonathan Cameron
2021-02-12 21:58 ` Chris Browy
2021-02-12 21:58 ` Chris Browy
2021-02-18 19:11 ` Jonathan Cameron
2021-02-18 19:11 ` Jonathan Cameron
2021-02-19 0:46 ` Chris Browy
2021-02-19 0:46 ` Chris Browy
2021-02-19 12:33 ` Jonathan Cameron
2021-02-19 12:33 ` Jonathan Cameron
2021-03-04 19:21 ` Jonathan Cameron [this message]
2021-03-04 19:21 ` Jonathan Cameron
2021-03-04 19:50 ` Chris Browy
2021-03-04 19:50 ` Chris Browy
2021-02-09 20:36 ` [RFC v2 2/2] Basic CXL DOE for CDAT and Compliance Mode Chris Browy
2021-02-09 21:53 ` Ben Widawsky
2021-02-09 21:53 ` Ben Widawsky
2021-02-09 22:53 ` Chris Browy
2021-02-09 22:53 ` Chris Browy
2021-02-12 17:23 ` Jonathan Cameron
2021-02-12 17:23 ` Jonathan Cameron
2021-02-12 22:26 ` Chris Browy
2021-02-12 22:26 ` Chris Browy
2021-02-18 19:15 ` Jonathan Cameron
2021-02-18 19:15 ` Jonathan Cameron
2021-02-19 0:53 ` Chris Browy
2021-02-19 0:53 ` Chris Browy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210304192158.00004296@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=armbru@redhat.com \
--cc=ben.widawsky@intel.com \
--cc=cbrowy@avery-design.com \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=ira.weiny@intel.com \
--cc=jgroves@micron.com \
--cc=linux-cxl@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.