* [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
@ 2021-02-09 0:52 ` Michael Walle
0 siblings, 0 replies; 12+ messages in thread
From: Michael Walle @ 2021-02-09 0:52 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Vladimir Oltean, Michael Walle
The legacy interrupt INT_A is hardwired to the event collector. RCEC is
bascially supported starting with v5.11. Having a correct interrupt, will
make RCEC at least probe correctly.
There are still issues with how RCEC is implemented in the RCiEP on the
LS1028A. RCEC will report an error, but it cannot find the correct
subdevice.
Signed-off-by: Michael Walle <michael@walle.cc>
---
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
index 262fbad8f0ec..c1f2f402ad53 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
@@ -1114,6 +1114,12 @@
full-duplex;
};
};
+
+ rcec@1f,0 {
+ reg = <0x00f800 0 0 0 0>;
+ /* IEP INT_A */
+ interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
+ };
};
rcpm: power-controller@1e34040 {
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
2021-02-09 0:52 ` Michael Walle
@ 2021-02-10 15:40 ` Vladimir Oltean
-1 siblings, 0 replies; 12+ messages in thread
From: Vladimir Oltean @ 2021-02-10 15:40 UTC (permalink / raw)
To: Michael Walle
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Leo Li,
Rob Herring, Shawn Guo, linux-arm-kernel@lists.infradead.org
On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote:
> The legacy interrupt INT_A is hardwired to the event collector. RCEC is
> bascially supported starting with v5.11. Having a correct interrupt, will
> make RCEC at least probe correctly.
>
> There are still issues with how RCEC is implemented in the RCiEP on the
> LS1028A. RCEC will report an error, but it cannot find the correct
> subdevice.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
@ 2021-02-10 15:40 ` Vladimir Oltean
0 siblings, 0 replies; 12+ messages in thread
From: Vladimir Oltean @ 2021-02-10 15:40 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Shawn Guo, Leo Li, Rob Herring
On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote:
> The legacy interrupt INT_A is hardwired to the event collector. RCEC is
> bascially supported starting with v5.11. Having a correct interrupt, will
> make RCEC at least probe correctly.
>
> There are still issues with how RCEC is implemented in the RCiEP on the
> LS1028A. RCEC will report an error, but it cannot find the correct
> subdevice.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
2021-02-09 0:52 ` Michael Walle
@ 2021-03-03 20:47 ` Michael Walle
-1 siblings, 0 replies; 12+ messages in thread
From: Michael Walle @ 2021-03-03 20:47 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Vladimir Oltean
Hi,
Am 2021-02-09 01:52, schrieb Michael Walle:
> The legacy interrupt INT_A is hardwired to the event collector. RCEC is
> bascially supported starting with v5.11. Having a correct interrupt,
> will
> make RCEC at least probe correctly.
>
> There are still issues with how RCEC is implemented in the RCiEP on the
> LS1028A. RCEC will report an error, but it cannot find the correct
> subdevice.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Any news on this?
-michael
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
@ 2021-03-03 20:47 ` Michael Walle
0 siblings, 0 replies; 12+ messages in thread
From: Michael Walle @ 2021-03-03 20:47 UTC (permalink / raw)
To: linux-arm-kernel, devicetree, linux-kernel
Cc: Shawn Guo, Li Yang, Rob Herring, Vladimir Oltean
Hi,
Am 2021-02-09 01:52, schrieb Michael Walle:
> The legacy interrupt INT_A is hardwired to the event collector. RCEC is
> bascially supported starting with v5.11. Having a correct interrupt,
> will
> make RCEC at least probe correctly.
>
> There are still issues with how RCEC is implemented in the RCiEP on the
> LS1028A. RCEC will report an error, but it cannot find the correct
> subdevice.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Any news on this?
-michael
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
2021-02-09 0:52 ` Michael Walle
@ 2021-03-04 11:37 ` Shawn Guo
-1 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2021-03-04 11:37 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Vladimir Oltean
On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote:
> The legacy interrupt INT_A is hardwired to the event collector. RCEC is
> bascially supported starting with v5.11. Having a correct interrupt, will
> make RCEC at least probe correctly.
>
> There are still issues with how RCEC is implemented in the RCiEP on the
> LS1028A. RCEC will report an error, but it cannot find the correct
> subdevice.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 262fbad8f0ec..c1f2f402ad53 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -1114,6 +1114,12 @@
> full-duplex;
> };
> };
> +
> + rcec@1f,0 {
Just curious how unit-address comes to '1f,0'?
Shawn
> + reg = <0x00f800 0 0 0 0>;
> + /* IEP INT_A */
> + interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> + };
> };
>
> rcpm: power-controller@1e34040 {
> --
> 2.20.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
@ 2021-03-04 11:37 ` Shawn Guo
0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2021-03-04 11:37 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Vladimir Oltean
On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote:
> The legacy interrupt INT_A is hardwired to the event collector. RCEC is
> bascially supported starting with v5.11. Having a correct interrupt, will
> make RCEC at least probe correctly.
>
> There are still issues with how RCEC is implemented in the RCiEP on the
> LS1028A. RCEC will report an error, but it cannot find the correct
> subdevice.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 262fbad8f0ec..c1f2f402ad53 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -1114,6 +1114,12 @@
> full-duplex;
> };
> };
> +
> + rcec@1f,0 {
Just curious how unit-address comes to '1f,0'?
Shawn
> + reg = <0x00f800 0 0 0 0>;
> + /* IEP INT_A */
> + interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> + };
> };
>
> rcpm: power-controller@1e34040 {
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
2021-03-04 11:37 ` Shawn Guo
@ 2021-03-04 11:59 ` Michael Walle
-1 siblings, 0 replies; 12+ messages in thread
From: Michael Walle @ 2021-03-04 11:59 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Vladimir Oltean
Am 2021-03-04 12:37, schrieb Shawn Guo:
> On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote:
>> The legacy interrupt INT_A is hardwired to the event collector. RCEC
>> is
>> bascially supported starting with v5.11. Having a correct interrupt,
>> will
>> make RCEC at least probe correctly.
>>
>> There are still issues with how RCEC is implemented in the RCiEP on
>> the
>> LS1028A. RCEC will report an error, but it cannot find the correct
>> subdevice.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index 262fbad8f0ec..c1f2f402ad53 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -1114,6 +1114,12 @@
>> full-duplex;
>> };
>> };
>> +
>> + rcec@1f,0 {
>
> Just curious how unit-address comes to '1f,0'?
You mean that it's pci dev 1f func 0?
0x00f800 >> 11 == 0x1f
See also:
https://elixir.bootlin.com/linux/v5.12-rc1/source/scripts/dtc/checks.c#L916
-michael
>
> Shawn
>
>> + reg = <0x00f800 0 0 0 0>;
>> + /* IEP INT_A */
>> + interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> };
>>
>> rcpm: power-controller@1e34040 {
>> --
>> 2.20.1
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
@ 2021-03-04 11:59 ` Michael Walle
0 siblings, 0 replies; 12+ messages in thread
From: Michael Walle @ 2021-03-04 11:59 UTC (permalink / raw)
To: Shawn Guo
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Vladimir Oltean
Am 2021-03-04 12:37, schrieb Shawn Guo:
> On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote:
>> The legacy interrupt INT_A is hardwired to the event collector. RCEC
>> is
>> bascially supported starting with v5.11. Having a correct interrupt,
>> will
>> make RCEC at least probe correctly.
>>
>> There are still issues with how RCEC is implemented in the RCiEP on
>> the
>> LS1028A. RCEC will report an error, but it cannot find the correct
>> subdevice.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> index 262fbad8f0ec..c1f2f402ad53 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
>> @@ -1114,6 +1114,12 @@
>> full-duplex;
>> };
>> };
>> +
>> + rcec@1f,0 {
>
> Just curious how unit-address comes to '1f,0'?
You mean that it's pci dev 1f func 0?
0x00f800 >> 11 == 0x1f
See also:
https://elixir.bootlin.com/linux/v5.12-rc1/source/scripts/dtc/checks.c#L916
-michael
>
> Shawn
>
>> + reg = <0x00f800 0 0 0 0>;
>> + /* IEP INT_A */
>> + interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> };
>>
>> rcpm: power-controller@1e34040 {
>> --
>> 2.20.1
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
2021-02-09 0:52 ` Michael Walle
@ 2021-03-05 0:35 ` Shawn Guo
-1 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2021-03-05 0:35 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Vladimir Oltean
On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote:
> The legacy interrupt INT_A is hardwired to the event collector. RCEC is
> bascially supported starting with v5.11. Having a correct interrupt, will
> make RCEC at least probe correctly.
>
> There are still issues with how RCEC is implemented in the RCiEP on the
> LS1028A. RCEC will report an error, but it cannot find the correct
> subdevice.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] arm64: dts: ls1028a: add interrupt to Root Complex Event Collector
@ 2021-03-05 0:35 ` Shawn Guo
0 siblings, 0 replies; 12+ messages in thread
From: Shawn Guo @ 2021-03-05 0:35 UTC (permalink / raw)
To: Michael Walle
Cc: linux-arm-kernel, devicetree, linux-kernel, Li Yang, Rob Herring,
Vladimir Oltean
On Tue, Feb 09, 2021 at 01:52:59AM +0100, Michael Walle wrote:
> The legacy interrupt INT_A is hardwired to the event collector. RCEC is
> bascially supported starting with v5.11. Having a correct interrupt, will
> make RCEC at least probe correctly.
>
> There are still issues with how RCEC is implemented in the RCiEP on the
> LS1028A. RCEC will report an error, but it cannot find the correct
> subdevice.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread