All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
To: angkery <angkery@163.com>
Cc: Junlin Yang <yangjunlin@yulong.com>,
	linux-kernel@vger.kernel.org, kuba@kernel.org,
	netdev@vger.kernel.org, ljp@linux.ibm.com, drt@linux.ibm.com,
	paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
	davem@davemloft.net
Subject: Re: [PATCH] ibmvnic: remove excessive irqsave
Date: Thu, 4 Mar 2021 20:19:10 -0800	[thread overview]
Message-ID: <20210305041910.GA1396452@us.ibm.com> (raw)
In-Reply-To: <20210305014350.1460-1-angkery@163.com>

angkery [angkery@163.com] wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
> 
> ibmvnic_remove locks multiple spinlocks while disabling interrupts:
> spin_lock_irqsave(&adapter->state_lock, flags);
> spin_lock_irqsave(&adapter->rwi_lock, flags);
> 
> there is no need for the second irqsave,since interrupts are disabled
> at that point, so remove the second irqsave:
> spin_lock_irqsave(&adapter->state_lock, flags);
> spin_lock(&adapter->rwi_lock);
> 
> Generated by: ./scripts/coccinelle/locks/flags.cocci
> ./drivers/net/ethernet/ibm/ibmvnic.c:5413:1-18:
> ERROR: nested lock+irqsave that reuses flags from line 5404.
> 

Thanks. Please add

Fixes: 4a41c421f367 ("ibmvnic: serialize access to work queue on remove")

> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>

Reviewed-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>

WARNING: multiple messages have this Message-ID (diff)
From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
To: angkery <angkery@163.com>
Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
	drt@linux.ibm.com, ljp@linux.ibm.com, davem@davemloft.net,
	kuba@kernel.org, linuxppc-dev@lists.ozlabs.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Junlin Yang <yangjunlin@yulong.com>
Subject: Re: [PATCH] ibmvnic: remove excessive irqsave
Date: Thu, 4 Mar 2021 20:19:10 -0800	[thread overview]
Message-ID: <20210305041910.GA1396452@us.ibm.com> (raw)
In-Reply-To: <20210305014350.1460-1-angkery@163.com>

angkery [angkery@163.com] wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
> 
> ibmvnic_remove locks multiple spinlocks while disabling interrupts:
> spin_lock_irqsave(&adapter->state_lock, flags);
> spin_lock_irqsave(&adapter->rwi_lock, flags);
> 
> there is no need for the second irqsave,since interrupts are disabled
> at that point, so remove the second irqsave:
> spin_lock_irqsave(&adapter->state_lock, flags);
> spin_lock(&adapter->rwi_lock);
> 
> Generated by: ./scripts/coccinelle/locks/flags.cocci
> ./drivers/net/ethernet/ibm/ibmvnic.c:5413:1-18:
> ERROR: nested lock+irqsave that reuses flags from line 5404.
> 

Thanks. Please add

Fixes: 4a41c421f367 ("ibmvnic: serialize access to work queue on remove")

> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>

Reviewed-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>

  reply	other threads:[~2021-03-05  4:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05  1:43 [PATCH] ibmvnic: remove excessive irqsave angkery
2021-03-05  1:43 ` angkery
2021-03-05  4:19 ` Sukadev Bhattiprolu [this message]
2021-03-05  4:19   ` Sukadev Bhattiprolu
2021-03-05  5:49 ` Christophe Leroy
2021-03-05  6:04   ` Lijun Pan
2021-03-05  6:04     ` Lijun Pan
2021-03-05  7:03   ` angkery
2021-03-05  7:03     ` angkery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210305041910.GA1396452@us.ibm.com \
    --to=sukadev@linux.ibm.com \
    --cc=angkery@163.com \
    --cc=davem@davemloft.net \
    --cc=drt@linux.ibm.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ljp@linux.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=yangjunlin@yulong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.