* [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang
@ 2021-03-05 7:34 Gustavo A. R. Silva
2021-03-05 20:48 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 7:34 UTC (permalink / raw)
To: Vladimir Oltean, Claudiu Manoil, Alexandre Belloni,
David S. Miller, Jakub Kicinski
Cc: UNGLinuxDriver, netdev, linux-kernel, Gustavo A. R. Silva,
linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/ethernet/mscc/ocelot_vcap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.c b/drivers/net/ethernet/mscc/ocelot_vcap.c
index 37a232911395..7945393a0655 100644
--- a/drivers/net/ethernet/mscc/ocelot_vcap.c
+++ b/drivers/net/ethernet/mscc/ocelot_vcap.c
@@ -761,6 +761,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix,
vcap_key_bytes_set(vcap, &data, VCAP_IS1_HK_ETYPE,
etype.value, etype.mask);
}
+ break;
}
default:
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang
2021-03-05 7:34 [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-03-05 20:48 ` David Miller
2021-03-05 22:37 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2021-03-05 20:48 UTC (permalink / raw)
To: gustavoars
Cc: vladimir.oltean, claudiu.manoil, alexandre.belloni, kuba,
UNGLinuxDriver, netdev, linux-kernel, linux-hardening
Please resubmit these again when net-next opens back up, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang
2021-03-05 20:48 ` David Miller
@ 2021-03-05 22:37 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 22:37 UTC (permalink / raw)
To: David Miller
Cc: vladimir.oltean, claudiu.manoil, alexandre.belloni, kuba,
UNGLinuxDriver, netdev, linux-kernel, linux-hardening
On Fri, Mar 05, 2021 at 12:48:12PM -0800, David Miller wrote:
>
> Please resubmit these again when net-next opens back up, thank you.
Sure thing.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-05 22:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-05 7:34 [PATCH][next] net: mscc: ocelot: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-05 20:48 ` David Miller
2021-03-05 22:37 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.