* [PATCH v3][next] ubi: Fix fall-through warnings for Clang
@ 2021-03-05 8:28 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 8:28 UTC (permalink / raw)
To: Richard Weinberger, Miquel Raynal, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Gustavo A. R. Silva, linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
Changes in v3:
Update the changelog text according to the actual code change.
Changes in v2:
Make use of a break statement instead of fallthrough, for consistency.
Link: https://lore.kernel.org/lkml/20201123093347.719a77cf@xps13/
drivers/mtd/ubi/build.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index f399edc82191..a7e3eb9befb6 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -1350,6 +1350,7 @@ static int bytes_str_to_int(const char *str)
fallthrough;
case 'K':
result *= 1024;
+ break;
case '\0':
break;
default:
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v3][next] ubi: Fix fall-through warnings for Clang
@ 2021-03-05 8:28 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 8:28 UTC (permalink / raw)
To: Richard Weinberger, Miquel Raynal, Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Gustavo A. R. Silva, linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
Changes in v3:
Update the changelog text according to the actual code change.
Changes in v2:
Make use of a break statement instead of fallthrough, for consistency.
Link: https://lore.kernel.org/lkml/20201123093347.719a77cf@xps13/
drivers/mtd/ubi/build.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index f399edc82191..a7e3eb9befb6 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -1350,6 +1350,7 @@ static int bytes_str_to_int(const char *str)
fallthrough;
case 'K':
result *= 1024;
+ break;
case '\0':
break;
default:
--
2.27.0
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-05 8:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-05 8:28 [PATCH v3][next] ubi: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-05 8:28 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.