* [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang
@ 2021-03-05 8:52 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 8:52 UTC (permalink / raw)
To: intel-wired-lan
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
index 02b12736ea80..207f6ee3a7f6 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
@@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
case ICE_RX_PTYPE_INNER_PROT_UDP:
case ICE_RX_PTYPE_INNER_PROT_SCTP:
skb->ip_summed = CHECKSUM_UNNECESSARY;
+ break;
default:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH RESEND][next] ice: Fix fall-through warnings for Clang
@ 2021-03-05 8:52 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 8:52 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Jakub Kicinski
Cc: intel-wired-lan, netdev, linux-kernel, Gustavo A. R. Silva,
linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of just letting the code
fall through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
index 02b12736ea80..207f6ee3a7f6 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
@@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
case ICE_RX_PTYPE_INNER_PROT_UDP:
case ICE_RX_PTYPE_INNER_PROT_SCTP:
skb->ip_summed = CHECKSUM_UNNECESSARY;
+ break;
default:
break;
}
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang
2021-03-05 8:52 ` Gustavo A. R. Silva
@ 2021-03-05 9:03 ` Paul Menzel
-1 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2021-03-05 9:03 UTC (permalink / raw)
To: intel-wired-lan
Dear Gustavo,
Thank you for working on that.
Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.
It would be nice to have a short summary of the discrepancy between GCC
and clang, and it was decided to go with the ?clang decision?, and not
have clang adapt to GCC.
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> index 02b12736ea80..207f6ee3a7f6 100644
> --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> @@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
> case ICE_RX_PTYPE_INNER_PROT_UDP:
> case ICE_RX_PTYPE_INNER_PROT_SCTP:
> skb->ip_summed = CHECKSUM_UNNECESSARY;
> + break;
> default:
> break;
> }
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang
@ 2021-03-05 9:03 ` Paul Menzel
0 siblings, 0 replies; 6+ messages in thread
From: Paul Menzel @ 2021-03-05 9:03 UTC (permalink / raw)
To: Gustavo A. R. Silva, Jesse Brandeburg, Tony Nguyen,
David S. Miller, Jakub Kicinski
Cc: linux-hardening, netdev, intel-wired-lan, linux-kernel
Dear Gustavo,
Thank you for working on that.
Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of just letting the code
> fall through to the next case.
It would be nice to have a short summary of the discrepancy between GCC
and clang, and it was decided to go with the “clang decision”, and not
have clang adapt to GCC.
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> index 02b12736ea80..207f6ee3a7f6 100644
> --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c
> @@ -143,6 +143,7 @@ ice_rx_csum(struct ice_ring *ring, struct sk_buff *skb,
> case ICE_RX_PTYPE_INNER_PROT_UDP:
> case ICE_RX_PTYPE_INNER_PROT_SCTP:
> skb->ip_summed = CHECKSUM_UNNECESSARY;
> + break;
> default:
> break;
> }
Kind regards,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang
2021-03-05 9:03 ` Paul Menzel
@ 2021-03-10 0:01 ` Brelinski, TonyX
-1 siblings, 0 replies; 6+ messages in thread
From: Brelinski, TonyX @ 2021-03-10 0:01 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Paul Menzel
> Sent: Friday, March 5, 2021 1:04 AM
> To: Gustavo A. R. Silva <gustavoars@kernel.org>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>;
> Jakub Kicinski <kuba@kernel.org>
> Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org; linux-
> hardening at vger.kernel.org; linux-kernel at vger.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through
> warnings for Clang
>
> Dear Gustavo,
>
>
> Thank you for working on that.
>
> Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> > warning by explicitly adding a break statement instead of just letting
> > the code fall through to the next case.
>
> It would be nice to have a short summary of the discrepancy between GCC
> and clang, and it was decided to go with the ?clang decision?, and not have
> clang adapt to GCC.
>
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> > drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
> > 1 file changed, 1 insertion(+)
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com> A Contingent Worker at Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang
@ 2021-03-10 0:01 ` Brelinski, TonyX
0 siblings, 0 replies; 6+ messages in thread
From: Brelinski, TonyX @ 2021-03-10 0:01 UTC (permalink / raw)
To: Paul Menzel, Gustavo A. R. Silva, Brandeburg, Jesse,
Nguyen, Anthony L, David S. Miller, Jakub Kicinski
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Paul Menzel
> Sent: Friday, March 5, 2021 1:04 AM
> To: Gustavo A. R. Silva <gustavoars@kernel.org>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>;
> Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux-
> hardening@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through
> warnings for Clang
>
> Dear Gustavo,
>
>
> Thank you for working on that.
>
> Am 05.03.21 um 09:52 schrieb Gustavo A. R. Silva:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> > warning by explicitly adding a break statement instead of just letting
> > the code fall through to the next case.
>
> It would be nice to have a short summary of the discrepancy between GCC
> and clang, and it was decided to go with the “clang decision”, and not have
> clang adapt to GCC.
>
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> > drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 1 +
> > 1 file changed, 1 insertion(+)
Tested-by: Tony Brelinski <tonyx.brelinski@intel.com> A Contingent Worker at Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-10 0:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-05 8:52 [Intel-wired-lan] [PATCH RESEND][next] ice: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-03-05 8:52 ` Gustavo A. R. Silva
2021-03-05 9:03 ` [Intel-wired-lan] " Paul Menzel
2021-03-05 9:03 ` Paul Menzel
2021-03-10 0:01 ` Brelinski, TonyX
2021-03-10 0:01 ` Brelinski, TonyX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.