* [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-03-05 9:56 ` Gustavo A. R. Silva 0 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-03-05 9:56 UTC (permalink / raw) To: Ben Skeggs, David Airlie, Daniel Vetter Cc: dri-devel, nouveau, linux-kernel, Gustavo A. R. Silva, linux-hardening In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 2375711877cf..62903c3b368d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) break; case TTM_PL_TT: error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); + break; default: break; } diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index 61e6d7412505..eb844cdcaec2 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, default: break; } + break; case DRM_MODE_SCALE_FULLSCREEN: case DRM_MODE_SCALE_CENTER: case DRM_MODE_SCALE_ASPECT: -- 2.27.0 ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-03-05 9:56 ` Gustavo A. R. Silva 0 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-03-05 9:56 UTC (permalink / raw) To: Ben Skeggs, David Airlie, Daniel Vetter Cc: nouveau, linux-hardening, linux-kernel, dri-devel, Gustavo A. R. Silva In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 2375711877cf..62903c3b368d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) break; case TTM_PL_TT: error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); + break; default: break; } diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index 61e6d7412505..eb844cdcaec2 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, default: break; } + break; case DRM_MODE_SCALE_FULLSCREEN: case DRM_MODE_SCALE_CENTER: case DRM_MODE_SCALE_ASPECT: -- 2.27.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-03-05 9:56 ` Gustavo A. R. Silva 0 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-03-05 9:56 UTC (permalink / raw) To: Ben Skeggs, David Airlie, Daniel Vetter Cc: nouveau, linux-hardening, linux-kernel, dri-devel, Gustavo A. R. Silva In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple of warnings by explicitly adding a couple of break statements instead of letting the code fall through to the next case. Link: https://github.com/KSPP/linux/issues/115 Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 2375711877cf..62903c3b368d 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) break; case TTM_PL_TT: error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); + break; default: break; } diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c index 61e6d7412505..eb844cdcaec2 100644 --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, default: break; } + break; case DRM_MODE_SCALE_FULLSCREEN: case DRM_MODE_SCALE_CENTER: case DRM_MODE_SCALE_ASPECT: -- 2.27.0 _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang 2021-03-05 9:56 ` [Nouveau] " Gustavo A. R. Silva (?) @ 2021-04-20 20:13 ` Gustavo A. R. Silva -1 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-04-20 20:13 UTC (permalink / raw) To: Gustavo A. R. Silva, Ben Skeggs, David Airlie, Daniel Vetter Cc: dri-devel, nouveau, linux-kernel, linux-hardening Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:56, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a couple of break statements instead > of letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > index 2375711877cf..62903c3b368d 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > break; > case TTM_PL_TT: > error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > index 61e6d7412505..eb844cdcaec2 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > default: > break; > } > + break; > case DRM_MODE_SCALE_FULLSCREEN: > case DRM_MODE_SCALE_CENTER: > case DRM_MODE_SCALE_ASPECT: > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-04-20 20:13 ` Gustavo A. R. Silva 0 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-04-20 20:13 UTC (permalink / raw) To: Gustavo A. R. Silva, Ben Skeggs, David Airlie, Daniel Vetter Cc: nouveau, linux-kernel, dri-devel, linux-hardening Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:56, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a couple of break statements instead > of letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > index 2375711877cf..62903c3b368d 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > break; > case TTM_PL_TT: > error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > index 61e6d7412505..eb844cdcaec2 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > default: > break; > } > + break; > case DRM_MODE_SCALE_FULLSCREEN: > case DRM_MODE_SCALE_CENTER: > case DRM_MODE_SCALE_ASPECT: > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-04-20 20:13 ` Gustavo A. R. Silva 0 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-04-20 20:13 UTC (permalink / raw) To: Gustavo A. R. Silva, Ben Skeggs, David Airlie, Daniel Vetter Cc: nouveau, linux-kernel, dri-devel, linux-hardening Hi all, Friendly ping: who can take this, please? Thanks -- Gustavo On 3/5/21 03:56, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > of warnings by explicitly adding a couple of break statements instead > of letting the code fall through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > index 2375711877cf..62903c3b368d 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > break; > case TTM_PL_TT: > error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > + break; > default: > break; > } > diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > index 61e6d7412505..eb844cdcaec2 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > default: > break; > } > + break; > case DRM_MODE_SCALE_FULLSCREEN: > case DRM_MODE_SCALE_CENTER: > case DRM_MODE_SCALE_ASPECT: > _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang 2021-04-20 20:13 ` [Nouveau] " Gustavo A. R. Silva (?) @ 2021-06-01 22:56 ` Gustavo A. R. Silva -1 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-06-01 22:56 UTC (permalink / raw) To: Gustavo A. R. Silva, Ben Skeggs, David Airlie, Daniel Vetter Cc: dri-devel, nouveau, linux-kernel, linux-hardening, Kees Cook Hi, Friendly second ping: who can take this? I can add this to my -next branch for 5.14 if you don't mind. JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings. Thanks -- Gustavo On 4/20/21 15:13, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple >> of warnings by explicitly adding a couple of break statements instead >> of letting the code fall through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c >> index 2375711877cf..62903c3b368d 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) >> break; >> case TTM_PL_TT: >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); >> + break; >> default: >> break; >> } >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c >> index 61e6d7412505..eb844cdcaec2 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, >> default: >> break; >> } >> + break; >> case DRM_MODE_SCALE_FULLSCREEN: >> case DRM_MODE_SCALE_CENTER: >> case DRM_MODE_SCALE_ASPECT: >> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-06-01 22:56 ` Gustavo A. R. Silva 0 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-06-01 22:56 UTC (permalink / raw) To: Gustavo A. R. Silva, Ben Skeggs, David Airlie, Daniel Vetter Cc: Kees Cook, nouveau, linux-kernel, dri-devel, linux-hardening Hi, Friendly second ping: who can take this? I can add this to my -next branch for 5.14 if you don't mind. JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings. Thanks -- Gustavo On 4/20/21 15:13, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple >> of warnings by explicitly adding a couple of break statements instead >> of letting the code fall through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c >> index 2375711877cf..62903c3b368d 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) >> break; >> case TTM_PL_TT: >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); >> + break; >> default: >> break; >> } >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c >> index 61e6d7412505..eb844cdcaec2 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, >> default: >> break; >> } >> + break; >> case DRM_MODE_SCALE_FULLSCREEN: >> case DRM_MODE_SCALE_CENTER: >> case DRM_MODE_SCALE_ASPECT: >> ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-06-01 22:56 ` Gustavo A. R. Silva 0 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-06-01 22:56 UTC (permalink / raw) To: Gustavo A. R. Silva, Ben Skeggs, David Airlie, Daniel Vetter Cc: Kees Cook, nouveau, linux-kernel, dri-devel, linux-hardening Hi, Friendly second ping: who can take this? I can add this to my -next branch for 5.14 if you don't mind. JFYI: We had thousands of these sorts of warnings and now we are down to just 23 in linux-next. This is one of those last remaining warnings. Thanks -- Gustavo On 4/20/21 15:13, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: who can take this, please? > > Thanks > -- > Gustavo > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple >> of warnings by explicitly adding a couple of break statements instead >> of letting the code fall through to the next case. >> >> Link: https://github.com/KSPP/linux/issues/115 >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >> --- >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c >> index 2375711877cf..62903c3b368d 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) >> break; >> case TTM_PL_TT: >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); >> + break; >> default: >> break; >> } >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c >> index 61e6d7412505..eb844cdcaec2 100644 >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, >> default: >> break; >> } >> + break; >> case DRM_MODE_SCALE_FULLSCREEN: >> case DRM_MODE_SCALE_CENTER: >> case DRM_MODE_SCALE_ASPECT: >> _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang 2021-06-01 22:56 ` [Nouveau] " Gustavo A. R. Silva (?) @ 2021-06-02 0:10 ` Karol Herbst -1 siblings, 0 replies; 15+ messages in thread From: Karol Herbst @ 2021-06-02 0:10 UTC (permalink / raw) To: Gustavo A. R. Silva Cc: Gustavo A. R. Silva, Ben Skeggs, David Airlie, Daniel Vetter, Kees Cook, nouveau, LKML, dri-devel, linux-hardening all three nouveau patches are Reviewed-by: Karol Herbst <kherbst@redhat.com> and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > > Hi, > > Friendly second ping: who can take this? > > I can add this to my -next branch for 5.14 if you don't mind. > > JFYI: We had thousands of these sorts of warnings and now we are down > to just 23 in linux-next. This is one of those last remaining warnings. > > Thanks > -- > Gustavo > > On 4/20/21 15:13, Gustavo A. R. Silva wrote: > > Hi all, > > > > Friendly ping: who can take this, please? > > > > Thanks > > -- > > Gustavo > > > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > >> of warnings by explicitly adding a couple of break statements instead > >> of letting the code fall through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > >> --- > >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> index 2375711877cf..62903c3b368d 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > >> break; > >> case TTM_PL_TT: > >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > >> + break; > >> default: > >> break; > >> } > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> index 61e6d7412505..eb844cdcaec2 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > >> default: > >> break; > >> } > >> + break; > >> case DRM_MODE_SCALE_FULLSCREEN: > >> case DRM_MODE_SCALE_CENTER: > >> case DRM_MODE_SCALE_ASPECT: > >> > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-06-02 0:10 ` Karol Herbst 0 siblings, 0 replies; 15+ messages in thread From: Karol Herbst @ 2021-06-02 0:10 UTC (permalink / raw) To: Gustavo A. R. Silva Cc: Kees Cook, David Airlie, nouveau, Gustavo A. R. Silva, dri-devel, LKML, Ben Skeggs, linux-hardening all three nouveau patches are Reviewed-by: Karol Herbst <kherbst@redhat.com> and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > > Hi, > > Friendly second ping: who can take this? > > I can add this to my -next branch for 5.14 if you don't mind. > > JFYI: We had thousands of these sorts of warnings and now we are down > to just 23 in linux-next. This is one of those last remaining warnings. > > Thanks > -- > Gustavo > > On 4/20/21 15:13, Gustavo A. R. Silva wrote: > > Hi all, > > > > Friendly ping: who can take this, please? > > > > Thanks > > -- > > Gustavo > > > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > >> of warnings by explicitly adding a couple of break statements instead > >> of letting the code fall through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > >> --- > >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> index 2375711877cf..62903c3b368d 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > >> break; > >> case TTM_PL_TT: > >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > >> + break; > >> default: > >> break; > >> } > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> index 61e6d7412505..eb844cdcaec2 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > >> default: > >> break; > >> } > >> + break; > >> case DRM_MODE_SCALE_FULLSCREEN: > >> case DRM_MODE_SCALE_CENTER: > >> case DRM_MODE_SCALE_ASPECT: > >> > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-06-02 0:10 ` Karol Herbst 0 siblings, 0 replies; 15+ messages in thread From: Karol Herbst @ 2021-06-02 0:10 UTC (permalink / raw) To: Gustavo A. R. Silva Cc: Kees Cook, David Airlie, nouveau, Gustavo A. R. Silva, dri-devel, LKML, Ben Skeggs, Daniel Vetter, linux-hardening all three nouveau patches are Reviewed-by: Karol Herbst <kherbst@redhat.com> and I don't think anybody would mind if those get into through other trees, but maybe drm-mist would be a good place for it if other patches involve other drm drivers? On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > > Hi, > > Friendly second ping: who can take this? > > I can add this to my -next branch for 5.14 if you don't mind. > > JFYI: We had thousands of these sorts of warnings and now we are down > to just 23 in linux-next. This is one of those last remaining warnings. > > Thanks > -- > Gustavo > > On 4/20/21 15:13, Gustavo A. R. Silva wrote: > > Hi all, > > > > Friendly ping: who can take this, please? > > > > Thanks > > -- > > Gustavo > > > > On 3/5/21 03:56, Gustavo A. R. Silva wrote: > >> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple > >> of warnings by explicitly adding a couple of break statements instead > >> of letting the code fall through to the next case. > >> > >> Link: https://github.com/KSPP/linux/issues/115 > >> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > >> --- > >> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + > >> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + > >> 2 files changed, 2 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> index 2375711877cf..62903c3b368d 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > >> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) > >> break; > >> case TTM_PL_TT: > >> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); > >> + break; > >> default: > >> break; > >> } > >> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> index 61e6d7412505..eb844cdcaec2 100644 > >> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c > >> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c > >> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, > >> default: > >> break; > >> } > >> + break; > >> case DRM_MODE_SCALE_FULLSCREEN: > >> case DRM_MODE_SCALE_CENTER: > >> case DRM_MODE_SCALE_ASPECT: > >> > _______________________________________________ > Nouveau mailing list > Nouveau@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/nouveau > _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang 2021-06-02 0:10 ` Karol Herbst (?) @ 2021-06-04 4:15 ` Gustavo A. R. Silva -1 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-06-04 4:15 UTC (permalink / raw) To: Karol Herbst Cc: Gustavo A. R. Silva, Ben Skeggs, David Airlie, Daniel Vetter, Kees Cook, nouveau, LKML, dri-devel, linux-hardening On 6/1/21 19:10, Karol Herbst wrote: > all three nouveau patches are > > Reviewed-by: Karol Herbst <kherbst@redhat.com> > > and I don't think anybody would mind if those get into through other > trees, but maybe drm-mist would be a good place for it if other > patches involve other drm drivers? No other person has replied after pinging multiple times and resending these patches, so I guess people don't care. I'll add this and the other similar patches to my -next branch for 5.14. Thanks, Karol. -- Gustavo > > On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> >> Hi, >> >> Friendly second ping: who can take this? >> >> I can add this to my -next branch for 5.14 if you don't mind. >> >> JFYI: We had thousands of these sorts of warnings and now we are down >> to just 23 in linux-next. This is one of those last remaining warnings. >> >> Thanks >> -- >> Gustavo >> >> On 4/20/21 15:13, Gustavo A. R. Silva wrote: >>> Hi all, >>> >>> Friendly ping: who can take this, please? >>> >>> Thanks >>> -- >>> Gustavo >>> >>> On 3/5/21 03:56, Gustavo A. R. Silva wrote: >>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple >>>> of warnings by explicitly adding a couple of break statements instead >>>> of letting the code fall through to the next case. >>>> >>>> Link: https://github.com/KSPP/linux/issues/115 >>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >>>> --- >>>> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + >>>> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + >>>> 2 files changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> index 2375711877cf..62903c3b368d 100644 >>>> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) >>>> break; >>>> case TTM_PL_TT: >>>> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); >>>> + break; >>>> default: >>>> break; >>>> } >>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> index 61e6d7412505..eb844cdcaec2 100644 >>>> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, >>>> default: >>>> break; >>>> } >>>> + break; >>>> case DRM_MODE_SCALE_FULLSCREEN: >>>> case DRM_MODE_SCALE_CENTER: >>>> case DRM_MODE_SCALE_ASPECT: >>>> >> _______________________________________________ >> Nouveau mailing list >> Nouveau@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/nouveau >> > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-06-04 4:15 ` Gustavo A. R. Silva 0 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-06-04 4:15 UTC (permalink / raw) To: Karol Herbst Cc: Kees Cook, David Airlie, nouveau, Gustavo A. R. Silva, dri-devel, LKML, Ben Skeggs, linux-hardening On 6/1/21 19:10, Karol Herbst wrote: > all three nouveau patches are > > Reviewed-by: Karol Herbst <kherbst@redhat.com> > > and I don't think anybody would mind if those get into through other > trees, but maybe drm-mist would be a good place for it if other > patches involve other drm drivers? No other person has replied after pinging multiple times and resending these patches, so I guess people don't care. I'll add this and the other similar patches to my -next branch for 5.14. Thanks, Karol. -- Gustavo > > On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> >> Hi, >> >> Friendly second ping: who can take this? >> >> I can add this to my -next branch for 5.14 if you don't mind. >> >> JFYI: We had thousands of these sorts of warnings and now we are down >> to just 23 in linux-next. This is one of those last remaining warnings. >> >> Thanks >> -- >> Gustavo >> >> On 4/20/21 15:13, Gustavo A. R. Silva wrote: >>> Hi all, >>> >>> Friendly ping: who can take this, please? >>> >>> Thanks >>> -- >>> Gustavo >>> >>> On 3/5/21 03:56, Gustavo A. R. Silva wrote: >>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple >>>> of warnings by explicitly adding a couple of break statements instead >>>> of letting the code fall through to the next case. >>>> >>>> Link: https://github.com/KSPP/linux/issues/115 >>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >>>> --- >>>> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + >>>> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + >>>> 2 files changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> index 2375711877cf..62903c3b368d 100644 >>>> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) >>>> break; >>>> case TTM_PL_TT: >>>> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); >>>> + break; >>>> default: >>>> break; >>>> } >>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> index 61e6d7412505..eb844cdcaec2 100644 >>>> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, >>>> default: >>>> break; >>>> } >>>> + break; >>>> case DRM_MODE_SCALE_FULLSCREEN: >>>> case DRM_MODE_SCALE_CENTER: >>>> case DRM_MODE_SCALE_ASPECT: >>>> >> _______________________________________________ >> Nouveau mailing list >> Nouveau@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/nouveau >> > ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Nouveau] [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang @ 2021-06-04 4:15 ` Gustavo A. R. Silva 0 siblings, 0 replies; 15+ messages in thread From: Gustavo A. R. Silva @ 2021-06-04 4:15 UTC (permalink / raw) To: Karol Herbst Cc: Kees Cook, David Airlie, nouveau, Gustavo A. R. Silva, dri-devel, LKML, Ben Skeggs, Daniel Vetter, linux-hardening On 6/1/21 19:10, Karol Herbst wrote: > all three nouveau patches are > > Reviewed-by: Karol Herbst <kherbst@redhat.com> > > and I don't think anybody would mind if those get into through other > trees, but maybe drm-mist would be a good place for it if other > patches involve other drm drivers? No other person has replied after pinging multiple times and resending these patches, so I guess people don't care. I'll add this and the other similar patches to my -next branch for 5.14. Thanks, Karol. -- Gustavo > > On Wed, Jun 2, 2021 at 1:16 AM Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> >> Hi, >> >> Friendly second ping: who can take this? >> >> I can add this to my -next branch for 5.14 if you don't mind. >> >> JFYI: We had thousands of these sorts of warnings and now we are down >> to just 23 in linux-next. This is one of those last remaining warnings. >> >> Thanks >> -- >> Gustavo >> >> On 4/20/21 15:13, Gustavo A. R. Silva wrote: >>> Hi all, >>> >>> Friendly ping: who can take this, please? >>> >>> Thanks >>> -- >>> Gustavo >>> >>> On 3/5/21 03:56, Gustavo A. R. Silva wrote: >>>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a couple >>>> of warnings by explicitly adding a couple of break statements instead >>>> of letting the code fall through to the next case. >>>> >>>> Link: https://github.com/KSPP/linux/issues/115 >>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> >>>> --- >>>> drivers/gpu/drm/nouveau/nouveau_bo.c | 1 + >>>> drivers/gpu/drm/nouveau/nouveau_connector.c | 1 + >>>> 2 files changed, 2 insertions(+) >>>> >>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> index 2375711877cf..62903c3b368d 100644 >>>> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c >>>> @@ -443,6 +443,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t domain, bool contig) >>>> break; >>>> case TTM_PL_TT: >>>> error |= !(domain & NOUVEAU_GEM_DOMAIN_GART); >>>> + break; >>>> default: >>>> break; >>>> } >>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> index 61e6d7412505..eb844cdcaec2 100644 >>>> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c >>>> @@ -157,6 +157,7 @@ nouveau_conn_atomic_set_property(struct drm_connector *connector, >>>> default: >>>> break; >>>> } >>>> + break; >>>> case DRM_MODE_SCALE_FULLSCREEN: >>>> case DRM_MODE_SCALE_CENTER: >>>> case DRM_MODE_SCALE_ASPECT: >>>> >> _______________________________________________ >> Nouveau mailing list >> Nouveau@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/nouveau >> > _______________________________________________ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2021-06-04 4:37 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-03-05 9:56 [PATCH RESEND][next] drm/nouveau: Fix fall-through warnings for Clang Gustavo A. R. Silva 2021-03-05 9:56 ` Gustavo A. R. Silva 2021-03-05 9:56 ` [Nouveau] " Gustavo A. R. Silva 2021-04-20 20:13 ` Gustavo A. R. Silva 2021-04-20 20:13 ` Gustavo A. R. Silva 2021-04-20 20:13 ` [Nouveau] " Gustavo A. R. Silva 2021-06-01 22:56 ` Gustavo A. R. Silva 2021-06-01 22:56 ` Gustavo A. R. Silva 2021-06-01 22:56 ` [Nouveau] " Gustavo A. R. Silva 2021-06-02 0:10 ` Karol Herbst 2021-06-02 0:10 ` Karol Herbst 2021-06-02 0:10 ` Karol Herbst 2021-06-04 4:15 ` Gustavo A. R. Silva 2021-06-04 4:15 ` Gustavo A. R. Silva 2021-06-04 4:15 ` Gustavo A. R. Silva
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.